Appsync datasource none #7145
Appsync datasource none #7145
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| /** | ||
| * Properties for an AppSync dummy datasource | ||
| */ | ||
| export interface NoneDataSourceProps extends BaseDataSourceProps { |
There was a problem hiding this comment.
@eladb whats your opinion on extending just for renaming like this? Is it appropriate for NoneDateSource to just accept BaseDataSourceProps?
There was a problem hiding this comment.
Ideally this datasource wouldn't allow you to set serviceRole at all.
My hacky workaround to this in #6836 (comment) was to do:
export interface NoneDataSourceProps extends BaseDataSourceProps {
readonly serviceRole?: undefined
}There was a problem hiding this comment.
One way to implement this would be to remove serviceRole from BaseDataSourceProps, and instead add it to a new BackedDataSourceProps interface that others can inherit from.
There was a problem hiding this comment.
This seems like something we should do sooner or later. @christophgysin you okay with implementing that here?
There was a problem hiding this comment.
Sure, will try to do this early next week.
There was a problem hiding this comment.
I have extracted serviceRole to BackedDataSourceProps. Please have a look at 154390d
There was a problem hiding this comment.
The question still remains if NoneDateSourceProps should exist at all, or if NoneDateSource should just accept BaseDataSourceProps?
There was a problem hiding this comment.
Let's keep NoneDataSourceProps for now.
christophgysin
force-pushed
the
appsync-datasource-none
branch
from
77e7f3c to
01f0670
Compare
christophgysin
force-pushed
the
appsync-datasource-none
branch
from
01f0670 to
ffdba44
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
4 participants
Commit Message
feat: Support AppSync DataSource type: NONE
End Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license