Allow installations via Ruby 2.4.x #109
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asaf-erlich
added a commit
that referenced
this pull request
Dec 7, 2017
|
I've merged in your code into our internal repo (you can see where the commit is mentioned above). The PR was out of date so I couldn't just merge in your commit. Thank you very much for the contribution. It should have been out in the agent release that occurred in December. |
|
Thanks! And now that MRI 2.5 is out, would a PR for that be welcome as well? :) |
|
Of course. :) |
|
@asaf-erlich Would you be able to merge the 2.5 support, this is critical to install the agent on Ubuntu 18.04 LTS, thanks |
|
@rohkat-aws is probably the right person to ping for this since he still works on the team. Good luck, |
philstrong
pushed a commit
to philstrong/aws-codedeploy-agent
that referenced
this pull request
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple enough (and it installed fine for me with this change using 2.4.1). Wonder if having the upper limit on Ruby versions is actually helpful? Though I'm guessing those who've been involved in this project for some time may know better :)