Skip to content

Conversation

pat
Copy link
Contributor

@pat pat commented Jan 24, 2018

As discussed in #109, here are the changes required for MRI 2.5 support.

@coveralls
Copy link

coveralls commented Jan 24, 2018

Coverage Status

Coverage remained the same at 92.095% when pulling a4ec962 on pat:mri2.5.0 into 9dcc4d9 on aws:master.

@pat
Copy link
Contributor Author

pat commented Jan 24, 2018

Also: if it's useful, I can submit another PR that extends the tested Ruby versions to cover the latest 2.x releases (rather than just 2.3) - though it's a simple enough change for a maintainer to do directly :)

@apeeters
Copy link

Would be nice to have this included soon since it is required for the Ubuntu Bionic release next Monday. Also an update of the dependencies of the deb package is needed.

@analytically
Copy link

"Current running Ruby version for root is 2.5.1, but Ruby version 2.x needs to be installed." when running on Ubuntu 18.04

@carlnordenfelt
Copy link

carlnordenfelt commented May 2, 2018

I raised this issue before I saw this PR: #158

The PR seems to have 2.5.0 as the upper boundary, not sure if it matters but a clean ruby install on 18.04 gives:

ruby --version
ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux-gnu]

Also note that I stumbled on another problem even after symlinking 2.4 to 2.5 to bypass the version check, that problem might be related to something else though.

@pat
Copy link
Contributor Author

pat commented May 3, 2018

This is not a recommendation - I'm not yet using this seriously in production - but how I've gone about installing things:

As noted by others here, the underlying package has a dependency on ruby2.0/ruby2.1/ruby2.2/ruby2.3. To work around this, I've got another branch that installs the package while ignoring the Ruby requirements (I've already compiled Ruby manually), and I use that instead:

wget "https://raw.githubusercontent.com/pat/aws-codedeploy-agent/mri2.5.0-no-dep/bin/install"

chmod +x ./install
sudo ./install auto

Use with extreme caution, and test thoroughly :)

@fleaz
Copy link

fleaz commented Jul 22, 2018

Hi @rohkat-aws, any updates on adding Ruby 2.5 support?
I don't want to sound rude or create any preasure but this PR is now half a year old and with the missing 2.5 support, many distros (incl. current Ubuntu LTS) are not able to install the CDA without any tinkering on the system.

I sadly have no Ruby experience, but let me now if I can help with anything :)

Best regards and thanks for your work!

@pmzara pmzara merged commit 866632b into aws:master Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants