Empty hooks in appspec #127

edward2a · 2017-07-28T09:01:26Z

Added type(Array) test for hooks before parsing.
Updated hook['script']['location'] test from (is present && is not nil) to 'is string'.

… object is not something unexpected

coveralls · 2017-07-28T09:04:03Z

Coverage increased (+0.001%) to 94.585% when pulling faaf682 on edward2a:empty_hooks_in_appspec into c510185 on aws:master.

edward2a added 3 commits July 28, 2017 09:45

no need for double testing, ruby returns nil if key doesn't exist

aa0e64e

check if hook is an array before iterating it

d119a39

checking if object is expected type is smaller scope than checking if…

faaf682

… object is not something unexpected

edward2a mentioned this pull request Jul 28, 2017

Empty hook causing deployment failure #125

Closed

feverLu merged commit f2731c4 into aws:master Sep 16, 2017

Provide feedback