Skip to content

Empty hooks in appspec #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2017
Merged

Empty hooks in appspec #127

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa0e64e
no need for double testing, ruby returns nil if key doesn't exist
edward2a Jul 28, 2017
d119a39
check if hook is an array before iterating it
edward2a Jul 28, 2017
faaf682
checking if object is expected type is smaller scope than checking if…
edward2a Jul 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions lib/instance_agent/plugins/codedeploy/application_specification/application_specification.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,18 @@ def parse_hooks(hooks_hash)
temp_hooks_hash = Hash.new
hooks_hash.each_pair do |hook, scripts|
current_hook_scripts = []
scripts.each do |script|
if (script.has_key?('location') && !script['location'].nil?)
current_hook_scripts << InstanceAgent::Plugins::CodeDeployPlugin::ApplicationSpecification::ScriptInfo.new(script['location'].to_s.strip,
{
:runas => script.has_key?('runas') && !script['runas'].nil? ? script['runas'].to_s.strip : nil,
:sudo => script['sudo'],
:timeout => script['timeout']
})
else
raise AppSpecValidationException, 'The deployment failed because the application specification file specifies a script with no location value. Specify the location in the hooks section of the AppSpec file, and then try again.'
if scripts.kind_of?(Array)
scripts.each do |script|
if script['location'].kind_of?(String)
current_hook_scripts << InstanceAgent::Plugins::CodeDeployPlugin::ApplicationSpecification::ScriptInfo.new(script['location'].to_s.strip,
{
:runas => script.has_key?('runas') && !script['runas'].nil? ? script['runas'].to_s.strip : nil,
:sudo => script['sudo'],
:timeout => script['timeout']
})
else
raise AppSpecValidationException, 'The deployment failed because the application specification file specifies a script with no location value. Specify the location in the hooks section of the AppSpec file, and then try again.'
end
end
end
temp_hooks_hash[hook] = current_hook_scripts
Expand Down