Skip to content

Conversation

lucasmcdonald3
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 commented Aug 28, 2025

Issue #, if available:

Description of changes:

end-of-stream introduced an unguarded reference to process in its patch version update from 1.4.4 to 1.4.5. (link)
process isn't broadly supported in browser environments, so this change effectively dropped support for browser for many consumers despite being a patch release.

This change: Limit support for end-of-stream to max 1.4.4 in our browser integration testing module.

(We don't use this package elsewhere in our browser modules.)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@lucasmcdonald3 lucasmcdonald3 requested a review from a team as a code owner August 28, 2025 17:17
@lucasmcdonald3 lucasmcdonald3 changed the title chore: Restrict end-of-stream chore(CI): Restrict end-of-stream version for browser test vectors Aug 28, 2025
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucasmcdonald3 lucasmcdonald3 merged commit fb10180 into master Aug 28, 2025
10 checks passed
@lucasmcdonald3 lucasmcdonald3 deleted the fix-ci branch August 28, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants