misc: artifact size metrics actions #150
Conversation
| upload: | ||
| description: Whether the metrics should be uploaded to S3/Cloudwatch | ||
| release_metrics: | ||
| description: Whether the metrics are coming from a release build |
There was a problem hiding this comment.
correctness: configure type: boolean
| # Check for large diff | ||
| if [ "$percent" -gt 5 ]; then | ||
| large_diff=true | ||
| fi |
There was a problem hiding this comment.
Are we no longer using the significantChangeThresholdPercentage configured in the plugin?
Let's delete it there if it's no longer being used
There was a problem hiding this comment.
Oops, forgot to delete all that. We never really changed the value from 5% so it doesn't seem necessary.
| echo "Artifact, Size (Bytes)" > "$output_file" | ||
|
|
||
| # Find all JARs (exclude sources and javadoc) | ||
| # TODO: Calculate KN artifacts sizes |
There was a problem hiding this comment.
do we have an internal task for this?
There was a problem hiding this comment.
We have an older task for it: SDK-KT-771
| if [ "$GITHUB_REPOSITORY" = "aws-sdk-kotlin" ]; then | ||
| # FIXME: Enable K/N builds | ||
| ./gradlew build -Paws.kotlin.native=false build --parallel --max-workers 16 | ||
| ./gradlew -Paws.kotlin.native=false publish --parallel --max-workers 16 |
There was a problem hiding this comment.
Shouldn't this be publishAllPublicationsToTestLocalRepository?
There was a problem hiding this comment.
It should be the same, our publishing configuration applies to AbstractPublishToMaven tasks. I can do some more testing and update this if needed.
There was a problem hiding this comment.
Changed this to publishAllPublicationsToTestLocalRepository in the codebuild job btw
| // Minimize the comment | ||
| await github.graphql(` | ||
| mutation { | ||
| minimizeComment(input: {subjectId: "${commentId}", classifier: RESOLVED}) { } | ||
| } | ||
| `) |
There was a problem hiding this comment.
Are we always minimizing the comment now?
There was a problem hiding this comment.
Yes, we rarely have to actually look at the metrics. If we do, it's really easy to just un-minimize a comment.
There was a problem hiding this comment.
Aren't the artifact sizes logged in the CI output? Maybe we don't need the comment at all
Issue #, if available:
N/A
Description of changes:
Adds actions that can be used downstream to deal with artifact size metrics
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.