misc: refactor artifact size metrics & service check batch #1701
Conversation
0marperez
added
the
no-changelog
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
| concurrency: | ||
| group: ${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| id-token: write | ||
| contents: read |
There was a problem hiding this comment.
nit: these typically go at the top of the file
| } | ||
|
|
||
| artifactSizeMetrics { | ||
| artifactPrefixes = setOf(":services", ":aws-runtime") |
There was a problem hiding this comment.
How are we filtering the artifact size computation to only these projects now?
There was a problem hiding this comment.
We're not filtering for artifacts from those two projects anymore. Now we're filtering for artifacts that are configured for publishing to Maven. Our updated codebuild service check job does this by running publishAllPublicationsToTestLocalRepository and then looking in the test local repository.
It should be better because we won't have to maintain hard coded lists anymore like this one. We never updated this to include hll's.
Issue #
N/A
Description of changes
Refactors service check batch, e2e tests, and artifact size metrics
See: aws/aws-kotlin-repo-tools#150
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.