DynamodbEnhanced client add preserve empty bean support #2364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
zoewangg
changed the title
bmaizels
reviewed
Apr 1, 2021
...a/software/amazon/awssdk/enhanced/dynamodb/mapper/annotations/DynamoDbPreserveEmptyBean.java
Outdated
Show resolved
Hide resolved
| this.buildItemFunction = builder.buildItemFunction; | ||
| this.tableMetadata = tableMetadataBuilder.build(); | ||
| this.itemType = EnhancedType.of(builder.itemClass); | ||
| this.preserveEmtpyBean = builder.itemClass.getAnnotation(DynamoDbPreserveEmptyBean.class) != null; |
Contributor
There was a problem hiding this comment.
Static*TableSchema must not perform any reflection. It must be statically configurable from its builder using properties and tags. We could achieve this by having a boolean builder property for example like
.preserveEmptyBean(true)
and then BeanTableSchema and ImmutableTableSchema would scan for the annotation and add that flag to the StaticImmutableTableSchema they were building.
Contributor
Author
There was a problem hiding this comment.
Yeah, I was not aware of this. I'll see if I can add a checkstyle for this.
Contributor
There was a problem hiding this comment.
It's more of a design thing than a technical limitation. StaticTableSchema and StaticImmutableTableSchema are both public classes (APIs) that customers that specifically do not want to use reflection can opt to use to construct their TableSchema instances without any runtime class metadata being involved. We wouldn't want to break that contract/promise.
...c/test/java/software/amazon/awssdk/enhanced/dynamodb/mapper/testbeans/PreserveEmptyBean.java
Outdated
Show resolved
Hide resolved
zoewangg
force-pushed
the
zoewang/preserveEmptyBean
branch
from
2044b11 to
5593b48
Compare
bmaizels
reviewed
Apr 6, 2021
...rc/main/java/software/amazon/awssdk/enhanced/dynamodb/DefaultAttributeConverterProvider.java
Outdated
Show resolved
Hide resolved
...m/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/EnhancedType.java
Outdated
Show resolved
Hide resolved
...m/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/EnhancedType.java
Outdated
Show resolved
Hide resolved
...om/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/TableSchema.java
Show resolved
Hide resolved
...a/software/amazon/awssdk/enhanced/dynamodb/mapper/annotations/DynamoDbPreserveEmptyBean.java
Outdated
Show resolved
Hide resolved
...c/test/java/software/amazon/awssdk/enhanced/dynamodb/mapper/testbeans/AbstractImmutable.java
Outdated
Show resolved
Hide resolved
...src/test/java/software/amazon/awssdk/enhanced/dynamodb/mapper/testbeans/NestedImmutable.java
Outdated
Show resolved
Hide resolved
cenedhryn
reviewed
Apr 7, 2021
...om/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/TableSchema.java
Show resolved
Hide resolved
...om/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/TableSchema.java
Outdated
Show resolved
Hide resolved
...rc/main/java/software/amazon/awssdk/enhanced/dynamodb/DefaultAttributeConverterProvider.java
Outdated
Show resolved
Hide resolved
...src/test/java/software/amazon/awssdk/enhanced/dynamodb/mapper/testbeans/NestedImmutable.java
Outdated
Show resolved
Hide resolved
zoewangg
force-pushed
the
zoewang/preserveEmptyBean
branch
from
a77e3ef to
8ae5081
Compare
bmaizels
reviewed
Apr 7, 2021
...rc/main/java/software/amazon/awssdk/enhanced/dynamodb/DefaultAttributeConverterProvider.java
Outdated
Show resolved
Hide resolved
...om/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/TableSchema.java
Outdated
Show resolved
Hide resolved
...om/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/TableSchema.java
Outdated
Show resolved
Hide resolved
cenedhryn
reviewed
Apr 8, 2021
Contributor
There was a problem hiding this comment.
Nice with a comprehensive example!
cenedhryn
approved these changes
Apr 8, 2021
…ass if all fields are null when mapping a DynamoDb record to a Java bean
bmaizels
approved these changes
Apr 8, 2021
Comment on lines
+180
to
+183
zoewangg
force-pushed
the
zoewang/preserveEmptyBean
branch
from
cfbee38 to
f2a0a69
Compare
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new attribute-level annotation that initializes a class as empty class if all fields are null when mapping a DynamoDb record to a Java bean
Motivation and Context
#2280 #2334
Testing
Added unit tests
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense