Skip to content

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Mar 11, 2020

Description

Motivation and Context

New Checkstyle version with security fixes.

Testing

mvn clean install

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@codecov-io
Copy link

Codecov Report

Merging #1700 into master will increase coverage by 0.01%.
The diff coverage is 82.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1700      +/-   ##
============================================
+ Coverage     75.34%   75.36%   +0.01%     
  Complexity     1473     1473              
============================================
  Files          1066     1066              
  Lines         31889    31918      +29     
  Branches       2461     2473      +12     
============================================
+ Hits          24028    24056      +28     
- Misses         6649     6652       +3     
+ Partials       1212     1210       -2
Flag Coverage Δ Complexity Δ
#unittests 75.36% <82.75%> (+0.01%) 1473 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...ernal/converter/string/BooleanStringConverter.java 100% <ø> (ø) 6 <0> (ø) ⬇️
...ernal/converter/string/InstantStringConverter.java 66.66% <ø> (ø) 2 <0> (ø) ⬇️
...ternal/converter/string/StringStringConverter.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...converter/string/LocalDateTimeStringConverter.java 66.66% <ø> (ø) 2 <0> (ø) ⬇️
.../s3/presigner/model/PresignedGetObjectRequest.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...oftware/amazon/awssdk/utils/http/SdkHttpUtils.java 93.25% <ø> (ø) 0 <0> (ø) ⬇️
...dk/core/internal/http/CombinedResponseHandler.java 87.23% <ø> (ø) 0 <0> (ø) ⬇️
...al/converter/string/OffsetTimeStringConverter.java 66.66% <ø> (ø) 2 <0> (ø) ⬇️
...internal/converter/string/YearStringConverter.java 66.66% <ø> (ø) 2 <0> (ø) ⬇️
...nal/converter/string/LocalTimeStringConverter.java 66.66% <ø> (ø) 2 <0> (ø) ⬇️
... and 171 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0099ee7...3676099. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dagnir dagnir merged commit 25f640c into aws:master Mar 11, 2020
@dagnir dagnir deleted the checkstyle branch March 11, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants