aws · dagnir · Mar 11, 2020 · Mar 11, 2020 · Mar 11, 2020
@@ -201,7 +201,7 @@
             <dependency>
                 <groupId>com.puppycrawl.tools</groupId>
                 <artifactId>checkstyle</artifactId>
-                <version>8.7</version>
+                <version>8.29</version>
             </dependency>
             <dependency>
                 <groupId>org.apache.maven.plugins</groupId>

@@ -66,7 +66,7 @@
         <dependency>
             <groupId>com.puppycrawl.tools</groupId>
             <artifactId>checkstyle</artifactId>
-            <version>8.18</version>
+            <version>8.29</version>
         </dependency>
     </dependencies>
 

@@ -69,12 +69,6 @@
             <property name="allowNonPrintableEscapes" value="true"/>
         </module>
 
-        <!-- Enforce maximum line lengths. -->
-        <module name="LineLength">
-            <property name="max" value="130"/>
-            <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
-        </module>
-
         <!-- Stars must not be used in import statements. -->
         <module name="AvoidStarImport"/>
 
@@ -386,4 +380,11 @@
         <!-- Checks that no 'final' are added on local variables -->
         <module name="software.amazon.awssdk.buildtools.checkstyle.UnnecessaryFinalOnLocalVariableCheck" />
     </module>
+
+        <!-- Enforce maximum line lengths. -->
+    <module name="LineLength">
+        <property name="max" value="130"/>
+        <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
+    </module>
+
 </module>
@@ -24,7 +24,8 @@ public final class RegionValidationUtil {
 
     private static final String FIPS_PREFIX = "fips-";
 
-    private RegionValidationUtil() {}
+    private RegionValidationUtil() {
+    }
 
     /**
      * Determines if a given region string is a "valid" AWS region.

@@ -54,7 +54,8 @@ public final class Endpoint implements Cloneable {
      */
     private String sslCommonName;
 
-    public Endpoint() {}
+    public Endpoint() {
+    }
 
     /**
      * Merges the given endpoints and returns the merged one.

@@ -62,7 +62,8 @@ public final class Partition {
      */
     private Endpoint defaults;
 
-    public Partition() {}
+    public Partition() {
+    }
 
     public Partition(@JsonProperty(value = "partition") String partition,
                      @JsonProperty(value = "regions") Map<String, PartitionRegion>

@@ -30,7 +30,8 @@ public final class PartitionRegion {
      */
     private String description;
 
-    public PartitionRegion() {}
+    public PartitionRegion() {
+    }
 
     public PartitionRegion(@JsonProperty(value = "description") String description) {
         this.description = Validate.notNull(description, "Region description");

@@ -36,7 +36,8 @@ public final class Partitions {
      */
     private List<Partition> partitions;
 
-    public Partitions() {}
+    public Partitions() {
+    }
 
     public Partitions(@JsonProperty(value = "version") String version,
                       @JsonProperty(value = "partitions") List<Partition> partitions) {

@@ -47,7 +47,8 @@ public final class Service {
      */
     private Boolean isRegionalized;
 
-    public Service() {}
+    public Service() {
+    }
 
     public Service(@JsonProperty(value = "endpoints") Map<String, Endpoint> endpoints) {
         this.endpoints = Validate.paramNotNull(endpoints, "endpoints");

@@ -24,7 +24,8 @@
  * A set of {@link Collector} implementations, similar to {@link Collectors}, but for poet types.
  */
 public final class PoetCollectors {
-    private PoetCollectors() {}
+    private PoetCollectors() {
+    }
 
     /**
      * Join a stream of code blocks into one code block.

@@ -19,9 +19,7 @@
 import com.squareup.javapoet.CodeBlock;
 import com.squareup.javapoet.ParameterizedTypeName;
 import com.squareup.javapoet.TypeName;
-
 import java.util.Optional;
-
 import software.amazon.awssdk.codegen.model.intermediate.IntermediateModel;
 import software.amazon.awssdk.codegen.model.intermediate.OperationModel;
 import software.amazon.awssdk.codegen.poet.PoetExtensions;

@@ -17,16 +17,15 @@
 
 import com.squareup.javapoet.ClassName;
 import com.squareup.javapoet.MethodSpec;
-
 import java.util.Arrays;
 import java.util.List;
 import javax.lang.model.element.Modifier;
-
 import software.amazon.awssdk.awscore.exception.AwsErrorDetails;
 
 public class ExceptionProperties {
 
-    private ExceptionProperties() {}
+    private ExceptionProperties() {
+    }
 
     public static List<MethodSpec> builderInterfaceMethods(ClassName className) {
         return Arrays.asList(

@@ -160,7 +160,8 @@ private static final class BuilderImpl implements Builder {
         private Boolean reuseLastProviderEnabled = true;
         private List<AwsCredentialsProvider> credentialsProviders = new ArrayList<>();
 
-        private BuilderImpl() {}
+        private BuilderImpl() {
+        }
 
         @Override
         public Builder reuseLastProviderEnabled(Boolean reuseLastProviderEnabled) {

@@ -122,7 +122,8 @@ public static final class Builder {
         /**
          * Created with {@link #builder()}.
          */
-        private Builder() {}
+        private Builder() {
+        }
 
         /**
          * Controls whether the provider should reuse the last successful credentials provider in the chain. Reusing the last

@@ -22,7 +22,6 @@
 import software.amazon.awssdk.annotations.SdkPublicApi;
 import software.amazon.awssdk.core.SdkSystemSetting;
 import software.amazon.awssdk.core.exception.SdkClientException;
-
 import software.amazon.awssdk.core.internal.util.UserAgentUtils;
 import software.amazon.awssdk.regions.internal.util.EC2MetadataUtils;
 import software.amazon.awssdk.regions.util.HttpResourcesUtils;

@@ -227,7 +227,8 @@ public static class Builder {
         /**
          * @see #builder()
          */
-        private Builder() {}
+        private Builder() {
+        }
 
         /**
          * Configure whether the provider should fetch credentials asynchronously in the background. If this is true, threads are

@@ -28,7 +28,8 @@ public final class WebIdentityCredentialsUtils {
     private static final String STS_WEB_IDENTITY_CREDENTIALS_PROVIDER_FACTORY =
         "software.amazon.awssdk.services.sts.internal.StsWebIdentityCredentialsProviderFactory";
 
-    private WebIdentityCredentialsUtils() {}
+    private WebIdentityCredentialsUtils() {
+    }
 
     /**
      * Resolves the StsWebIdentityCredentialsProviderFactory from the Sts module if on the classpath to allow

@@ -20,7 +20,8 @@
 
 @SdkProtectedApi
 public final class EventStreamAws4Signer extends BaseEventStreamAsyncAws4Signer {
-    private EventStreamAws4Signer() {}
+    private EventStreamAws4Signer() {
+    }
 
     public static EventStreamAws4Signer create() {
         return new EventStreamAws4Signer();

@@ -39,5 +39,6 @@ public final class AwsExecutionAttribute extends SdkExecutionAttribute {
      */
     public static final ExecutionAttribute<String> ENDPOINT_PREFIX = new ExecutionAttribute<>("AwsEndpointPrefix");
 
-    private AwsExecutionAttribute() {}
+    private AwsExecutionAttribute() {
+    }
 }
@@ -17,7 +17,6 @@
 
 import java.nio.ByteBuffer;
 import java.util.concurrent.CompletableFuture;
-
 import software.amazon.awssdk.annotations.SdkProtectedApi;
 import software.amazon.awssdk.core.SdkResponse;
 import software.amazon.awssdk.core.async.AsyncResponseTransformer;

@@ -204,7 +204,8 @@ protected static final class BuilderImpl implements Builder {
         private SdkHttpResponse sdkHttpResponse;
         private SdkBytes rawResponse;
 
-        private BuilderImpl() {}
+        private BuilderImpl() {
+        }
 
         private BuilderImpl(AwsErrorDetails awsErrorDetails) {
             this.errorMessage = awsErrorDetails.errorMessage();

@@ -26,7 +26,8 @@
  */
 @SdkInternalApi
 public final class EndpointUtils {
-    private EndpointUtils() {}
+    private EndpointUtils() {
+    }
 
     /**
      * Generate an endpoint from the provided endpoint protocol, url prefix, and region.

@@ -27,7 +27,8 @@
  */
 @SdkInternalApi
 public final class AwsClientOptionValidation extends SdkClientOptionValidation {
-    private AwsClientOptionValidation() {}
+    private AwsClientOptionValidation() {
+    }
 
     public static void validateAsyncClientOptions(SdkClientConfiguration c) {
         validateClientOptions(c);

@@ -79,7 +79,8 @@ public int hashCode() {
     protected abstract static class DefaultBuilder<B extends DefaultBuilder<B>> implements Builder {
         private Duration signatureDuration;
 
-        protected DefaultBuilder() {}
+        protected DefaultBuilder() {
+        }
 
         protected DefaultBuilder(PresignRequest request) {
             this.signatureDuration = request.signatureDuration;

@@ -184,7 +184,8 @@ protected abstract static class DefaultBuilder<B extends DefaultBuilder<B>> impl
         private SdkBytes signedPayload;
         private SdkHttpRequest httpRequest;
 
-        protected DefaultBuilder() {}
+        protected DefaultBuilder() {
+        }
 
         protected DefaultBuilder(PresignedRequest request) {
             this.expiration = request.expiration;

@@ -150,7 +150,8 @@ private static final class BuilderImpl implements Builder {
         /**
          * @see #builder()
          */
-        private BuilderImpl() {}
+        private BuilderImpl() {
+        }
 
         @Override
         public Builder name(String name) {

@@ -213,7 +213,8 @@ private static final class BuilderImpl implements Builder {
         private Path contentLocation;
         private Type type;
 
-        private BuilderImpl() {}
+        private BuilderImpl() {
+        }
 
         @Override
         public Builder content(InputStream contentStream) {

@@ -99,5 +99,6 @@ public final class ProfileProperty {
      */
     public static final String RETRY_MODE = "retry_mode";
 
-    private ProfileProperty() {}
+    private ProfileProperty() {
+    }
 }
@@ -44,7 +44,8 @@ public final class ProfileFileReader {
 
     private static final Pattern VALID_IDENTIFIER = Pattern.compile("^[A-Za-z0-9_\\-/.%@]*$");
 
-    private ProfileFileReader() {}
+    private ProfileFileReader() {
+    }
 
     /**
      * Parses the input and returns a mutable map from profile name to a map of properties. This will not close the provided

@@ -20,7 +20,6 @@
 
 import java.io.ByteArrayInputStream;
 import java.nio.charset.StandardCharsets;
-
 import software.amazon.awssdk.annotations.SdkProtectedApi;
 import software.amazon.awssdk.core.interceptor.Context;
 import software.amazon.awssdk.core.interceptor.ExecutionAttributes;

@@ -21,7 +21,6 @@
 import java.util.List;
 import java.util.Optional;
 import java.util.function.Supplier;
-
 import software.amazon.awssdk.annotations.SdkInternalApi;
 import software.amazon.awssdk.awscore.AwsExecutionAttribute;
 import software.amazon.awssdk.awscore.exception.AwsErrorDetails;

@@ -17,7 +17,6 @@
 
 import java.util.Optional;
 import java.util.function.Supplier;
-
 import software.amazon.awssdk.annotations.SdkProtectedApi;
 import software.amazon.awssdk.awscore.AwsResponse;
 import software.amazon.awssdk.core.Response;

@@ -22,7 +22,6 @@
 import java.util.Optional;
 import java.util.function.Function;
 import java.util.function.Supplier;
-
 import software.amazon.awssdk.annotations.SdkProtectedApi;
 import software.amazon.awssdk.awscore.AwsResponse;
 import software.amazon.awssdk.awscore.exception.AwsServiceException;

@@ -19,7 +19,6 @@
 import java.util.Optional;
 import java.util.function.Function;
 import java.util.function.Supplier;
-
 import software.amazon.awssdk.annotations.SdkInternalApi;
 import software.amazon.awssdk.awscore.exception.AwsServiceException;
 import software.amazon.awssdk.core.SdkPojo;

@@ -17,10 +17,8 @@
 
 import java.util.Optional;
 import java.util.function.Function;
-
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-
 import software.amazon.awssdk.annotations.SdkInternalApi;
 import software.amazon.awssdk.core.Response;
 import software.amazon.awssdk.core.SdkPojo;

@@ -20,7 +20,6 @@
 import java.util.HashMap;
 import java.util.Map;
 import java.util.function.Function;
-
 import software.amazon.awssdk.annotations.SdkInternalApi;
 import software.amazon.awssdk.awscore.AwsResponse;
 import software.amazon.awssdk.awscore.AwsResponseMetadata;

@@ -17,7 +17,6 @@
 
 import java.util.Optional;
 import java.util.function.Function;
-
 import software.amazon.awssdk.annotations.SdkInternalApi;
 import software.amazon.awssdk.protocols.query.unmarshall.XmlElement;
 

@@ -22,7 +22,6 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-
 import software.amazon.awssdk.annotations.SdkInternalApi;
 import software.amazon.awssdk.core.SdkField;
 import software.amazon.awssdk.core.SdkPojo;

@@ -16,7 +16,6 @@
 package software.amazon.awssdk.protocols.xml.internal.unmarshall;
 
 import java.util.Optional;
-
 import software.amazon.awssdk.annotations.SdkInternalApi;
 import software.amazon.awssdk.core.SdkPojo;
 import software.amazon.awssdk.core.protocol.MarshallLocation;

@@ -30,7 +30,8 @@ final class MetadataLoader {
 
     private static final PartitionMetadataProvider PARTITION_METADATA_PROVIDER = new GeneratedPartitionMetadataProvider();
 
-    private MetadataLoader() {}
+    private MetadataLoader() {
+    }
 
     static PartitionMetadata partitionMetadata(Region region) {
         return PARTITION_METADATA_PROVIDER.partitionMetadata(region);