Skip to content

Conversation

JeffAshton
Copy link
Contributor

@JeffAshton JeffAshton commented Jul 12, 2020

Description

Enabling the CA2007 reliability warning (Do not directly await a Task) as an Error.

Motivation and Context

Prevent future ConfigureAwait's from being missed.

Libraries like this should always use .ConfigureAwait( false ) to prevent deadlocks. #1636

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@danielmarbach
Copy link
Contributor

@normj I think this is a great addition to the SDK

@danielmarbach
Copy link
Contributor

Any reason why this hasn't been merged yet?

@boblodgett
Copy link
Contributor

These changes have been manually merged. Thank you @danielmarbach!

@boblodgett boblodgett closed this Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants