Skip to content

Enabling the CA2007 reliability warning: Do not directly await a Task #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Enabling the CA2007 reliability warning: Do not directly await a Task #1659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/AWSDotNetSDK.ruleset
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
<Rule Id="CA1819" Action="Error" />
<Rule Id="CA1822" Action="Error" />
<Rule Id="CA1823" Action="None" />
<Rule Id="CA2007" Action="None" />
<Rule Id="CA2007" Action="Error" />
<Rule Id="CA2119" Action="Error" />
<Rule Id="CA2211" Action="Error" />
<Rule Id="CA2214" Action="Error" />
Expand Down
2 changes: 1 addition & 1 deletion sdk/AWSDotNetSDKForBuild.ruleset
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
<Rule Id="CA1819" Action="Error" />
<Rule Id="CA1822" Action="Error" />
<Rule Id="CA1823" Action="None" />
<Rule Id="CA2007" Action="None" />
<Rule Id="CA2007" Action="Error" />
<Rule Id="CA2119" Action="Error" />
<Rule Id="CA2211" Action="Error" />
<Rule Id="CA2214" Action="Error" />
Expand Down
2 changes: 1 addition & 1 deletion sdk/src/Services/S3/Custom/Util/_async/BucketRegionDetector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public static partial class BucketRegionDetector
internal static async Task<string> DetectMismatchWithHeadBucketFallbackAsync(AmazonS3Uri requestedBucketUri, AmazonServiceException serviceException, ImmutableCredentials credentials)
{
return GetCorrectRegion(requestedBucketUri, serviceException) ??
CheckRegionAndUpdateCache(requestedBucketUri, await GetBucketRegionNoPipelineAsync(requestedBucketUri.Bucket, credentials));
CheckRegionAndUpdateCache(requestedBucketUri, await GetBucketRegionNoPipelineAsync(requestedBucketUri.Bucket, credentials).ConfigureAwait(false));
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion sdk/src/Services/WorkDocs/Custom/_async/ContentManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ public async Task<UploadDocumentStreamResponse> UploadDocumentStreamAsync(Upload
content.RemoveHttpContentHeader("Content-Type");
content.AddHttpContentHeader("Content-Type", uploadDocumentStreamRequest.ContentType);

await httpClient.PutRequestUriAsync(uploadUrl, content, requestHeaders);
await httpClient.PutRequestUriAsync(uploadUrl, content, requestHeaders).ConfigureAwait(false);
var task = CompleteUpload(documentId, versionId);

UploadDocumentStreamResponse uploadDocumentStreamResponse = new UploadDocumentStreamResponse(uploadDocumentStreamRequest)
Expand Down