Skip to content

Conversation

JadenSimon
Copy link
Contributor

@JadenSimon JadenSimon commented Sep 28, 2022

Problem

No standalone script to generate service client type definitions

Solution

Split the command out into generateClients and remove it from postinstall

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@JadenSimon JadenSimon requested a review from a team as a code owner September 28, 2022 22:53
Copy link
Contributor

@jpinkney-aws jpinkney-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now that generating service clients is out of the postinstall, is there a chance that we/any contributor might forget to do it? Would that break the build and have people wondering what they might have to do to correct the build?

@JadenSimon
Copy link
Contributor Author

So now that generating service clients is out of the postinstall, is there a chance that we/any contributor might forget to do it? Would that break the build and have people wondering what they might have to do to correct the build?

It's still ran before any build so no. Code generation for building the package should really not be in postinstall.

@justinmk3 justinmk3 merged commit 8c2c6a0 into master Sep 30, 2022
@justinmk3 justinmk3 deleted the sijaden/generateSdk branch September 30, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants