fix: use device code auth when running in a web browser #5062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkomonen-amazon
approved these changes
May 28, 2024
Problem: - Logging into the toolkit using the authorization grant flow in code server/openshift dev spaces does not fully work. This is because the authorization grant page is being served from the backend compute and the browser is unable to access it Solution: - Disable the authorization grant flow when you are running in a web browser Extra notes: - It was done this way rather than relying on vscode.env.remoteName because remoteName can change with different remote instances. e.g. openshift dev spaces assigns a remoteName that is unique to each workspace - VSCode itself disables remote extension hosts and web workers for this flow: https://github.com/microsoft/vscode/blob/main/extensions/github-authentication/src/flows.ts#L210
jpinkney-aws
force-pushed
the
jpinkney-aws/auth-grant-web
branch
from
db84f39
to
39d5371
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Extra notes:
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.