Skip to content

Conversation

awschristou
Copy link
Contributor

Description

Bumping the max SAM CLI version to 0.50 (exclusive)

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@awschristou awschristou requested a review from a team as a code owner January 3, 2020 00:43
@codecov-io
Copy link

codecov-io commented Jan 3, 2020

Codecov Report

Merging #880 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #880   +/-   ##
=======================================
  Coverage   56.66%   56.66%           
=======================================
  Files         157      157           
  Lines        5651     5651           
  Branches      762      762           
=======================================
  Hits         3202     3202           
  Misses       2449     2449
Impacted Files Coverage Δ
src/shared/sam/cli/samCliValidator.ts 78.46% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a8786...3085b10. Read the comment docs.

@awschristou
Copy link
Contributor Author

Proceeding with this PR's merge. The integration tests are failing on a non-related SAM dependency, and those tests will not pass until a new version of the SAM CLI is released.

@awschristou awschristou merged commit 33697f8 into master Jan 3, 2020
@awschristou awschristou deleted the awschristou/sam-five-oh branch January 3, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants