Skip to content

Commit df48c82

Browse files
authored
Update github clone link in readme and clean up old comments (#85)
1 parent f5ff67b commit df48c82

File tree

3 files changed

+1
-22
lines changed

3 files changed

+1
-22
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ SageMaker HyperPod CLI currently supports start training job with:
6060
1. Clone and install the sagemaker-hyperpod-cli package.
6161
6262
```
63-
git clone git@github.com:aws/sagemaker-hyperpod-cli.git
63+
git clone https://github.com/aws/sagemaker-hyperpod-cli.git
6464
cd sagemaker-hyperpod-cli
6565
pip install .
6666
```

helm_chart/HyperPodHelmChart/charts/neuron-device-plugin/templates/k8s-neuron-device-plugin.yaml

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -38,22 +38,6 @@ spec:
3838
nodeAffinity:
3939
requiredDuringSchedulingIgnoredDuringExecution:
4040
nodeSelectorTerms:
41-
# Uncomment following matchExpressions if using k8s 1.16 or lower
42-
#- matchExpressions:
43-
# - key: "beta.kubernetes.io/instance-type"
44-
# operator: In
45-
# values:
46-
# - inf1.xlarge
47-
# - inf1.2xlarge
48-
# - inf1.6xlarge
49-
# - inf1.24xlarge
50-
# - inf2.xlarge
51-
# - inf2.8xlarge
52-
# - inf2.24xlarge
53-
# - inf2.48xlarge
54-
# - trn1.2xlarge
55-
# - trn1.32xlarge
56-
# - trn1n.32xlarge
5741
- matchExpressions:
5842
- key: "node.kubernetes.io/instance-type"
5943
operator: In

helm_chart/HyperPodHelmChart/values.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -172,11 +172,6 @@ nvidia-device-plugin:
172172
- ml.p5.48xlarge
173173
- ml.p5e.48xlarge
174174
- ml.p5en.48xlarge
175-
# nvidia plugin needs at least one node selector. Below label exists for all hyperpod nodes
176-
- key: kubernetes.io/os
177-
operator: In
178-
values:
179-
- "linux"
180175
tolerations:
181176
- key: nvidia.com/gpu
182177
operator: Exists

0 commit comments

Comments
 (0)