Change: disable debugger by default #3528

yl-to · 2022-12-12T06:04:52Z

Issue #, if available:

Description of changes:
Disable debugger by removing automatic config generation.
Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Co-authored-by: Mufaddal Rohawala <muffi179@gmail.com>

Co-authored-by: Basil Beirouti <BasilBeirouti@gmail.com> Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>

…aws#3438) Co-authored-by: Keshav Chandak <chakesh@amazon.com>

Co-authored-by: Navin Soni <navinns@amazon.com>

* Add DXB region * Remove change from neuron * Adding DXB to TF 2.1.0 and 2.1.1

Co-authored-by: Brock Wade <bwayde@amazon.com> Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>

…ws#3492)

…timator starting 1.12 (aws#3500) Co-authored-by: Ubuntu <ubuntu@ip-172-31-52-39.us-west-2.compute.internal>

Co-authored-by: Malav Shastri <malavhs@amazon.com>

Co-authored-by: Brock Wade <bwayde@amazon.com> Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>

… DLC (aws#3515)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

sagemaker-bot · 2022-12-12T06:43:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e19124d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-12-12T06:44:53Z

Codecov Report

Merging #3528 (18b227c) into master (93a8466) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3528      +/-   ##
==========================================
+ Coverage   89.57%   89.58%   +0.01%     
==========================================
  Files         960      226     -734     
  Lines       88744    21747   -66997     
==========================================
- Hits        79495    19483   -60012     
+ Misses       9249     2264    -6985

Impacted Files	Coverage Δ
src/sagemaker/estimator.py	`90.03% <100.00%> (ø)`
...ib/python3.7/site-packages/sagemaker/image_uris.py
.../lib/python3.10/site-packages/sagemaker/clarify.py
...python3.7/site-packages/sagemaker/xgboost/utils.py
...ython3.9/site-packages/sagemaker/spark/defaults.py
...ib/python3.9/site-packages/sagemaker/amazon/lda.py
...3.9/site-packages/sagemaker/jumpstart/accessors.py
...ackages/sagemaker/amazon/factorization_machines.py
...3.8/site-packages/sagemaker/workflow/properties.py
....7/site-packages/sagemaker/experiments/__init__.py
... and 1177 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2022-12-12T06:47:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e19124d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-12T07:01:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: e19124d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-12T07:10:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: e19124d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-12T07:17:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e19124d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…aws#3530) Currently the analysis configuration schema of SageMaker Clarify API allows the content_type configuration "image/jpeg" and "image/jpg", but the service side validation only accepts the former which is the registered MIME type for JPEG (see rfc3745 and JPEG specification). The commit removes the latter from the schema to avoid confusion and enable early API validation.

Co-authored-by: Anton Repushko <repuanto@amazon.com>

…st_feature_group (aws#3534) Co-authored-by: Eric Zou <zoueric@amazon.com> Co-authored-by: Yiming Zou <imingtsou@gmail.com> Co-authored-by: Brandon Chatham <bdchatham@gmail.com> Co-authored-by: jiapinw <95885824+jiapinw@users.noreply.github.com>

* feature: Add experiment plus Run class (aws#691) * feature: Add Experiment helper classes (aws#646) * feature: Add Experiment helper classes feature: Add helper class _RunEnvironment * change: Change sleep retry to backoff retry for get TC * minor fixes in backoff retry Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add helper classes and methods for Run class (aws#660) * feature: Add helper classes and methods for Run class * Add Parent class to address comment * fix docstyle check * Add arg docstrings in _helper Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add Experiment Run class (aws#651) Co-authored-by: Dewen Qi <qidewen@amazon.com> * change: Add integ tests for Run (aws#673) Co-authored-by: Dewen Qi <qidewen@amazon.com> * Update run log metric to use MetricsManager (aws#678) * Update run.log_metric to use _MetricsManager * fix several metrics issues * Add doc strings to metrics.py Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> * change: Simplify exp plus integ test configuration (aws#694) Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: add RunName to expeirment_config (aws#696) * change: Update Run init and add Run load and _RunContext (aws#707) * change: Update Run init and add Run load Add exp name and run group name to load and address comments * Address nit comments Co-authored-by: Dewen Qi <qidewen@amazon.com> * fix: Fix run name uniqueness issue (aws#730) Co-authored-by: Dewen Qi <qidewen@amazon.com> * change: Update integ tests for Exp Plus M1 changes (aws#741) Co-authored-by: Dewen Qi <qidewen@amazon.com> * add metrics client to session object (aws#745) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * change: Add integ test for using Run in Transform Job (aws#749) Co-authored-by: Dewen Qi <qidewen@amazon.com> * Add async metrics sink (aws#739) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * use metrics client provided by session (aws#754) * fix flaky metrics test (aws#753) * change: Change Run.init and Run.load to constructor and module method respectively (aws#752) Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: Add latest metric service model (aws#757) Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> * fix: lowercase run name (aws#767) * Change: Minimize use of lower case tc name (aws#769) * change: Clean up test resources to remove model files (aws#756) * change: Clean up test resources to remove model files * fix: Change experiment enums to upper case * change: Upgrade boto3 and update test to validate mixed case name * fix: Update as per latest botocore release and backend change Co-authored-by: Dewen Qi <qidewen@amazon.com> * lowercase trial component name (aws#776) * change: Expose sagemaker experiment doc strings * fix: Fix exp name mixed case in issue Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Dana Benson <danabens@amazon.com> Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com> Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>

sagemaker-bot · 2022-12-14T18:42:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 18b227c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-14T18:46:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 18b227c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-14T18:58:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 18b227c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-14T19:08:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 18b227c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-14T20:54:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 18b227c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure · 2022-12-19T17:35:00Z

@yl-to Can you please fix the failing tests?

yl-to · 2023-01-10T21:46:27Z

closing PR, creating a new PR #3584 for doing this.

NivekNey and others added 30 commits December 2, 2022 12:48

fix: type hint of PySparkProcessor __init__ (aws#3297)

c97c467

fix: fix PySparkProcessor __init__ params type (aws#3354)

de58941

fix: Allow Py 3.7 for MMS Test Docker env (aws#3080)

41dd330

Co-authored-by: Mufaddal Rohawala <muffi179@gmail.com>

refactoring : using with statement (aws#3286)

1e23a3f

Update local_requirements.txt PyYAML version (aws#3095)

19efadf

Co-authored-by: Basil Beirouti <BasilBeirouti@gmail.com> Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>

feature: Update TF 2.9 and TF 2.10 inference DLCs (aws#3465)

76f7782

feature: Added transform with monitoring pipeline step in transformer (…

fde0738

…aws#3438) Co-authored-by: Keshav Chandak <chakesh@amazon.com>

fix: Fix bug forcing uploaded tar to be named sourcedir (aws#3412)

7f9f3b0

feature: Add Code Owners file (aws#3503)

5d59767

Co-authored-by: Navin Soni <navinns@amazon.com>

prepare release v2.119.0

0f5cf18

update development version to v2.119.1.dev0

f1f0013

feature: Add DXB region to frameworks by DLC (aws#3387)

bb4b689

* Add DXB region * Remove change from neuron * Adding DXB to TF 2.1.0 and 2.1.1

fix: support idempotency for framework and spark processors (aws#3460)

b68bcd9

Co-authored-by: Brock Wade <bwayde@amazon.com> Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>

feature: Update registries with new region account number mappings. (a…

32969da

…ws#3492)

feature: Adding support for SageMaker Training Compiler in PyTorch es…

767da0a

…timator starting 1.12 (aws#3500) Co-authored-by: Ubuntu <ubuntu@ip-172-31-52-39.us-west-2.compute.internal>

feature: Add Neo image uri config for Pytorch 1.12 (aws#3507)

d779d1b

prepare release v2.120.0

83327fb

update development version to v2.120.1.dev0

5bffb04

feature: Algorithms Region Expansion OSU/DXB (aws#3508)

b828396

Co-authored-by: Malav Shastri <malavhs@amazon.com>

fix: Add constraints file for apache-airflow (aws#3510)

357f732

fix: FrameworkProcessor S3 uploads (aws#3493)

a28d1dd

Co-authored-by: Brock Wade <bwayde@amazon.com> Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>

prepare release v2.121.0

11d2475

update development version to v2.121.1.dev0

24171b5

Fix: Differentiate SageMaker Training Compiler's PT DLCs from base PT…

d5847d5

… DLC (aws#3515)

fix: Fix failing jumpstart cache unit tests (aws#3514)

3f6ea88

fix: Pop out ModelPackageName from pipeline definition (aws#3472)

4570aa6

Co-authored-by: Dewen Qi <qidewen@amazon.com>

prepare release v2.121.1

959ea1a

update development version to v2.121.2.dev0

b2e8b66

fix: Skip Bad Transform Test (aws#3521)

355975d

fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)

fadc817

yl-to requested review from knikure and removed request for a team December 12, 2022 06:04

ci and others added 6 commits December 12, 2022 18:18

prepare release v2.121.2

ec8da98

update development version to v2.121.3.dev0

0352122

feature: Add OSU region to frameworks for DLC (aws#3532)

d6c0214

fix: unpin packaging version (aws#3533)

4389847

fix: the Hyperband support fix for the HPO (aws#3516)

a3efddf

Co-authored-by: Anton Repushko <repuanto@amazon.com>

knikure self-assigned this Dec 13, 2022

mizanfiu and others added 5 commits December 13, 2022 16:06

prepare release v2.122.0

fb3880f

update development version to v2.122.1.dev0

a584ea5

change: disable debugger by default

18b227c

knikure force-pushed the default_disable_smd branch from e19124d to 18b227c Compare December 14, 2022 18:02

mufaddal-rohawala force-pushed the master branch from bae3b8b to d000bdc Compare December 20, 2022 00:31

yl-to closed this Jan 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Change: disable debugger by default #3528

Change: disable debugger by default #3528

Uh oh!

yl-to commented Dec 12, 2022

Uh oh!

sagemaker-bot commented Dec 12, 2022

Uh oh!

codecov-commenter commented Dec 12, 2022 •

edited

Loading

Uh oh!

sagemaker-bot commented Dec 12, 2022

Uh oh!

sagemaker-bot commented Dec 12, 2022

Uh oh!

sagemaker-bot commented Dec 12, 2022

Uh oh!

sagemaker-bot commented Dec 12, 2022

Uh oh!

sagemaker-bot commented Dec 14, 2022

Uh oh!

sagemaker-bot commented Dec 14, 2022

Uh oh!

sagemaker-bot commented Dec 14, 2022

Uh oh!

sagemaker-bot commented Dec 14, 2022

Uh oh!

sagemaker-bot commented Dec 14, 2022

Uh oh!

knikure commented Dec 19, 2022

Uh oh!

yl-to commented Jan 10, 2023 •

edited

Loading

Uh oh!

Uh oh!

Change: disable debugger by default #3528

Change: disable debugger by default #3528

Uh oh!

Conversation

yl-to commented Dec 12, 2022

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Dec 12, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Dec 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Dec 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 14, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 14, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 14, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 14, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 14, 2022

AWS CodeBuild CI Report

Uh oh!

knikure commented Dec 19, 2022

Uh oh!

yl-to commented Jan 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Dec 12, 2022 •

edited

Loading

yl-to commented Jan 10, 2023 •

edited

Loading