Infosys #358
Closed
Infosys #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the VPC endpoint policy example to show a correct version of how Principal should be used per the docs[1]. The previous example would return an error if you attempted to use a Principal in that manner. [1] https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_elements_principal.html#principal-accounts
corrected line number 110. SourceARN should have SNS arn and not that of lambda function.
Update with-sns-example.md
Fix to VPC endpoint policy example
I spent many hours tracking down why my Python modules were not importable. When I renamed the package folder in the console from A to B and back from B to A the issue resolved and this led me to the discovery that files and directories must be globally readable for the Lambda to run despite everything looking perfectly OK in the console. I think it is important to fix this flaw or let people know about it.
* Fix IAM policy formatting to add required Resource * Fix condition StringEquals syntax
Update python-package.md
In the Golang Lambda Handler for API Gateway, the RequestContext has no field as RequestId, so based on https://github.com/aws/aws-lambda-go/blob/v1.22.0/events/apigw.go#L32, field needs to be changed to 'RequestID'
Fix configuration-codesigning.md
'RequestId' to 'RequestID' in Golang Example
There's inconsistency in the example of how to add RIE to the image. Dockerfile `ADD` and `RUN` commands work with `/usr/bin/aws-lambda-rie`. But `entry.sh` script refers to `/usr/local/bin/aws-lambda-rie` that causes issues. Alternatively, Dockerfile `ADD` and `RUN` commands can be updated to work with `/usr/local/bin/aws-lambda-rie`.
Fix broken link
Fix typo in adding RIE to the image example
…ws.com This code snippet references iotevents.amazonaws.com but should reference iot.amazonaws.com. This can be verified in the output JSON below the code that shows the service principal as “iot.amazonaws.com”.
…gine-configuration Fixed reference to iotevents.amazonaws.com that should be iot.amazonaws.com
…into main Pull github.
fix JSON syntax in example resource-based policy
Update python formatting
Improve Go code example
Renamed the steps needed to upload a .zip file to reflect changes in the Lambda's UI
Rephrasing to reflect new Lambda UI
Typo in the subcommand
Update typos in configuration-tags.md
Typo in functions-states.md
Update typos in configuration-tags.md
Remove instructions for Node.js 10.x base image
Update info about json serialization
Update to the version of log4j2 which isn't effected by CVE-2021-44228
Updating log4 dependencies.
Updating to newest version.
Missed some outdated log4 versions.
Updating aws-lambda-java-log4j2 to 1.5.0
Updating aws-sdk versions.
Updating log4j versions.
Syncing with dev guide on docs.aws.amazon.com.
|
Thanks for the PR. Please create a new one with just the change that you want to make to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.