Skip to content

Move buildspecs inline with project #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Conversation

markkuhn
Copy link
Contributor

@markkuhn markkuhn commented Aug 22, 2022

Description of changes:

Moving buildspecs inline with project to comply with CodeBuild best practices.

+ Style improvements

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@markkuhn markkuhn added the chore Tasks such as style improvements or refactoring label Aug 22, 2022
@markkuhn markkuhn changed the title move buildspecs inline Move buildspecs inline with project Aug 22, 2022
Copy link
Member

@gordonpn gordonpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀🐍

@markkuhn markkuhn requested a review from Stephen-Bao August 23, 2022 16:39
@markkuhn markkuhn merged commit 7e79b4c into awslabs:master Aug 23, 2022
@markkuhn markkuhn self-assigned this Aug 24, 2022
@hussam789
Copy link

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Impact
Possible issue
Fix function call syntax

The fake.word is being used as a value without being called. This will pass the
function reference instead of generating a random word. You should call the
function by adding parentheses.

tests/logger/test_metrics_context.py [346]

-expected_dimensions = [{fake.word(): fake.word}]
+expected_dimensions = [{fake.word(): fake.word()}]
  • Apply this suggestion
Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies that fake.word should be invoked as fake.word() to generate a value, preventing an inadvertent passing of the function reference. It addresses a valid minor bug in the test code.

Medium
  • More

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Tasks such as style improvements or refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants