Fix clang-tidy benign warnings #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabled the parameters easily swappable warning because there isn't an easy way to fix that in C++ without introducing another library or a lot of boilerplate code. The code is small enough to not warrant introducing solutions to avoid that warnings.
marcomagdy
force-pushed
the
fix-linter
branch
from
b5b3736
to
5c0acab
Compare
added 2 commits
February 14, 2023 11:54
Explicitly skip the files rather than mark them with clang-format on/off because marking the files still takes many cpu cycles. Skipping the files in bash is instant.
|
@bmoffatt this should fix CI |
|
Nice! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled the parameters easily swappable warning because there isn't an easy way to fix that in C++ without introducing another library or a lot of boilerplate code. The code is small enough to not warrant introducing solutions to avoid that warnings.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.