SaaS Boost API access via OAuth client credentials grant #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runtime. Add the API Gateway invoke URL to the app client secret details so a client doesn't have to make another call to some other service to figure it out.
1 task
PoeppingT
reviewed
Jan 7, 2023
| @@ -846,6 +846,7 @@ Resources: | |||
| CustomDomainName: !If [HasSystemIdPCustomDomain, !Ref SystemIdentityProviderDomain, ''] | |||
| CustomDomainHostedZone: !If [HasSystemIdPCustomDomain, !Ref SystemIdentityProviderHostedZone, ''] | |||
| CustomDomainCertificate: !If [HasSystemIdPCustomDomain, !Ref SystemIdentityProviderCertificate, ''] | |||
| ApiGatewayUrl: !Sub https://${core.Outputs.SaaSBoostPublicApi}.execute-api.${AWS::Region}.${AWS::URLSuffix}/${PublicApiStage} #!GetAtt publicapi.Outputs.PublicApiGatewayEndpoint | |||
There was a problem hiding this comment.
Why can't we just use !GetAtt here?
There was a problem hiding this comment.
Because it would make a circular dependency with the saas-boost-public-api.yaml stack
PoeppingT
reviewed
Jan 10, 2023
| Properties: | ||
| LogGroupName: !Sub /aws/lambda/sb-${Environment}-cognito-client-details | ||
| RetentionInDays: 30 | ||
| CognitoAppClientDetailsExecRole: |
There was a problem hiding this comment.
We need Condition: UseCognito for this, since we refer to UserPool in the cognito-idp Allow.
PoeppingT
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we upgraded the System User Service to use OAuth
authorization_codegrant for access to the SaaS Boost API instead of Amazon Cognito native authorization, we removed the lesser-known private API/tokenendpoint that returned anIdentity Tokenfor the SaaS Boost admin user.This PR generates an application client with a secret to be used for
client_credentialsgrant against the SaaS Boost API. It will return anAccess Tokenwith the equivalent permissions as the SaaS Boost admin user. This token can be used as a bearer token for any of the public SaaS Boost API resources.The client's details are stored in Secrets Manager at
/saas-boost/${ENVIRONMENT}/API_APP_CLIENT. Any client code wanting to perform computer-to-computer invocation of the SaaS Boost API will need to be given explicit allow permissions via IAM to access that secret.DO NOT use this secret in a public client such as a JavaScript web app or a mobile application. This should only be used in backend server side code that is authorized.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license