Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto suggest completions (fish-style) to more easily execute popular/recent commands #28

Closed
donnemartin opened this issue Dec 7, 2015 · 1 comment

Comments

@donnemartin
Copy link
Collaborator

Suggest

Imgur

Complete Suggestion

You can use the right arrow key to complete a suggestion.

Imgur

TODO

This could also be a toolbar option.

For suggestions to be more effective I think we'd need to use a FileHistory instead of an InMemoryHistory which is persisted between sessions. Another option is to hook up to something more general like .bash_history.

We might need special handling for the .edit command if we switch to FileHistory as that could load a ton of history--maybe on aws-shell startup we can tag where we are in the history and only load from that checkpoint.

This was referenced Dec 7, 2015
donnemartin added a commit that referenced this issue Dec 13, 2015
0.52 supports auto suggestions #28.  This same upgrade was done on SAWS, see pull request from jonathanslenders (author of prompt-toolkit): https://github.com/donnemartin/saws/pull/30/files.
@donnemartin donnemartin changed the title Add fish-style completions to more easily execute popular/recent commands Add auto suggest completions (fish-style) to more easily execute popular/recent commands Dec 13, 2015
donnemartin added a commit that referenced this issue Dec 13, 2015
* feature/28-auto-suggestions:
  Implement #28: Add auto suggest completions.
  Update to prompt-toolkit 0.52.
donnemartin added a commit that referenced this issue Dec 15, 2015
* feature/26-toolbar:
  Fix merge conflict with package_data.
  Set separators above and below the help pane.
  Refactor getting and setting of config options code.
  Add styles to menu and toolbar.
  Add toolbar and hotkey support.
  Hook up config options.
  Add config and unit test.
  Add build_config_file_path method to refactor config file path code.
  Implement #28: Add auto suggest completions.
  Update to prompt-toolkit 0.52.
@jamesls
Copy link
Member

jamesls commented Dec 17, 2015

Closing, this was merged via 02ea3b5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants