Add support for role assumption (delegated access). #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support in ddbsh to properly handle AWS_DEFAULT_PROFILE environment variable. By default, the C++ SDK doesn't appear to handle this as described in the issue (#12). This appears to be related to AWS SDK issue (aws/aws-sdk-cpp#150). Sample code provided in that issue provided a starting point for the change, but it required some fixing. Added tests and updated the README.md. The changes to README.md include changes to the build steps, and how to use delegated access (role assumption).
|
The version number has been bumped to 0.7.0. |
AWS_REGION deprecates AWS_DEFAULT_REGION. AWS_PROFILE deprecates AWS_DEFAULT_PROFILE.
|
Updated to accept the "profile" prefix in the config profile section. AWS_PROFILE deprecates AWS_DEFAULT_PROFILE |
|
Updated README.md with information about malformed config profile section(s). |
|
looks good. Thanks @damshenas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the [issue][https://github.com//issues/12].
Description of changes:
When a user specifies the environment variable AWS_DEFAULT_PROFILE and uses that to specify role assumption, the SDK doesn't (by default) honor it. This was reported in the issue above. The reason for this is in the AWS CPP SDK as described [here][https://github.com/aws/aws-sdk-cpp/issues/150].
Changes proposed here are derived from the changes proposed [here][https://github.com/aws/aws-sdk-cpp/issues/150#issuecomment-416646025] but required changes to make them work.
Substantively, this pull requests includes the following changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.