Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Widgets] Support Cloudscape theming options #2668

Closed
tracy-french opened this issue Mar 8, 2024 · 0 comments
Closed

[Widgets] Support Cloudscape theming options #2668

tracy-french opened this issue Mar 8, 2024 · 0 comments
Labels
Assigned to HM Work that is being assisted on by HM Current sprint enhancement New feature or request

Comments

@tracy-french
Copy link
Contributor

tracy-french commented Mar 8, 2024

This issue is dependent on #2667.

Note: This issue will be updated with additional theming options as we understand which we need.

Extend useTheme to support additional Cloudscape theming options. Please update the type SupportedCloudscapeDesignTokens to the following:

type SupportedCloudscapeDesignTokens = Pick<
  Theme['tokens'],
  | 'borderRadiusButton'
  | 'borderRadiusContainer'
  | 'borderRadiusControlCircularFocusRing'
  | 'borderRadiusControlDefaultFocusRing'
  | 'borderRadiusDropdown'
  | 'borderRadiusInput'
  | 'borderRadiusItem'
  | 'borderRadiusToken'
  | 'colorBackgroundButtonNormalActive'
  | 'colorBackgroundButtonNormalDefault'
  | 'colorBackgroundButtonNormalDisabled'
  | 'colorBackgroundButtonNormalHover'
  | 'colorBackgroundButtonPrimaryActive'
  | 'colorBackgroundButtonPrimaryDefault'
  | 'colorBackgroundButtonPrimaryDisabled'
  | 'colorBackgroundButtonPrimaryHover'
  | 'colorBackgroundControlChecked'
  | 'colorBackgroundControlDefault'
  | 'colorBackgroundControlDisabled'
  | 'colorBackgroundDropdownItemDefault'
  | 'colorBackgroundDropdownItemFilterMatch'
  | 'colorBackgroundDropdownItemHover'
  | 'colorBackgroundInputDefault'
  | 'colorBackgroundInputDisabled'
  | 'colorBackgroundItemSelected'
  | 'colorBorderButtonNormalActive'
  | 'colorBorderButtonNormalDefault'
  | 'colorBorderButtonNormalDisabled'
  | 'colorBorderButtonNormalHover'
  | 'colorBorderButtonPrimaryDisabled'
  | 'colorBorderDropdownItemFocused'
  | 'colorBorderDropdownItemHover'
  | 'colorBorderInputDefault'
  | 'colorBorderInputFocused'
  | 'colorBorderItemFocused'
  | 'colorBorderItemSelected'
  | 'colorForegroundControlDefault'
  | 'colorForegroundControlDisabled'
  | 'colorTextAccent'
  | 'colorTextBodyDefault'
  | 'colorTextBodySecondary'
  | 'colorTextBreadcrumbCurrent'
  | 'colorTextBreadcrumbIcon'
  | 'colorTextButtonNormalActive'
  | 'colorTextButtonNormalDefault'
  | 'colorTextButtonNormalHover'
  | 'colorTextButtonPrimaryActive'
  | 'colorTextButtonPrimaryDefault'
  | 'colorTextButtonPrimaryHover'
  | 'colorTextCounter'
  | 'colorTextDropdownItemFilterMatch'
  | 'colorTextDropdownItemHighlighted'
  | 'colorTextEmpty'
  | 'colorTextFormDefault'
  | 'colorTextFormSecondary'
  | 'colorTextHeadingDefault'
  | 'colorTextHeadingSecondary'
  | 'colorTextInputDisabled'
  | 'colorTextInputPlaceholder'
  | 'colorTextLinkDefault'
  | 'colorTextLinkHover'
  | 'fontFamilyBase'

As part of this work, ensure setting the theming option with useTheme updates the styles to all appropriate elements for all react-components and the dashboard resource explorer. If there are custom components and it makes sense for them to be changed with the theming option, please either replace the component elements with a Cloudscape component or use the Cloudscape design tokens to ensure the styles update correctly.

Use https://cloudscape.design/foundation/visual-foundation/design-tokens/ to understand the tokens and what they correspond to.

Please complete the work in increments, instead of doing all of the changes over time. For example, the button items, or even just the button color items, could be grouped together in a single change. This list will continue to grow until we have all of the necessary theming options.

@tracy-french tracy-french added the enhancement New feature or request label Mar 8, 2024
@diehbria diehbria added Assigned to HM Work that is being assisted on by HM Current sprint labels Mar 8, 2024
Chandru-HM pushed a commit to Chandru-HM/iot-app-kit that referenced this issue Mar 21, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Mar 21, 2024
Chandru-HM pushed a commit to Chandru-HM/iot-app-kit that referenced this issue Mar 21, 2024
Kausar-HM added a commit to Kausar-HM/iot-app-kit that referenced this issue Apr 15, 2024
Chandru-HM pushed a commit to Chandru-HM/iot-app-kit that referenced this issue Apr 17, 2024
@diehbria diehbria closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assigned to HM Work that is being assisted on by HM Current sprint enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants