-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Function role tag propagation #1194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update IAMRole resource to accept tags property Update _construct_role method on SamFunction resource to pass tags to IAMRole
Update translator tests outputs to expect "tags" on generated iam roles
Documentation update to reflect changes
Codecov Report
@@ Coverage Diff @@
## develop #1194 +/- ##
===========================================
+ Coverage 94.33% 94.33% +<.01%
===========================================
Files 72 72
Lines 3725 3726 +1
Branches 733 733
===========================================
+ Hits 3514 3515 +1
Misses 107 107
Partials 104 104
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cakepietoast thanks for contributing this feature!
Could you please add a unit test case by adding some tags on the AWS::Serverless::Function resource?
Otherwise this PR looks good to me
There's already a test case in TestTranslatorEndToEnd basic_functions_with_tags that tests this functionality. Is there something more specific you'd like me to add? |
|
@cakepietoast That should be enough. I was looking for a SAM transform template output where user-defined tags get added to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thank you for making this change!
Issue #, if available: #1160
Description of changes: Enable propagation of tags from Serverless::Function resources to the IAM Roles generated. This includes the default tag (lambda:createdBy: SAM). Updated the expected output json files so the unit tests pass with tags now being automatically added to iam roles.
Description of how you validated changes: Followed "verifying transforms" guidance in the development guide with some basic templates. Ran unit tests with updated expected output json files.
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.