Remove six dependency #30
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So, six turned out to be a bad choice. It was originally brought in to add support for python 3. That transition was abandoned, as the differences between python2 and python3 unicode handling are too different to do this simply. However, I thought leaving six in would be harmless, as eventually I'd like to support python3, if the demand presents itself. This turned out to be a bad idea because six has at least two nasty dependencies - TKinter and winreg/_winreg. The former was fixed by installing the distrubtion package python-tk. This was frustrating, because when I tested six on machines that *happened* to have python-tk, I didn't realize this dependency existed. I gave up after trying to solve the winreg dependency. It's bad enough to install a gui library for a webapp running on a server, but an OS dependency (winreg adds MS windows registry manipulation to python) is even worse. Maybe I'm doing something wrong here, but for now, six has to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, six turned out to be a bad choice. It was originally brought in to
add support for python 3. That transition was abandoned, as the
differences between python2 and python3 unicode handling are too
different to do this simply. However, I thought leaving six in would be
harmless, as eventually I'd like to support python3, if the demand
presents itself.
This turned out to be a bad idea because six has at least two nasty
dependencies - TKinter and winreg/_winreg. The former was fixed by
installing the distrubtion package python-tk. This was frustrating,
because when I tested six on machines that happened to have python-tk,
I didn't realize this dependency existed. I gave up after trying to
solve the winreg dependency. It's bad enough to install a gui library
for a webapp running on a server, but an OS dependency (winreg adds
MS windows registry manipulation to python) is even worse.
Maybe I'm doing something wrong here, but for now, six has to go.