Topic/related field names #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 4, 2014 16:19
At the cost of transparency.
Walking relationships is supported, via qs.values('model__field'), but the field names were not being included in the column header. This is because the name_map was being build from fields in queryset.model._meta.fields (which was done so that verbose_name was accessible), which does not have a concept of relations. This correct first builds from the field names of the queryset, and then overwrites with the verbose names from the model.
There was a problem hiding this comment.
This looks like it maps fields to themselves...
There was a problem hiding this comment.
it does. field_names is a list, name_map is a key mapping field_names to themselves. Then, we overwrite some of these values with verbose_names.
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.