Skip to content

Conversation

maryokhin
Copy link
Contributor

No description provided.

python:
- "2.6"
- "2.7"
- 2.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update the exclude configuration block below to remove the quotes around "2.6" to get the Travis CI builds to pass.

@maurizi
Copy link
Contributor

maurizi commented May 11, 2016

@maryokhin Thanks for the PR!

Python 3 support has been desired by a number of folks for a while now, so I think we'll be happy to merge this if the Travis CI builds pass.

@coveralls
Copy link

coveralls commented May 11, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling b26da0a on Villoid:feature/python-3 into a5f7398 on azavea:master.

@coveralls
Copy link

coveralls commented May 11, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 2cb7c25 on Villoid:feature/python-3 into a5f7398 on azavea:master.

@maryokhin
Copy link
Contributor Author

maryokhin commented May 11, 2016

Yep, no problem @maurizi. Quick question though, Python 3.5 is failing of Django 1.7 because of this bug. Should I upgrade the test matrix to test on Django 1.7.5+ or just exclude the Django 1.7 + Python 3.5 row from the test matrix?

@maurizi
Copy link
Contributor

maurizi commented May 11, 2016

Upgrading Django seems like the better option.

@coveralls
Copy link

coveralls commented May 11, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 41e1e8a on Villoid:feature/python-3 into a5f7398 on azavea:master.

@maryokhin maryokhin force-pushed the feature/python-3 branch 5 times, most recently from 3507a81 to 9641e2c Compare May 11, 2016 22:56
@coveralls
Copy link

coveralls commented May 11, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 3507a81 on Villoid:feature/python-3 into a5f7398 on azavea:master.

@coveralls
Copy link

coveralls commented May 11, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 9641e2c on Villoid:feature/python-3 into a5f7398 on azavea:master.

@jwalgran
Copy link
Member

According to this chart, Django 1.7 is not supported under Python 3.5.

https://docs.djangoproject.com/en/1.7/faq/install/#what-python-version-can-i-use-with-django

We should exclude it from our matrix

matrix:
  exclude:
    - python: 3.5
      env: DJANGO=1.7

@coveralls
Copy link

coveralls commented May 17, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 51e3fb7 on Villoid:feature/python-3 into a5f7398 on azavea:master.

@maryokhin
Copy link
Contributor Author

maryokhin commented May 17, 2016

A bit confused by all the string stuff in Python 2/3, but trying to figure it out. Can you mb explain what the sanitisation of strings and _safe_utf8_stringify does, @jwalgran?

@maurizi
Copy link
Contributor

maurizi commented May 17, 2016

@maryokhin As noted on the Python website csv.DictWriter on Python 2 does not support unicode. So the purpose of _safe_utf8_stringify is to ensure that all unicode string content gets encoded as UTF-8 before being added to the CSV.

This may not be necessary on Python 3, as the docs do not have the same note about not supporting unicode that they do on the Python 2 version.

(Though obviously we'd like to continue supporting Python 2.7).

@maurizi maurizi merged commit ee41f52 into azavea:master Sep 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants