-
Notifications
You must be signed in to change notification settings - Fork 42
Add support for Python 3.5 #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d0dbb13
to
b26da0a
Compare
python: | ||
- "2.6" | ||
- "2.7" | ||
- 2.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to update the exclude
configuration block below to remove the quotes around "2.6"
to get the Travis CI builds to pass.
b26da0a
to
2cb7c25
Compare
@maryokhin Thanks for the PR! Python 3 support has been desired by a number of folks for a while now, so I think we'll be happy to merge this if the Travis CI builds pass. |
Upgrading Django seems like the better option. |
3507a81
to
9641e2c
Compare
According to this chart, Django 1.7 is not supported under Python 3.5. https://docs.djangoproject.com/en/1.7/faq/install/#what-python-version-can-i-use-with-django We should exclude it from our matrix matrix:
exclude:
- python: 3.5
env: DJANGO=1.7 |
9641e2c
to
51e3fb7
Compare
A bit confused by all the string stuff in Python 2/3, but trying to figure it out. Can you mb explain what the sanitisation of strings and |
@maryokhin As noted on the Python website This may not be necessary on Python 3, as the docs do not have the same note about not supporting unicode that they do on the Python 2 version. (Though obviously we'd like to continue supporting Python 2.7). |
No description provided.