fix(Scripts/Naxxramas): Razuvious' Death Knight Understudy RP

[sogladev]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Adds Out of Combat RP to Razuvious and his Death Knight Understudies.

• Add creature texts to Razuvious and Understudies. broadcast_ids are present in DB. Razuvious' "Pathetic...", picked Broadcast_ID "27865" as there are 3 exactly the same in the DB
• Only the Bottom left add can speak. Razuvious only speaks to this add. Sometimes he doesn't speak, but emotes
• Razuvious should emote "Exclamation" to all adds. Each add responds with a "Talk" and "Salute". Only the bottom left add is special. Razuvious often, but not always speaks to the bottom left add. Bottom left always speaks with 1 of 3 texts.
• Event repeats every 60-80s.
• Razuvious walks closely to the add and then emotes or speaks.
• Order of adds looks to be based on timing and wherever he is during his patrol. Implementation is ordered and based on reached WP.

Issues Addressed:

• Closes

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

razu_rp.mp4

retail VOD: full 18 min recording https://www.youtube.com/watch?v=O7NDubkjbWg

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1. .go c 128312
2. observe RP

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[sogladev]

Pausing his patrol to walk up to an add is broken / incomplete and resuming pathing is broken.

I can stop him with me->SetControlled(false, UNIT_STATE_ROOT); or setting speed to 0.0f does the trick but unrooting makes him skip a waypoint...

[sogladev]

vid with sped up timer: https://youtu.be/lYJGwxtcm78

currently relies on loading path after doing RP. This moves Razu back to wp 0 of his path. Instead, he should continue where he left off

[sogladev]

Closing for now. Will PR Understudy animation separately

At this time, MotionMaster does not allow for this type of movement interaction:

Waypoint -> Pause, Move, Action -> Resume

from acore discord support https://discord.com/channels/217589275766685707/1249809406229745774