Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Deps/MySQL): Drop MariaDB and MySQL 5.7/8.1 and add MySQL 8.… #19451

Merged
merged 7 commits into from
Sep 19, 2024

Conversation

Kitzunu
Copy link
Member

@Kitzunu Kitzunu commented Jul 20, 2024

…4 support

Changes Proposed:

  • Support MySQL LTS version 8.4

  • Bump min Server and Client version to MySQL 8.0 (LTS)

  • Drop support for MySQL 5.7 (EOL)

  • Drop support for MySQL 8.1 (EOL)

  • Drop support for MariaDB as it is using MySQL 5.7 functions


Before all the MariaDB and Linux fans try to gut me in the comments...

  • AzerothCore cannot satisfy all users' preferred dependencies
  • AzerothCore has always been MySQL support first. The reason behind previous support of MariaDB is that they have been closely compatible.
  • MariaDB is built upon MySQL 5.7 functions which will inevitably become compatible with MySQL 8.4 as they will continue to deprecate 5.7 functionality.
  • MariaDB may be shipped with most linux distros, but there is no issues in installing MySQL. Just do it.
  • If MariaDB decides one day to adapt MySQL 8 functions, then we can support it again I guess :D

Test done

Build
========== Build: 1 succeeded, 0 failed, 18 up-to-date, 1 skipped ==========

Using SSL version: OpenSSL 3.3.1 4 Jun 2024 (library: OpenSSL 3.3.1 4 Jun 2024)
Using Boost version: 1.85.0
Using CMake version: 3.27.4
Using MySQL version: 80401
Found MySQL Executable: C:/Program Files/MySQL/MySQL Server 8.4/bin/mysql.exe

Log into game

Used some commands

Todo

…4 support

* Support MySQL LTS version 8.4

* Bump min Server and Client version to MySQL 8.0 (LTS)

* Drop support for MySQL 5.7 (EOL)

* Drop support for MariaDB as it is using MySQL 5.7 functions
@Kitzunu Kitzunu added Waiting to be Tested Ready to be Reviewed Requires WIKI Update Wiki sources will need to be updated after merging this PR. labels Jul 20, 2024
@github-actions github-actions bot added CORE Related to the core CMake Documentation file-cpp Used to trigger the matrix build labels Jul 20, 2024
@Kitzunu Kitzunu added the run-build Used to trigger the windows/mac/docker and matrix builds label Jul 20, 2024
@github-actions github-actions bot added the Bash label Jul 20, 2024
@IntelligentQuantum
Copy link
Member

Maria 😢

@PkllonG
Copy link
Contributor

PkllonG commented Jul 20, 2024

For me, I'll still use MariaDB, MySQL is too difficult to use

@Kitzunu
Copy link
Member Author

Kitzunu commented Jul 20, 2024

It isn't but okay. Just be prepared that they will not be compatible at all in the future. But that is your issue then.

@PkllonG
Copy link
Contributor

PkllonG commented Jul 20, 2024

I'm using mariadb10.11.8 and probably doesn't have those compatibility issues you described.
image
It also has a newer version.

@Kitzunu
Copy link
Member Author

Kitzunu commented Jul 20, 2024

Not yet :D

@PkllonG
Copy link
Contributor

PkllonG commented Jul 20, 2024

I'm using mariadb10.11.8 and probably doesn't have those compatibility issues you described. image It also has a newer version.

Compatibility should be no problem

@Kitzunu
Copy link
Member Author

Kitzunu commented Jul 20, 2024

MariaDB is built on 5.7 and they have no intention to adapt to MySQL 8 functionality. So while it may not be breaking right now, it will definitely do so in the future.

@avarishd
Copy link
Contributor

Nuke em.

@github-actions github-actions bot added the DB related to the SQL database label Jul 20, 2024
@kissingers
Copy link
Contributor

I think since AZ is based on the open source, it should ditch the closed source mysql and should go for the open source compatible maridb

@Kitzunu
Copy link
Member Author

Kitzunu commented Jul 20, 2024

Not really how it works

@chsko
Copy link

chsko commented Jul 20, 2024

May be off topic, but is Postgres worth considering? Open source and huge community

@Kitzunu
Copy link
Member Author

Kitzunu commented Jul 20, 2024

No, and I will refer back to what I have said before, AzerothCore cannot satisfy all users' preferred dependencies. It is also not worth the hassle to completely change. AzerothCore has always been MySQL support first as most maintainers use it and therefore it is what the maintainers decide to support.

@PkllonG
Copy link
Contributor

PkllonG commented Jul 21, 2024

I have to say that since MySQL was acquired, MySQL performance has been poor and it is very inconvenient to use.
I tried it out for an afternoon: remove.

@chsko
Copy link

chsko commented Jul 21, 2024

No, and I will refer back to what I have said before, AzerothCore cannot satisfy all users' preferred dependencies. It is also not worth the hassle to completely change. AzerothCore has always been MySQL support first as most maintainers use it and therefore it is what the maintainers decide to support.

I should've been more specific in my first comment. What I meant was replace MySQL with Postgres, not as an addition. That's also why I considered it a bit off topic, such a change is a larger undertaking and deserves its own discussion.

@michaeldelago
Copy link
Contributor

Using Postgres would certainly be an interesting project, though it'd be a huge amount of work to ensure it all works.

MySQL is GPL, it's open source.

If we want to argue about changing databases, I'd be in favor of switching to use something like https://github.com/rbock/sqlpp11 for database connections, making mariadb and postgres (and sqlite 👀 ) theoretically possible, though I'd still think it's best to primarily support mysql.

@Nyeriah
Copy link
Member

Nyeriah commented Aug 14, 2024

Title says MySQL 8.1 is going to be dropped is that a typo?

@Grimdhex
Copy link
Contributor

(there is no reason to keep any version other than MySQL 8.4 LTS if you drop MySQL 5.7)

I know that this PR is quite sensitive and let the time to people to migrate on MySQL but is it possible to at least push the MySQL 8.4 support ? It's a bit annoying to have to manually copy/paste a temporary file every time I create a branch for a PR ^^

@Kitzunu
Copy link
Member Author

Kitzunu commented Aug 14, 2024

Title says MySQL 8.1 is going to be dropped is that a typo?

No, not a typo. 8.1 is EOL. 8.0 and 8.4 is LTS

@Nyeriah
Copy link
Member

Nyeriah commented Sep 13, 2024

Merging it next Thursday unless there's heavy objection

@Nyeriah Nyeriah added To Be Merged - Later This PR promotes delicate changes and has been flagged to be merged after the holiday seasons. and removed Waiting to be Tested labels Sep 13, 2024
@TheSCREWEDSoftware
Copy link
Contributor

What changes are required for the wiki, if any haven't already been done

@sudlud
Copy link
Member

sudlud commented Sep 15, 2024

There's already a PR on the wiki

@alecsci
Copy link
Member

alecsci commented Sep 15, 2024

I suppose the docker-compose setup won't be affected by this since it uses 8.3 ?

@sudlud
Copy link
Member

sudlud commented Sep 16, 2024

If docker uses acore.sh for setup, then nothing has been updated there for docker yet iirc.

@michaeldelago

@Nyeriah Nyeriah merged commit dbde182 into azerothcore:master Sep 19, 2024
17 of 18 checks passed
@Kitzunu Kitzunu deleted the deprecate-old-mysql branch September 19, 2024 16:00
Kitzunu added a commit to azerothcore/wiki that referenced this pull request Sep 19, 2024
Kitzunu added a commit to azerothcore/wiki that referenced this pull request Sep 19, 2024
@It0w
Copy link

It0w commented Sep 26, 2024

I get the following fatal error when compiling:

==== ACORE COMPILER ====
Cleaning build files in /mnt/raid0/wow_server/azerothcore/var/build/obj
Build path: /mnt/raid0/wow_server/azerothcore/var/build/obj
DEBUG info: OFF
Compilation type: Release
CCache: true
Platform: linux-gnu
-- CMake version: 3.25.1
-- The CXX compiler identification is Clang 14.0.6
-- The C compiler identification is Clang 14.0.6
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/clang - skipped
-- Detecting C compile features
-- Detecting C compile features - done
> Warning: module using deprecated add config file api
-- POCKET PORTAL CONFIGURED --
-- Running cmake hook: AFTER_LOAD_CONF
-- No hooks registered for AFTER_LOAD_CONF
-- Enabled С++20 standard
-- Detected 64-bit platform
-- UNIX: Using jemalloc
-- UNIX: Using default configuration directory
-- UNIX: Using default library directory
-- UNIX: Configuring uninstall target
-- UNIX: Created uninstall target
-- UNIX: Detected compiler: /usr/bin/clang
-- Clang: Minimum version required is 10.0.0, found 14.0.6 - ok!
-- Performing Test CLANG_HAVE_PROPER_CHARCONV
-- Performing Test CLANG_HAVE_PROPER_CHARCONV - Success
-- Clang: All warnings enabled
-- Running cmake hook: AFTER_LOAD_CMAKE_MODULES
-- No hooks registered for AFTER_LOAD_CMAKE_MODULES
-- Using mysql-config: /usr/bin/mysql_config
-- Found MySQL library: /usr/lib/x86_64-linux-gnu/libmariadb.so
-- Found MySQL headers: /usr/include/mariadb
-- Found MySQL executable: /usr/bin/mysql
-- Found git binary : /usr/bin/git

* AzerothCore revision            : c2be39898609+ 2024-09-25 18:03:41 +0000 (master branch)
* AzerothCore buildtype           : Release

* Install core to                 : /mnt/raid0/wow_server/azeroth-server
* Install libraries to            : /mnt/raid0/wow_server/azeroth-server/lib
* Install configs to              : /mnt/raid0/wow_server/azeroth-server/etc

* Build applications              : Yes (all)
* Build tools                     : No
* Build with scripts              : Yes (static)
* Build with modules              : Yes (static)
* Build unit tests                : No  (default)
* Build core w/PCH                : No
* Build scripts w/PCH             : No
* Show all warnings               : Yes
* Use coreside debug              : No  (default)
* Use unix gperftools             : No  (default)
* Use GIT revision hash           : Yes (default)
* Enable vmap DisableMgr checks   : Yes (default)
* Show source tree                : No (For UNIX default)

-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.74.0/BoostConfig.cmake (found suitable version "1.74.0", minimum required is "1.67") found components: system filesystem program_options iostreams regex
-- Looking for strtod_l
-- Looking for strtod_l - not found
-- Looking for MADV_FREE
-- Looking for MADV_FREE - found
-- Found OpenSSL: /usr/lib/x86_64-linux-gnu/libcrypto.so (found version "3.0.14") found components: Crypto SSL
-- Looking for C++ include filesystem
-- Looking for C++ include filesystem - found
-- Performing Test CXX_FILESYSTEM_NO_LINK_NEEDED
-- Performing Test CXX_FILESYSTEM_NO_LINK_NEEDED - Success
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version "1.2.13")
-- Found Readline library: /usr/lib/x86_64-linux-gnu/libreadline.so
-- Include dir is: /usr/include
-- Running cmake hook: BEFORE_SRC_LOAD
-- No hooks registered for BEFORE_SRC_LOAD

* Apps build list (all):
  |
  +- apps
  |   +- authserver
  |   +- worldserver
  |

-- Running cmake hook: BEFORE_GAME_LIBRARY
-- No hooks registered for BEFORE_GAME_LIBRARY
-- Running cmake hook: AFTER_GAME_LIBRARY
-- No hooks registered for AFTER_GAME_LIBRARY
-- Running cmake hook: BEFORE_SCRIPTS_LIBRARY
-- No hooks registered for BEFORE_SCRIPTS_LIBRARY
* Script configuration (static):
  |
  +- worldserver
  |   +- Commands
  |   +- Custom
  |   +- EasternKingdoms
  |   +- Events
  |   +- Kalimdor
  |   +- Northrend
  |   +- OutdoorPvP
  |   +- Outland
  |   +- Pet
  |   +- Spells
  |   +- World
  |

* Modules configuration (static):
  |
  +- worldserver
  |   +- DungeonRespawn
  |   +- mod-ah-bot
  |   +- mod-aoe-loot
  |   +- mod-autobalance
  |   +- mod-custom-login
  |   +- mod-gain-honor-guard
  |   +- mod-money-for-kills
  |   +- mod-npc-enchanter
  |   +- mod-pocket-portal
  |   +- mod-random-enchants
  |   +- mod-reagent-bank
  |   +- mod-save-inventory
  |   +- mod-transmog
  |

> Module (mod-pocket-portal) using deprecated loader api
-- * Modules config list:
  |
--   +- DungeonRespawn
--   |  * dungeonrespawn.conf.dist
--   +- mod-ah-bot
--   |  * mod_ahbot.conf.dist
--   +- mod-aoe-loot
--   |  * mod_aoe_loot.conf.dist
--   +- mod-autobalance
--   |  * AutoBalance.conf.dist
--   +- mod-custom-login
--   |  * mod_customlogin.conf.dist
--   +- mod-gain-honor-guard
--   |  * GainHonorGuard.conf.dist
--   +- mod-money-for-kills
--   |  * mod_moneyforkills.conf.dist
--   +- mod-npc-enchanter
--   |  * npc_enchanter.conf.dist
--   +- mod-pocket-portal
--   |  * pocketportal.conf.dist
--   +- mod-random-enchants
--   |  * random_enchants.conf.dist
--   +- mod-reagent-bank
--   |  * reagent_bank.conf.dist
--   +- mod-save-inventory
--   |  * mod-save-inventory.conf.dist
--   +- mod-transmog
--   |  * transmog.conf.dist

-- Running cmake hook: AFTER_SRC_LOAD
-- No hooks registered for AFTER_SRC_LOAD
-- Configuring done
-- Generating done
-- Build files have been written to: /mnt/raid0/wow_server/azerothcore/var/build/obj
Running hooks: HOOKS_MAP_ON_AFTER_CONFIG
Using 18 threads
Statistics zeroed
Cleaning... 100.0% [===================================================================================================]
[  0%] Building CXX object deps/gsoap/CMakeFiles/gsoap.dir/soapServer.cpp.o
[  0%] Building CXX object deps/recastnavigation/Detour/CMakeFiles/Detour.dir/Source/DetourAlloc.cpp.o
[  0%] Building CXX object deps/recastnavigation/Detour/CMakeFiles/Detour.dir/Source/DetourAssert.cpp.o
[  1%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/BinaryFormat.cpp.o
[  1%] Building CXX object deps/recastnavigation/Detour/CMakeFiles/Detour.dir/Source/DetourNavMesh.cpp.o
[  1%] Building CXX object deps/gsoap/CMakeFiles/gsoap.dir/soapC.cpp.o
[  0%] Building CXX object deps/fmt/CMakeFiles/fmt.dir/src/os.cc.o
[  0%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/AABox.cpp.o
[  1%] Building CXX object deps/recastnavigation/Detour/CMakeFiles/Detour.dir/Source/DetourCommon.cpp.o
[  1%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/Any.cpp.o
[  1%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/AnyTableReader.cpp.o
[  1%] Building CXX object deps/fmt/CMakeFiles/fmt.dir/src/format.cc.o
[  2%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/arena.c.o
[  2%] Building C object deps/SFMT/CMakeFiles/sfmt.dir/SFMT.c.o
[  2%] Building C object deps/argon2/CMakeFiles/argon2.dir/argon2/argon2.c.o
[  2%] Building CXX object deps/gsoap/CMakeFiles/gsoap.dir/stdsoap2.cpp.o
[  2%] Building CXX object deps/recastnavigation/Recast/CMakeFiles/Recast.dir/Source/Recast.cpp.o
[  2%] Building CXX object deps/recastnavigation/Detour/CMakeFiles/Detour.dir/Source/DetourNavMeshBuilder.cpp.o
[  2%] Building CXX object deps/recastnavigation/Detour/CMakeFiles/Detour.dir/Source/DetourNavMeshQuery.cpp.o
[  2%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/BinaryInput.cpp.o
[  2%] Building CXX object deps/recastnavigation/Detour/CMakeFiles/Detour.dir/Source/DetourNode.cpp.o
[  2%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/bin.c.o
[  2%] Building CXX object deps/recastnavigation/Recast/CMakeFiles/Recast.dir/Source/RecastAlloc.cpp.o
[  2%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/background_thread.c.o
[  2%] Linking CXX static library libsfmt.a
[  3%] Building C object deps/argon2/CMakeFiles/argon2.dir/argon2/core.c.o
[  3%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/bitmap.c.o
[  3%] Linking CXX static library libfmt.a
[  3%] Building CXX object deps/recastnavigation/Recast/CMakeFiles/Recast.dir/Source/RecastAssert.cpp.o
[  3%] Building C object deps/argon2/CMakeFiles/argon2.dir/argon2/encoding.c.o
[  3%] Building C object deps/argon2/CMakeFiles/argon2.dir/argon2/blake2/blake2b.c.o
[  3%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/base.c.o
[  3%] Linking CXX static library libgsoap.a
[  3%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/BinaryOutput.cpp.o
[  3%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/ctl.c.o
[  3%] Linking CXX static library libDetour.a
[  3%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/Capsule.cpp.o
[  4%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/Box.cpp.o
[  4%] Building CXX object deps/recastnavigation/Recast/CMakeFiles/Recast.dir/Source/RecastArea.cpp.o
[  4%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/div.c.o
[  4%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/CollisionDetection.cpp.o
[  4%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/ckh.c.o
[  4%] Building C object deps/argon2/CMakeFiles/argon2.dir/argon2/thread.c.o
[  4%] Building C object deps/argon2/CMakeFiles/argon2.dir/argon2/opt.c.o
[  4%] Building CXX object deps/recastnavigation/Recast/CMakeFiles/Recast.dir/Source/RecastContour.cpp.o
[  4%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/extent.c.o
[  4%] Building CXX object deps/recastnavigation/Recast/CMakeFiles/Recast.dir/Source/RecastFilter.cpp.o
[  4%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/CoordinateFrame.cpp.o
[  4%] Linking CXX static library libargon2.a
[  4%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/extent_dss.c.o
[  4%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/Crypto.cpp.o
[  4%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/Cylinder.cpp.o
[  4%] Building CXX object deps/recastnavigation/Recast/CMakeFiles/Recast.dir/Source/RecastLayers.cpp.o
[  4%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/debugAssert.cpp.o
[  4%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/extent_mmap.c.o
[  4%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/FileSystem.cpp.o
[  4%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/fileutils.cpp.o
[  4%] Building CXX object deps/recastnavigation/Recast/CMakeFiles/Recast.dir/Source/RecastMesh.cpp.o
[  4%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/hash.c.o
[  5%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/hook.c.o
[  5%] Building CXX object deps/recastnavigation/Recast/CMakeFiles/Recast.dir/Source/RecastRasterization.cpp.o
[  5%] Building CXX object deps/recastnavigation/Recast/CMakeFiles/Recast.dir/Source/RecastMeshDetail.cpp.o
[  5%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/jemalloc.c.o
[  5%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/large.c.o
[  5%] Building CXX object deps/recastnavigation/Recast/CMakeFiles/Recast.dir/Source/RecastRegion.cpp.o
[  5%] Building CXX object deps/jemalloc/CMakeFiles/jemalloc.dir/src/jemalloc_cpp.cpp.o
[  6%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/format.cpp.o
[  6%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/log.c.o
[  6%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/g3dfnmatch.cpp.o
[  6%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/malloc_io.c.o
[  6%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/mutex.c.o
[  6%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/mutex_pool.c.o
[  6%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/GThread.cpp.o
[  6%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/pages.c.o
[  6%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/g3dmath.cpp.o
[  6%] Built target fmt
[  6%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/nstime.c.o
[  6%] Linking CXX static library libRecast.a
[  7%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/prof.c.o
[  7%] Built target sfmt
[  7%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/prng.c.o
[  7%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/rtree.c.o
[  7%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/Line.cpp.o
[  7%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/LineSegment.cpp.o
[  7%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/Log.cpp.o
[  7%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/Matrix3.cpp.o
[  7%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/sc.c.o
[  7%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/stats.c.o
[  7%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/safety_check.c.o
[  7%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/sz.c.o
[  7%] Built target gsoap
[  7%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/Matrix4.cpp.o
[  7%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/MemoryManager.cpp.o
[  7%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/tcache.c.o
[  7%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/test_hooks.c.o
[  8%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/Plane.cpp.o
[  8%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/tsd.c.o
[  8%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/PhysicsFrame.cpp.o
[  8%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/Quat.cpp.o
[  8%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/prompt.cpp.o
[  8%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/ticker.c.o
[  8%] Built target Detour
[  8%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/Random.cpp.o
[  8%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/Ray.cpp.o
[  8%] Building C object deps/jemalloc/CMakeFiles/jemalloc.dir/src/witness.c.o
[  8%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/RegistryUtil.cpp.o
[  8%] Built target argon2
[  8%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/Sphere.cpp.o
[  8%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/System.cpp.o
[  8%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/TextInput.cpp.o
[  8%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/stringutils.cpp.o
[  8%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/TextOutput.cpp.o
[  9%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/Triangle.cpp.o
[  9%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/uint128.cpp.o
[  9%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/Vector2.cpp.o
[  9%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/Vector4.cpp.o
[ 10%] Linking CXX static library libjemalloc.a
[ 10%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/UprightFrame.cpp.o
[ 10%] Building CXX object deps/g3dlite/CMakeFiles/g3dlib.dir/source/Vector3.cpp.o
[ 10%] Linking CXX static library libg3dlib.a
[ 10%] Built target Recast
[ 10%] Built target revision.h
[ 10%] Built target jemalloc
[ 10%] Built target g3dlib
[ 10%] Building CXX object src/common/CMakeFiles/common.dir/Collision/Management/VMapFactory.cpp.o
[ 10%] Building CXX object src/common/CMakeFiles/common.dir/Collision/BoundingIntervalHierarchy.cpp.o
[ 10%] Building CXX object src/common/CMakeFiles/common.dir/Collision/DynamicTree.cpp.o
[ 10%] Building CXX object src/common/CMakeFiles/common.dir/Collision/Management/MMapFactory.cpp.o
[ 10%] Building CXX object src/common/CMakeFiles/common.dir/Collision/Maps/TileAssembler.cpp.o
[ 10%] Building CXX object src/common/CMakeFiles/common.dir/Collision/Management/MMapMgr.cpp.o
[ 11%] Building CXX object src/common/CMakeFiles/common.dir/GitRevision.cpp.o
[ 10%] Building CXX object src/common/CMakeFiles/common.dir/Common.cpp.o
[ 11%] Building CXX object src/common/CMakeFiles/common.dir/Collision/Models/ModelInstance.cpp.o
[ 11%] Building CXX object src/common/CMakeFiles/common.dir/Collision/Maps/MapTree.cpp.o
[ 12%] Building CXX object src/common/CMakeFiles/common.dir/Configuration/BuiltInConfig.cpp.o
[ 12%] Building CXX object src/common/CMakeFiles/common.dir/Collision/Models/WorldModel.cpp.o
[ 12%] Building CXX object src/common/CMakeFiles/common.dir/Collision/Management/VMapMgr2.cpp.o
[ 12%] Building CXX object src/common/CMakeFiles/common.dir/Collision/Models/GameObjectModel.cpp.o
[ 12%] Building CXX object src/common/CMakeFiles/common.dir/Configuration/Config.cpp.o
[ 12%] Building CXX object src/common/CMakeFiles/common.dir/Banner.cpp.o
[ 12%] Building CXX object src/common/CMakeFiles/common.dir/Cryptography/AES.cpp.o
[ 12%] Building CXX object src/common/CMakeFiles/common.dir/Cryptography/ARC4.cpp.o
[ 12%] Building CXX object src/common/CMakeFiles/common.dir/Cryptography/Argon2.cpp.o
[ 12%] Building CXX object src/common/CMakeFiles/common.dir/Cryptography/BigNumber.cpp.o
[ 12%] Building CXX object src/common/CMakeFiles/common.dir/Cryptography/CryptoRandom.cpp.o
[ 12%] Building CXX object src/common/CMakeFiles/common.dir/Cryptography/OpenSSLCrypto.cpp.o
[ 12%] Building CXX object src/common/CMakeFiles/common.dir/Cryptography/TOTP.cpp.o
[ 12%] Building CXX object src/common/CMakeFiles/common.dir/Cryptography/Authentication/AuthCrypt.cpp.o
[ 12%] Building CXX object src/common/CMakeFiles/common.dir/IPLocation/IPLocation.cpp.o
[ 12%] Building CXX object src/common/CMakeFiles/common.dir/Cryptography/Authentication/SRP6.cpp.o
[ 12%] Building CXX object src/common/CMakeFiles/common.dir/Encoding/Base32.cpp.o
[ 12%] Building CXX object src/common/CMakeFiles/common.dir/Encoding/Base64.cpp.o
[ 13%] Building CXX object src/common/CMakeFiles/common.dir/DataStores/DBCFileLoader.cpp.o
[ 13%] Building CXX object src/common/CMakeFiles/common.dir/Logging/Appender.cpp.o
[ 13%] Building CXX object src/common/CMakeFiles/common.dir/Logging/AppenderConsole.cpp.o
[ 13%] Building CXX object src/common/CMakeFiles/common.dir/Logging/AppenderFile.cpp.o
[ 13%] Building CXX object src/common/CMakeFiles/common.dir/Logging/Log.cpp.o
[ 13%] Building CXX object src/common/CMakeFiles/common.dir/Logging/Logger.cpp.o
[ 13%] Building CXX object src/common/CMakeFiles/common.dir/Logging/LogMessage.cpp.o
[ 13%] Building CXX object src/common/CMakeFiles/common.dir/Logging/LogOperation.cpp.o
[ 14%] Building CXX object src/common/CMakeFiles/common.dir/Logging/enuminfo_LogCommon.cpp.o
[ 14%] Building CXX object src/common/CMakeFiles/common.dir/Logging/enuminfo_AppenderConsole.cpp.o
[ 14%] Building CXX object src/common/CMakeFiles/common.dir/Navigation/DetourExtended.cpp.o
[ 14%] Building CXX object src/common/CMakeFiles/common.dir/Threading/ProcessPriority.cpp.o
[ 14%] Building CXX object src/common/CMakeFiles/common.dir/Metric/Metric.cpp.o
[ 14%] Building CXX object src/common/CMakeFiles/common.dir/Threading/Threading.cpp.o
[ 14%] Building CXX object src/common/CMakeFiles/common.dir/Utilities/EventProcessor.cpp.o
[ 14%] Building CXX object src/common/CMakeFiles/common.dir/Utilities/EventMap.cpp.o
[ 14%] Building CXX object src/common/CMakeFiles/common.dir/Utilities/Random.cpp.o
[ 14%] Building CXX object src/common/CMakeFiles/common.dir/Utilities/SFMTRand.cpp.o
[ 14%] Building CXX object src/common/CMakeFiles/common.dir/Utilities/StartProcess.cpp.o
[ 14%] Building CXX object src/common/CMakeFiles/common.dir/Utilities/StringFormat.cpp.o
[ 15%] Building CXX object src/common/CMakeFiles/common.dir/Utilities/TaskScheduler.cpp.o
[ 15%] Building CXX object src/common/CMakeFiles/common.dir/Utilities/Timer.cpp.o
[ 15%] Building CXX object src/common/CMakeFiles/common.dir/Utilities/Tokenize.cpp.o
[ 15%] Building CXX object src/common/CMakeFiles/common.dir/Utilities/Util.cpp.o
[ 15%] Building CXX object src/common/CMakeFiles/common.dir/Debugging/Errors.cpp.o
[ 15%] Linking CXX static library libcommon.a
[ 15%] Built target common
[ 15%] Building CXX object src/server/database/CMakeFiles/database.dir/Database/DatabaseLoader.cpp.o
[ 15%] Building CXX object src/server/database/CMakeFiles/database.dir/Database/DatabaseWorker.cpp.o
[ 16%] Building CXX object src/server/database/CMakeFiles/database.dir/Database/MySQLConnection.cpp.o
[ 16%] Building CXX object src/server/database/CMakeFiles/database.dir/Database/Field.cpp.o
[ 16%] Building CXX object src/server/database/CMakeFiles/database.dir/Database/DatabaseWorkerPool.cpp.o
[ 16%] Building CXX object src/server/database/CMakeFiles/database.dir/Database/PreparedStatement.cpp.o
[ 16%] Building CXX object src/server/database/CMakeFiles/database.dir/Database/QueryCallback.cpp.o
[ 16%] Building CXX object src/server/database/CMakeFiles/database.dir/Database/MySQLPreparedStatement.cpp.o
[ 15%] Building CXX object src/server/database/CMakeFiles/database.dir/Database/DatabaseEnv.cpp.o
[ 15%] Building CXX object src/server/database/CMakeFiles/database.dir/Database/AdhocStatement.cpp.o
[ 16%] Building CXX object src/server/database/CMakeFiles/database.dir/Database/Implementation/CharacterDatabase.cpp.o
[ 16%] Building CXX object src/server/database/CMakeFiles/database.dir/Database/Transaction.cpp.o
[ 16%] Building CXX object src/server/database/CMakeFiles/database.dir/Database/MySQLThreading.cpp.o
[ 16%] Building CXX object src/server/database/CMakeFiles/database.dir/Database/QueryHolder.cpp.o
[ 16%] Building CXX object src/server/database/CMakeFiles/database.dir/Database/Implementation/LoginDatabase.cpp.o
[ 17%] Building CXX object src/server/database/CMakeFiles/database.dir/Database/Implementation/WorldDatabase.cpp.o
[ 17%] Building CXX object src/server/database/CMakeFiles/database.dir/Database/QueryResult.cpp.o
[ 17%] Building CXX object src/server/database/CMakeFiles/database.dir/Logging/AppenderDB.cpp.o
[ 17%] Building CXX object src/server/database/CMakeFiles/database.dir/Updater/DBUpdater.cpp.o
[ 17%] Building CXX object src/server/database/CMakeFiles/database.dir/Updater/UpdateFetcher.cpp.o
/mnt/raid0/wow_server/azerothcore/src/server/database/Database/MySQLConnection.cpp:133:9: fatal error: use of undeclared identifier 'mysql_ssl_mode'; did you mean 'mysql_ssl_set'?
        mysql_ssl_mode opt_use_ssl = SSL_MODE_DISABLED;
        ^~~~~~~~~~~~~~
        mysql_ssl_set
/usr/include/mariadb/mysql.h:539:14: note: 'mysql_ssl_set' declared here
int             STDCALL mysql_ssl_set(MYSQL *mysql, const char *key,
                        ^
1 error generated.
gmake[2]: *** [src/server/database/CMakeFiles/database.dir/build.make:160: src/server/database/CMakeFiles/database.dir/Database/MySQLConnection.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:982: src/server/database/CMakeFiles/database.dir/all] Error 2
gmake: *** [Makefile:136: all] Error 2

real    0m1.231s
user    0m3.274s
sys     0m1.505s

--- edit

Okay, I should read more thoroughly before I do anything.

I need to change the SQL server as it is no longer compatible.

Sorry for bothering you.

@numkem numkem mentioned this pull request Oct 1, 2024
13 tasks
bgcfb added a commit to bgcfb/azerothcore-wotlk that referenced this pull request Oct 15, 2024
commit 84646a7955bb7bdb2c3910a4c7ccba8b74272f56
Author: Rorschach91 <108557877+Rorschach91@users.noreply.github.com>
Date:   Sat Oct 12 04:52:06 2024 +0200

    fix(Script/DeathKnight): A Special Surprise Npcs issues. (#20178)

commit dedea7425ef9ab53560a5dcd5467c7487cba16fc
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Fri Oct 11 17:43:03 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): cd04b6d9ed43539c21b9916fcdcb018782d14b99

commit cd04b6d9ed43539c21b9916fcdcb018782d14b99
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Fri Oct 11 13:42:05 2024 -0400

    fix(DB/Creature): Adjust Teron Gorefiend's model data. (#20181)

    Init.

commit a8a59ec7e2a0c6475af76ac3be364a016cb60820
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Fri Oct 11 12:29:53 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 94a03c629bed80b1377c9ab0de69ab33c208ca31

commit 94a03c629bed80b1377c9ab0de69ab33c208ca31
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Fri Oct 11 08:29:00 2024 -0400

    fix(Scripts/BlackTemple): Remove Naj'entus Spines from players on engage. (#20176)

commit a9080bef60680280d8649ed7a76a8924c94b218f
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Fri Oct 11 08:10:04 2024 -0400

    fix(Scripts/BlackTemple): Adjust cast behavior for Supremus's charge. (#20173)

    Init.

commit fede17f782b22fcc010b588246a19cf7cf269fd8
Author: Angelo Venturini <nefertum.dev@protonmail.com>
Date:   Fri Oct 11 08:15:02 2024 -0300

    fix(Core/Spells): Fix crash (#20179)

    Co-authored-by: Ariel Silva <ariel-@users.noreply.github.com>

commit c3ee737c80947589287848f3d8d956e32ba8b15d
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Fri Oct 11 05:51:29 2024 -0400

    fix(Core/SpellInfoCorrections): Add Arcane Missiles spell info correction. (#20165)

    Init.

    Co-authored-by: Ernesto Gonzalez <80600689+ernesto-glz@users.noreply.github.com>

commit 4ad57900391f6b19d5a4ec2e387424906ba3d150
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Fri Oct 11 09:43:04 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 7c136f18540783684b2a890c42684e3dbed18bfe

commit 7c136f18540783684b2a890c42684e3dbed18bfe
Author: sudlud <sudlud@users.noreply.github.com>
Date:   Fri Oct 11 11:42:09 2024 +0200

    fix(DB/Creature): Sniffed Values for 'Monstrous Kaliri Egg Trigger' s… (#20063)

    fix(DB/Creature): Sniffed Values for 'Monstrous Kaliri Egg Trigger' spawns

commit e5f59979d8ac57bb98fbc9452882c08f0d4d2631
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Fri Oct 11 09:40:15 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 5aef2e8fb0f273161af0302ed7733434afd77f10

commit 5aef2e8fb0f273161af0302ed7733434afd77f10
Author: Walter Pagani <paganiwalter@gmail.com>
Date:   Fri Oct 11 06:39:19 2024 -0300

    fix(SQL/smart_scripts) target in script 1436800 (#20151)

    * fix(SQL/broadcast_text_locale) Separate genders in MaleText and FemaleText

    * fix target in smart_script

    Co-Authored-By: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

    ---------

    Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

commit 0cb6081bc72f6d1a20e06f3eee598671e1ee49b8
Author: kissingers <33601959+kissingers@users.noreply.github.com>
Date:   Fri Oct 11 14:06:28 2024 +0800

    fix(Scripts/ZulAman): Nalorakk can't able to trigger instance events when death (#19895)

    * ignore .vs path

    * Fix Nalorakk not able to trigger instance events when death

    * Revert "ignore .vs path"

    This reverts commit 81e949727645d0356eb8bb9490152971dbb9b09b.

    * Remove instance null check

    * Remove instance null check

    * Revert "Remove instance null check"

    This reverts commit b97b45284edb3166bc3c253adf1773b031bb1507.

commit 47169a2b05eb2cb8f141202bfa70da155dbc444e
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Fri Oct 11 05:09:11 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 859a42a41e3ad65a9ec685d0d06f206c1a52524c

commit 859a42a41e3ad65a9ec685d0d06f206c1a52524c
Author: Jelle Meeus <sogladev@gmail.com>
Date:   Fri Oct 11 07:08:14 2024 +0200

    fix(Core/Vehicles): feat vehicle seat addon, vehicle enter/exit positions (#20082)

    * implement initial vehicle_seat_addon

    Co-authored-by: Ovah <dreadkiller@gmx.de>

    * add more vehicle_seat_addon data

    * make exiting passenger visible

    fixes "immediate despawn" of travelers mammoth

    * style, update comments

    * remove hacked pos relocate

    * remove sending MSG_MOVE_ROOT/UNROOT on Ack

    * set and unset UNIT_NPC_FLAG_PLAYER_VEHICLE on init/entry

    * ulduar demolisher: remove flag correction and no longer needed usableseat

    * fixup! implement initial vehicle_seat_addon

    * fixup! fixup! implement initial vehicle_seat_addon

    * re-add AddPassenger Flame Leviathan hack

    was commented by mistake

    * Update rev_1725993194571320983.sql

    add missing ticks

    ---------

    Co-authored-by: Ovah <dreadkiller@gmx.de>

commit e43b760c089e99226f9a88fc005cfcb14752361c
Author: Walter Pagani <paganiwalter@gmail.com>
Date:   Thu Oct 10 18:10:55 2024 -0300

    fix(Core/QuestHandler): Question marks not being shown (#20099)

commit 9487b30ad7ad25f16e6649dc1b3b8cfb817bfdcb
Author: Angelo Venturini <nefertum.dev@protonmail.com>
Date:   Thu Oct 10 16:55:58 2024 -0300

    refactor(Core/Misc): Use emplace_back instead of push_back to avoid extra copy/m… (#20114)

    refactor: Use emplace_back instead of push_back to avoid extra copy/move operations

commit cfb3229bf1522f5f4786353b2acdbfdaac30ff16
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Thu Oct 10 18:09:48 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 2809f300074b632aa50b496c50e480a13c6a725f

commit 2809f300074b632aa50b496c50e480a13c6a725f
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Thu Oct 10 14:08:52 2024 -0400

    fix(DB/Creature): Adjust model probability for Whirling Blade trigger creatures. (#20177)

    Init.

commit 2a48a14908e590ad3a6730f14c80573c9571685d
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Thu Oct 10 11:59:33 2024 -0400

    fix(Scripts/BlackTemple): Add resets for enrage events with death. (#20174)

    Init.

commit eebb5596bf9ae8486e5cab51e4d28048a076d858
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Thu Oct 10 11:27:28 2024 -0400

    fix(Scripts/BlackTemple): Adjust caster of Blaze spell. (#20172)

    * Init.

    * Account for nullptr victim.

commit 6ef16f18bbceba37399871981cffc3d3b475a174
Author: ConorB <126167126+ConorB1745@users.noreply.github.com>
Date:   Thu Oct 10 14:43:57 2024 +0200

    fix(Script): Fix npc following player after starting duel (#20161)

    * fix(Script): Changed npc move script

    Death Knight Initiate (id: 28406) was not turning to face the player
    after they engaged a duel instead the npc followed the player
    wherever they went. Change was to remove script line for follow
    and replace with SetFacingToObject and specify the player
    as the object.

    Closes AzerothCore issue #20108

    * fix(script): Fix npc following player whitespace issue

    Attempt to fix code styling fail on whtiespace

    * fix(script): Fix npc following player another whitespace issue

    Found more whitespace that was made by the fix to previous whitespace

commit 31cb7579e0f2240a4e68d8d8d499dc4160f82988
Author: Andrew <47818697+Nyeriah@users.noreply.github.com>
Date:   Wed Oct 9 08:08:37 2024 -0300

    fix(Core/Scripts): Further improve the ScheduleHealthCheck() function (#20163)

commit 0fa770d56788196bda608343dde4ceb452848f89
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Wed Oct 9 09:01:16 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): fd6d2efccbd739c2931a9ced5b9ddfe65f6d25c0

commit b2f61161e8139dfc2a2e89e1b7aedc373dc09da3
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Wed Oct 9 05:01:03 2024 -0400

    fix(DB/Spell): Remove Arcane Missile spell info overrides. (#20054)

    Init.

commit fd6d2efccbd739c2931a9ced5b9ddfe65f6d25c0
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Wed Oct 9 05:00:20 2024 -0400

    fix(Core/Unit): Add mana drain effect to Black Bow of the Betrayer. (#20155)

    * Init.

    Co-authored by: stfxpi (stfx)
    Original CMaNGOS commit: https://github.com/cmangos/mangos-tbc/commit/c750533b5ec7f688d7f026b18edd19acccd68f2f

    * Add/adjust comments.

commit a8d970caa77d4c0ef8935c294c5192b4f8792ccc
Author: Jelle Meeus <sogladev@gmail.com>
Date:   Tue Oct 8 21:44:32 2024 +0200

    fix(Core/Unit):  add rage gain when attack is fully blocked, dodged or parried (#19377)

    * generate rage if victim fully block, dodge, parry

    * update rage calculation

    * calc pct at the end

    * update comment to link to Rage formulae and mention Bornak's bluepost

    archived link to Bornak's bluepost
    https://web.archive.org/web/20090604123729/http://forums.worldofwarcraft.com/thread.html?topicId=17367760070&pageNo=13#02500

commit 98b03c07f09f47c9e7cb8a4af95f3090f06a2c18
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Tue Oct 8 14:41:02 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 8e7463e8bc3cc0d3e156690e6d87a9e5b13b32c6

commit 8e7463e8bc3cc0d3e156690e6d87a9e5b13b32c6
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Tue Oct 8 10:40:06 2024 -0400

    fix(DB/Spell): Add armor ignore attribute to Shared Rule damage spell. (#20160)

    Init.

commit d5d5df67ba0f792e8c80e78ef3d21357b9c2cd0c
Author: Rorschach91 <108557877+Rorschach91@users.noreply.github.com>
Date:   Tue Oct 8 11:53:42 2024 +0200

    fix(Script/Mother Shahraz) Add new teleport points. (#20137)

    * fix(Script/Mother Shahraz) Increase min teleport range and add new teleport points.

    This fix increase minimum teleport range for Fatal Attraction and It adds 5 new teleport points if the boss is near the platform.

    * Update boss_mother_shahraz.cpp

commit cc5c582b4d0cb941a3c28bf49fe3fed80bc85e98
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Mon Oct 7 07:55:28 2024 -0400

    fix(Core/Spell): Include damaging spells for starting combat. (#20154)

    Init.

commit a57d8db81a247b23823703be78e22dad6ddba8b0
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Mon Oct 7 07:55:00 2024 -0400

    fix(Core/CharmInfo): Add exception for Kil'jaeden dragon charm spells. (#20150)

    Init.

commit d340ae029b19c5c8ddfa61f0bb0d4725234f3452
Author: Andrew <47818697+Nyeriah@users.noreply.github.com>
Date:   Sat Oct 5 06:02:31 2024 -0300

    fix(Scripts/Dragonblight): Fix Torturer Leclaft spamming abilities (#20130)

    fix(Scripts/Dragonblight): Fix Toturer Leclaft spamming abilities

commit 508b7369c708112e7434863f9c5cf6d1a7a24bd7
Author: Grimdhex <176165533+Grimdhex@users.noreply.github.com>
Date:   Sat Oct 5 11:02:06 2024 +0200

    fix(Scripts/BlackTemple): exclude off tank of the Azzinoth Flame's charge (#20133)

    * fix(Scripts/BlackTemple): exclude off tank of the Azzinoth Flame's charge

    * remove an unecessary elseif

    * Update boss_illidan.cpp

commit 01b86ec7a6c9307075bd7580290fa0790b84fa6d
Author: Jelle Meeus <sogladev@gmail.com>
Date:   Fri Oct 4 16:01:36 2024 +0200

    fix(Core/Unit): update death state before handling RemoveAllAurasOnDeath() (#20124)

    fix setDeathState

    [PATCH] Don't allow units to enter combat upon death
    https://github.com/TrinityCore/TrinityCore/commit/91ebea4a77e1db10cea85ff8e891a2ea3f3587ab.patch
    Co-authored-by: trickerer <onlysuffering@gmail.com>

commit dda54fd6383fb608134cf861dbea519b70e434d0
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Fri Oct 4 12:57:33 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 2d70ae159f0cfbd466c3dd26552f436d7e28a80a

commit 2d70ae159f0cfbd466c3dd26552f436d7e28a80a
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Fri Oct 4 08:56:34 2024 -0400

    fix(DB/Spell): Link triggered Shattrath flask effects to flask aura and proper area. (#20122)

    * Init.

    * Add Bloodberry Elixir link.

    * Update `spell_area` entries.

    * Add root spell, toggle autocast for area effects.

commit 9f58d55a1d97d681114964fec540b7c728b17b52
Author: Anton Popovichenko <anton.popovichenko@mendix.com>
Date:   Fri Oct 4 11:32:42 2024 +0200

    fix(Core/Items): Fix exploit where multiple auras could be applied from a single enchantment. (#20128)

commit cc37941ef550e1465a112e1400325d5b1716fca1
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Thu Oct 3 13:32:52 2024 -0400

    fix(Scripts/BlackTemple): Reset Illidan threat with phase four. (#20125)

    Init.

commit 67c746be7d166924011a98b5e74d666ba931b7e1
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Thu Oct 3 01:07:08 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): de7b1eac45e2a9b707c9b9779891ddf7a338ed8a

commit de7b1eac45e2a9b707c9b9779891ddf7a338ed8a
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Wed Oct 2 21:06:11 2024 -0400

    fix(DB/Creature): Adjust move type of various Black Temple creatures. (#20120)

commit c8b814d883e511e8f634a35316841461bcc657a2
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Wed Oct 2 20:38:16 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 7de5f727cc0c3469fa48a4633e9908f87c50c63c

commit 7de5f727cc0c3469fa48a4633e9908f87c50c63c
Author: Dan <83884799+elthehablo@users.noreply.github.com>
Date:   Wed Oct 2 22:37:16 2024 +0200

    fix(DB/WailingCaverns): make Boahn cast snake form (#20119)

    * Create boahn.sql

    * Update boahn.sql

commit a16ac71cbd10e1f98a184a5bba630c4978c79854
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Wed Oct 2 19:57:53 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): fa0ed1b30c8b5834023b5c0b4106792e0f6205f8

commit fa0ed1b30c8b5834023b5c0b4106792e0f6205f8
Author: Walter Pagani <paganiwalter@gmail.com>
Date:   Wed Oct 2 16:56:57 2024 -0300

    fix(Creature/Model): Model probability change (#20062)

    * fix(Creature/Model) Model probability change

    * Fixes compilation and recommendations

    * Data extracted 51831

    Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

    ---------

    Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

commit 82797a450159ccb6cf766324c4531ac7dd4218ed
Author: Dan <83884799+elthehablo@users.noreply.github.com>
Date:   Wed Oct 2 21:54:58 2024 +0200

    fix(Scripts/TheBlackTemple): remove gossip option on Akama when Illidan is dead (#20118)

commit 529e9140323edeef916bd6a1b6c97e13aa38db08
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Tue Oct 1 20:22:05 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): f48f63db42ea6ea6a01c9a05e125462952ac62d4

commit f48f63db42ea6ea6a01c9a05e125462952ac62d4
Author: sudlud <sudlud@users.noreply.github.com>
Date:   Tue Oct 1 22:21:08 2024 +0200

    fix(DB/Gameobject): add gameobjects to transports (#20117)

    * fix(DB/Gameobject): add gameobjects to transports

    * remove comment

    * assign chairs to correct transport

commit 9a1f27121a7e044ab66b937af88ebe9b358a957a
Author: Jelle Meeus <sogladev@gmail.com>
Date:   Tue Oct 1 21:39:42 2024 +0200

    fix(Core/Unit): Flight Form riding crop, vehicle speed auras (#20079)

    * vehicle aura stacking

    Rename flight speed related auras
    Co-authored-by: Laise <fenrisse@gmail.com>

    * rename to better match existing flight auras

commit a774bbd425147d89525a167ecf0d6bfdf47776d7
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Tue Oct 1 17:06:09 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 3636d7f0e4ba949f2fe4bfe2080d8d3e12d1d3e3

commit 3636d7f0e4ba949f2fe4bfe2080d8d3e12d1d3e3
Author: Dan <83884799+elthehablo@users.noreply.github.com>
Date:   Tue Oct 1 19:05:11 2024 +0200

    fix(Scripts/TheBlackTemple): resetting behaviour in p1 for Shade of Akama (#20076)

    * init

    * Update boss_shade_of_akama.cpp

    * Update boss_shade_of_akama.cpp

    * Update boss_shade_of_akama.cpp

    * update factions

    bench with the faction sniffs

    Co-Authored-By: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

    * set spawned creatures in combat again

    Co-Authored-By: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

    * wip change faction to defender

    * Update boss_shade_of_akama.cpp

    * Update boss_shade_of_akama.cpp

    * set hostiles in combat

    * Akama shade reset test (#12)

    compilation of commits with fixes and debugging

    * Update boss_shade_of_akama.cpp

    * Update factions_shade.sql

    * Update factions_shade.sql

    * Update factions_shade.sql

    * Update factions_shade.sql

    * 5s instead of 5ms

    * change faction enum names

    * revert faction change on player death

    * unused import

    * Update boss_shade_of_akama.cpp

    * unsummon all non-defenders

    * clear summons on all players dead

    * blank space

    * make creatures not stop spawning on player wipe

    * oops

    ---------

    Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

commit ee870ff3b37bc092654ae19b37db732bd83ae068
Author: Andrew <47818697+Nyeriah@users.noreply.github.com>
Date:   Tue Oct 1 06:47:44 2024 -0300

    fix(Core/Spells): Restricted aura application prevention when immune to banish effects (e.g cyclone) (#20060)

commit 003eda6db30d8c99652f9e2dd76eed40c5aa7e96
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Tue Oct 1 09:09:39 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): bc866b182ad7cedca5114235de300d3623f5e73c

commit bc866b182ad7cedca5114235de300d3623f5e73c
Author: Jelle Meeus <sogladev@gmail.com>
Date:   Tue Oct 1 11:08:40 2024 +0200

    fix(DB/Creature): Icecrown Orgrim's Hammer and The Skybreaker map icons (#20104)

    * fix Orgrim's Hammer and The Skybreaker marker npcs

    * change insert to update

commit ae30489b238a49ec1a31df55aa00eda7dab130e6
Author: Francesco Borzì <borzifrancesco@gmail.com>
Date:   Tue Oct 1 08:06:06 2024 +0200

    refactor(src/server/game/Globals): remove unused imports (#20088)

commit b0899664ef91a2a27b03af00ab2196532f7f405e
Author: Francesco Borzì <borzifrancesco@gmail.com>
Date:   Tue Oct 1 08:05:36 2024 +0200

    refactor(src/server/game/World): remove unused imports (#20090)

commit 484e19d21b7b2be5c326c7492dd7dee8156c76d8
Author: Francesco Borzì <borzifrancesco@gmail.com>
Date:   Tue Oct 1 08:05:15 2024 +0200

    refactor(src/server/game/Spells): remove unused imports (#20092)

commit 7d2aebb9d8f794ea4f1156946f2f5646649afa16
Author: Francesco Borzì <borzifrancesco@gmail.com>
Date:   Tue Oct 1 08:04:51 2024 +0200

    refactor(src/server/game/Chat): remove unused imports (#20093)

commit 9b17898f7b78e8bb8e00c39b1df8a13abb2f67d6
Author: Francesco Borzì <borzifrancesco@gmail.com>
Date:   Tue Oct 1 08:04:26 2024 +0200

    refactor(src/server/game/Grids): remove unused imports (#20094)

commit d8c56392fb5938898673a7592cee2b99534ed8ba
Author: Francesco Borzì <borzifrancesco@gmail.com>
Date:   Tue Oct 1 08:04:00 2024 +0200

    refactor(src/server/game/AI): remove unused imports (#20095)

commit d1095a9aea072758f3070711ee94087b7b76cdc2
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Tue Oct 1 06:03:41 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 7fd507e24b2efc1e2f63615b5cf40f7e74b0ddf4

commit 7fd507e24b2efc1e2f63615b5cf40f7e74b0ddf4
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Tue Oct 1 02:02:38 2024 -0400

    fix(DB/Creature): Adjust Flame of Azzinoth model data. (#20115)

    Init.

commit 804769400bcb4191d07fc21c2c2d27c37831ca24
Author: Anton Popovichenko <anton.popovichenko@mendix.com>
Date:   Mon Sep 30 13:19:44 2024 +0200

    fix(Core/GuardAI): crash when killer is null (#20100)

commit 784e80668d5b57640a4c7a4d6e2c7b898e4f804d
Author: Francesco Borzì <borzifrancesco@gmail.com>
Date:   Sun Sep 29 20:19:02 2024 +0200

    refactor(src/server/game/Entities): remove unused imports (#20096)

commit 1932fd0c8a4798849ec27c5fa9a07d0a389029c8
Author: Francesco Borzì <borzifrancesco@gmail.com>
Date:   Sun Sep 29 18:14:46 2024 +0200

    refactor(src/server/game/Battle*): remove unused imports (#20097)

commit 6e2306f24affb4535db422c33f6598a2d2704cb3
Author: Francesco Borzì <borzifrancesco@gmail.com>
Date:   Sun Sep 29 18:14:12 2024 +0200

    refactor(src/server/game/Movement): remove unused imports (#20098)

commit 1ebb53a24859fff10b957987f0ea0358e6ffcd88
Author: Francesco Borzì <borzifrancesco@gmail.com>
Date:   Sun Sep 29 18:10:50 2024 +0200

    refactor(src/server/apps|database|shared): remove unused imports (#19505)

commit 34a3b4ee47e5f835422403e615e5d484ed3a5007
Author: Francesco Borzì <borzifrancesco@gmail.com>
Date:   Sun Sep 29 14:07:45 2024 +0200

    feat(Core/BG): allow MinPlayersPerTeam override for low-levels (#20083)

commit 5a96ce283dcb4bc74a8f3bf8ca599c478e6ae5b2
Author: Francesco Borzì <borzifrancesco@gmail.com>
Date:   Sun Sep 29 13:20:21 2024 +0200

    refactor(Scripts): remove unused imports (#20086)

commit a4721c28212bb2e73cdae0062e68cdae0340a86b
Author: Francesco Borzì <borzifrancesco@gmail.com>
Date:   Sun Sep 29 13:19:40 2024 +0200

    refactor(src/server/game/Handlers): remove unused imports (#20087)

commit b45166b2d06e20c205d115b94bfea17b3aa92116
Author: Jelle Meeus <sogladev@gmail.com>
Date:   Sun Sep 29 13:18:36 2024 +0200

    fix(Core/Battlefield): shapeshift aura removal from players on leaving arena or battleground (#20069)

    no longer remove shapeshift auras from player on leave

commit 2e0a57084cb208c7f441f828e8503d7982a8e561
Author: Anton Popovichenko <anton.popovichenko@mendix.com>
Date:   Sun Sep 29 13:13:59 2024 +0200

    fix(Scripts/ICC): Fix Valkyr "teleportation" effect caused by movement desynchronization between server and client. (#20080)

commit 67f587d958fbd39bffecbabb1ba8322c2da4459e
Author: Anton Popovichenko <anton.popovichenko@mendix.com>
Date:   Sun Sep 29 00:45:59 2024 +0200

    fix(CI/Codestyle): Fix codestyle CI error introduced with the new rule for ifs. (#20081)

commit de93487ecdbe26fa8d6f56e21ce7c89cec3249db
Author: Mattia <mattia.wotlk@gmail.com>
Date:   Sat Sep 28 21:21:29 2024 +0200

    fix(Core/Script) - Black Temple - Gurtogg Bloodboil - Bewildering Strike mechanics doesnt work as it should (#20074)

    * spell_gurtogg_bloodboil_bewildering_strike_aura class added

    * Create spell_gurtogg_bloodboil_bewildering_strike_aura

    * extension sql added

    * CanAIAttack condition added

    * Delete data/sql/updates/pending_db_world/spell_gurtogg_bloodboil_bewildering_strike_aura.sql

commit 729cf72f0d0a86bf80d2f3da9255500e3be3dc67
Author: Grimdhex <176165533+Grimdhex@users.noreply.github.com>
Date:   Sat Sep 28 18:35:35 2024 +0200

    chore(Apps/Codestyle): add a new check for if statements (#20073)

    * chore(Apps/CodeStyle): add a new check for if statements

    * update

    * Update spell_priest.cpp

    * Update codestyle.py

commit 7690c35208429fcca48ab1b7ed7e2b35d060b888
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Sat Sep 28 14:49:53 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 23de73652439ce3d955c8f834c94532fbe8ece02

commit 23de73652439ce3d955c8f834c94532fbe8ece02
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Sat Sep 28 10:48:58 2024 -0400

    fix(DB/Spells): Add extra craft chance for Super Healing Potion. (#20064)

    Init.

commit b07670f130a0e27747f27fa54502825c04db8a3b
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Sat Sep 28 13:51:37 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 81251aaf5eb021b3a1e71acebd291eefc969c99d

commit 81251aaf5eb021b3a1e71acebd291eefc969c99d
Author: Jelle Meeus <sogladev@gmail.com>
Date:   Sat Sep 28 15:50:41 2024 +0200

    fix(DB/Creature): remove stun immunity from Coilfang Strider (#20071)

    remove stun mechanic immune

commit 8bf3595cef1463afc65be881a661bd814cba5bfd
Author: Grimdhex <176165533+Grimdhex@users.noreply.github.com>
Date:   Sat Sep 28 10:27:32 2024 +0200

    fix(Script/BlackTemple): teleport position with fatal attraction (#19971)

    * fix(Script/BlackTemple): teleport position with fatal attraction

    * fix codestyle

    * try a new way by keeping a random teleport

    * remove the old fixed position

    * improve the dest selection

    * raycast around the new position for check a valid dest

    * fix codestyle

    * revert the old changes

    * refactor to remove the while loop

    * few refactor

    * Revert "few refactor"

    This reverts commit fb7613d5cc5a19df01bbcf41ef5c982119ee9685.

    * .

    * add a los check

    * new improvement with stairs cases & console errors

    * fix disableWarning option

    * Update boss_mother_shahraz.cpp

    * Update boss_mother_shahraz.cpp

    * Update boss_mother_shahraz.cpp

    * Update boss_mother_shahraz.cpp

    * Update boss_mother_shahraz.cpp

commit c2a0d8cb99d30770eeb122d9937960865931957c
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Sat Sep 28 08:24:15 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): e9c969ce76d3509c46c7a9f6fb24086143605750

commit e9c969ce76d3509c46c7a9f6fb24086143605750
Author: Jelle Meeus <sogladev@gmail.com>
Date:   Sat Sep 28 10:23:19 2024 +0200

    (DB/Creatures): fixup Dual Wield for creatures, remove some CREATURE_FLAG_EXTRA_USE_OFFHAND_ATTACK (#20061)

    remove flags

commit f6de601ddd5218290268268ee695c56d88847225
Author: Stefano Borzì <stefanoborzi32@gmail.com>
Date:   Fri Sep 27 22:19:56 2024 +0200

    new BattlegroundDesertionTypes for hook OnBattlegroundDesertion (#20039)

    * new BattlegroundDesertionTypes for hook OnBattlegroundDesertion

    * chore: minor improvements

    ---------

    Co-authored-by: laasker <79991768+laasker@users.noreply.github.com>

commit d8221088f51bd2835252735c816f1ed849b6e83c
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Fri Sep 27 11:07:58 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 3dc47ee3a4614c4db887e89287d485962c222d4e

commit 3dc47ee3a4614c4db887e89287d485962c222d4e
Author: Walter Pagani <paganiwalter@gmail.com>
Date:   Fri Sep 27 08:07:01 2024 -0300

    chore(DB/CreatureText) Translate text in city guards (#20034)

    Co-authored-by: Álvaro Martín <varomartin@icloud.com>

commit 510422a4f5ecca4afdcc41bedac2b5f4bae1706d
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Thu Sep 26 18:17:02 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 35042734d6275cb7738d7621a08d282154dca74d

commit 35042734d6275cb7738d7621a08d282154dca74d
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Thu Sep 26 14:16:07 2024 -0400

    fix(DB/Creature): Add proper unit flags to Phantom Leotheras. (#20049)

    Init.

commit 8a0604479af820c5b0cfdb3fdb02985d240d79d3
Author: Jelle Meeus <sogladev@gmail.com>
Date:   Thu Sep 26 12:13:47 2024 +0200

    fix(Core/Unit): fix Dual Wield for more creatures... (#20047)

    * non-weapons should return true

    * remove shapeshift check

commit c2be39898609201a936f99bbabd4a6a3e79f5cdf
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Wed Sep 25 18:03:41 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 52b8fa1cc814040e122df4e47baaee9a1b174036

commit 52b8fa1cc814040e122df4e47baaee9a1b174036
Author: Mattia <mattia.wotlk@gmail.com>
Date:   Wed Sep 25 20:02:45 2024 +0200

    fix(DB/Creature): SSC - Leotheras the blind - Adds are not chained (#20023)

commit 98ae32e1dad028bc47c27f947c8a9dbddc2cfd63
Author: Andrew <47818697+Nyeriah@users.noreply.github.com>
Date:   Wed Sep 25 12:00:57 2024 -0300

    fix(Scripts/Spells): Remove immunity application from Preparation buff (#20042)

commit 8aa631074226180989279eb28396928d75b48ac8
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Wed Sep 25 14:54:35 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 6e4a9bbb145620938e7d39bafaad9e6f0b34c279

commit 6e4a9bbb145620938e7d39bafaad9e6f0b34c279
Author: Jelle Meeus <sogladev@gmail.com>
Date:   Wed Sep 25 16:53:39 2024 +0200

    fix(Core/Unit): fix Dual Wield for more creatures, CREATURE_FLAG_EXTRA_USE_OFFHAND_ATTACK, creature disarm damage (#20015)

    * enable CREATURE_FLAG_EXTRA_USE_OFFHAND_ATTACK

    * sql set CREATURE_FLAG_EXTRA_USE_OFFHAND

    * use new HasOffHandWeaponForAttack instead of haveOffhandWeapon

    no longer requires m_CanDualwield set to use Offhand attack
    requires non-disarmed weapon in Offhand OR creature_flag_extra enabled

    Co-authored-by: Ovah <dreadkiller@gmx.de>
    Co-authored-by: Warlockbugs <warlockbugs@outlook.com>

    * Make shapeshift forms which dont override attack speed use weapon damage

    Co-authored-by: killerwife <killerwife@gmail.com>

    * SetEquipmentSlots turning off damage update when using template default

    Co-authored-by: killerwife <killerwife@gmail.com>

    * Setup DualWield & Damage On Equipment Updates, implement Set and GetVirtualItem

    Co-authored-by: Yatzii <47720837+Yatzii93@users.noreply.github.com>

    * creature disarm damage

    set disarm to reduce minmax damage by 50% instead of setting to 0

    Co-authored-by: Warlockbugs <warlockbugs@outlook.com>

    ---------

    Co-authored-by: Ovah <dreadkiller@gmx.de>
    Co-authored-by: Warlockbugs <warlockbugs@outlook.com>
    Co-authored-by: killerwife <killerwife@gmail.com>
    Co-authored-by: Yatzii <47720837+Yatzii93@users.noreply.github.com>

commit da3109809463ff4223038d2fc9d48610d67c9238
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Wed Sep 25 08:37:53 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 891bcd8e00946d9d071c4c82b1475c3f0fc33e0c

commit 891bcd8e00946d9d071c4c82b1475c3f0fc33e0c
Author: Walter Pagani <paganiwalter@gmail.com>
Date:   Wed Sep 25 05:36:56 2024 -0300

    refactor(SQL/Quest) Rescuing the Rescuers ID 11244 (#20030)

    * refactor(SQL/Quest) Rescuing the Rescuers ID 11244

    * fix range and max targets

    * Texts are added and the smart_script list is modified

    Co-authored-by: DEV Seaferer <91832265+edgardavid94@users.noreply.github.com>

    ---------

    Co-authored-by: DEV Seaferer <91832265+edgardavid94@users.noreply.github.com>

commit 69b5ee85f669d04fc692ee2377735dc418f7f0fc
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Wed Sep 25 08:34:40 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): a65be25fb94644af573c3fd6811f872674ad8b48

commit 54f7d3f166011f2c812cb51a283596142b976bd5
Author: Andrew <47818697+Nyeriah@users.noreply.github.com>
Date:   Wed Sep 25 05:34:35 2024 -0300

    fix(DB/Creature): Fix Illidan walking to waypoints instead of flying (#20035)

commit a65be25fb94644af573c3fd6811f872674ad8b48
Author: Andrew <47818697+Nyeriah@users.noreply.github.com>
Date:   Wed Sep 25 05:33:42 2024 -0300

    fix(Scripts/BlackTemple): Correct the door announcement to only annou… (#20036)

    fix(Scripts/BlackTemple): Correct the door announcement to only announce on the first bosses

commit dea3d44b46f6a885c196856e24046d9b490aa633
Author: Andrew <47818697+Nyeriah@users.noreply.github.com>
Date:   Tue Sep 24 15:17:22 2024 -0300

    fix(Core/Spells): Prevent aura application if the target is immune (#20031)

commit 97aaf8490cdde12d194558c4ee5acf037b5cd1b5
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Tue Sep 24 11:34:15 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): a7578e1cce4ec49375fd9298676a1d6263473666

commit a7578e1cce4ec49375fd9298676a1d6263473666
Author: Jelle Meeus <sogladev@gmail.com>
Date:   Tue Sep 24 13:33:21 2024 +0200

    fix(Scripts/TheEye): Kael'thas p5 transition, flight, MotionMaster:MoveTakeoff (#20005)

    Co-authored-by: killerwife <killerwife@gmail.com>

commit 7dd460581dc68582edda0f92cefa2cf3af6947c9
Author: Anton Popovichenko <anton.popovichenko@mendix.com>
Date:   Tue Sep 24 13:21:38 2024 +0200

    fix(Core/Loot): Fix crash for round robin loot mode when solving quest item for offline loot owner. (#20033)

commit 537bfb016e3931e137319e37be7577440a3c4047
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Tue Sep 24 05:30:26 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): d6c731f5c41a575529601363815467b0c7787416

commit d6c731f5c41a575529601363815467b0c7787416
Author: Jelle Meeus <sogladev@gmail.com>
Date:   Tue Sep 24 07:29:27 2024 +0200

    fix(DB/Event): Love is in the Air event missing Love Boat vehicles 1 (#19987)

    * add sql

    add boats

    remove vehicle_seat_addon stuff

    Co-authored-by: Dr-J <daniel.jarrott0@gmail.com>

    * update smartAI comments

    with Keira3

    * fix sql, make summoners invisible to players

    * change spellId 62011 to 'Romantic' 69352

    * Update rev_1725993194571320983.sql

    ---------

    Co-authored-by: Dr-J <daniel.jarrott0@gmail.com>
    Co-authored-by: sudlud <sudlud@users.noreply.github.com>

commit 62509abd1d55ceaa7f7451d19d90ee06620a2056
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Mon Sep 23 20:05:02 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): d0178bb735912ddabbfeda740ece32dff16c5c01

commit d0178bb735912ddabbfeda740ece32dff16c5c01
Author: Ed <zed.hyde@icloud.com>
Date:   Mon Sep 23 15:02:45 2024 -0500

    fix(DB/Creature Loot) - Update Eye and Hound Culuthas loot tables (#19706)

commit b67a409badf5d41300bf0c9948cf54c3d7292385
Author: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Date:   Mon Sep 23 20:58:00 2024 +0200

    refactor(Core/Database): improve abort messages for mysql errors (#20013)

    * refactor(Core/Database): improve abort messages for mysql errors

    * Update MySQLConnection.cpp

commit 0e9fb5946b9e7bc1ef3bc86ab50367a30b85d78d
Author: Andrew <47818697+Nyeriah@users.noreply.github.com>
Date:   Mon Sep 23 10:21:30 2024 -0300

    fix(Scripts/BlackTemple): Fix Fatal Attraction not being removed if t… (#20021)

    fix(Scripts/BlackTemple): Fix Fatal Attraction not being removed if targets move apart

commit 0858c8bbc0c30993ebe60fabe6e5d6d153fc0cf6
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Mon Sep 23 12:06:09 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 511235cca3ae8e658a018ca81745226a25b8b9be

commit 511235cca3ae8e658a018ca81745226a25b8b9be
Author: Grimgravy <sr.alansantos@hotmail.com>
Date:   Mon Sep 23 09:05:11 2024 -0300

    fix(Scripts/Quest): Fires Over Skettis (#19567)

    * fix(Scripts/Quest): Fires Over Skettis

    * Update spell_item.cpp

    ---------

commit e58c9cba422d06d76d11b835bd9f376fd525e1dd
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Mon Sep 23 10:31:03 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): aab91777601ba88813dc777bca144edd2242a4d4

commit aab91777601ba88813dc777bca144edd2242a4d4
Author: Ceikry <61421472+Ceikry@users.noreply.github.com>
Date:   Mon Sep 23 05:30:08 2024 -0500

    fix(DB/Quest) - Omit deprecated Pledge of Secrecy from Goblin and Gnome Engineering Questlines. (#19577)

    * Add level adjustments for Pledge of Secrecy 30->20

    * quest_template_addon -> quest_template

    * nvim lowercased everything

    * Update to remove the Pledge of Secrecy from the chain instead

    * Set RewardNextQuest for other horde breadcrumbs as well

commit 014602c849a3310bdae6feda8f6fd695878f1eb5
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Sun Sep 22 18:39:51 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 2625f8c57ca0decfa407deb2c036ffd155b6528e

commit 2625f8c57ca0decfa407deb2c036ffd155b6528e
Author: Maxlytrius <44470484+Maxlytrius@users.noreply.github.com>
Date:   Sun Sep 22 20:38:57 2024 +0200

    fix(DB/Item): Buycount adjustment for Star's Lament and Star's Tear (#18887)

    Create starstearlament.sql

commit 78cc255f43fd382df6629a315bf2486cf075ea8a
Author: Andrew <47818697+Nyeriah@users.noreply.github.com>
Date:   Sun Sep 22 14:52:19 2024 -0300

    fix(Core/Spells): Fix Fatal Attraction procing multiple times for eac… (#20014)

    fix(Core/Spells): Fix Fatal Attraction procing multiple times for each player nearby

commit f917b9657441d1a802b5637d6fb0945e9f67350a
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Sun Sep 22 12:44:37 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 8566e4ace3bd1f68c47781e19206b0f06d4ca3be

commit 8566e4ace3bd1f68c47781e19206b0f06d4ca3be
Author: chaosua <544218+chaosua@users.noreply.github.com>
Date:   Sun Sep 22 15:43:38 2024 +0300

    fix(DB/creature_text): (Pit of Saron, AzjolNerub) assign BroadcastTextId to creature_text (#18611)

    * (Instance:Pit of Saron) cleanup some duplicated txt lines and make use broadcast_text for localization support
    (Instance:AzjolNerub) added ruRU creature_text localization for Anub'arak intro (because BroadcastTextId unknown)

    * Update txt_line_fix.sql

    Remove excess line breaks

    * Rescued Alliance Slave connect heroic version template

    ---------

    Co-authored-by: Walter Pagani <paganiwalter@gmail.com>

commit b8fb0ae847da187f643ec17d8a0ae3a33229d01f
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Sun Sep 22 11:58:12 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 8dc0827b55668c293530fb48e0320d3af9cb1bed

commit 8dc0827b55668c293530fb48e0320d3af9cb1bed
Author: Mattia <mattia.wotlk@gmail.com>
Date:   Sun Sep 22 13:57:20 2024 +0200

    fix(DB/Creature): [Loot] Unyielding mobs low drop of Runecloth (#19910)

    * fix(DB/Creature): chances items changed

    * fix: edit items chances and set GroupId

commit bb0d292e1c2bb5619fbc3105e7cd919b45268748
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Sun Sep 22 07:38:46 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 44a10e7be86803bbe64cf65508d70d16e13a947d

commit 44a10e7be86803bbe64cf65508d70d16e13a947d
Author: Lukas <53310556+proxical@users.noreply.github.com>
Date:   Sun Sep 22 00:37:49 2024 -0700

    fix(DB/quest_offer_reward): C'Thun's Legacy turnin dialogue (#19130)

    * fix(DB/quest_offer_reward): C'Thun's Legacy turnin dialogue

    * fix(DB/quest_offer_reward): C'Thun's Legacy turnin dialogue

commit 02cd628f7bc38de4b1cef2cabd98f57249779f29
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Sun Sep 22 06:33:12 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 985410f18430e78e4b781ff8e11ff95f4ff11548

commit 985410f18430e78e4b781ff8e11ff95f4ff11548
Author: IntelligentQuantum <IntelligentQuantum@ProtonMail.Com>
Date:   Sun Sep 22 10:02:16 2024 +0330

    feat(Core/Items): Delete old item id from recovery item (#18332)

commit a452b25def8beb6c3bc87fc34acf2f678b0d10c2
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Sat Sep 21 22:28:36 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 1802de94f5bfbcb5a7833269caca5a6512237123

commit 7790b2258bbaaec66490f3c69f259ba4b3132162
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Sat Sep 21 18:28:11 2024 -0400

    feat(Core/Commands): Add debug command for applying a spell cooldown. (#20004)

    * Init.

    * Correct wrong query characters.

commit 1802de94f5bfbcb5a7833269caca5a6512237123
Author: RëXol <66186993+jorge990125@users.noreply.github.com>
Date:   Sat Sep 21 18:27:42 2024 -0400

    fix(DB/Creature) Ebon Blade Commander Equipment (#19846)

    * fix(DB/Creature) Ebon Blade Commander Equipment

    * fix(DB/Creature) Ebon Blade Commander Equipment

    * Update rev_1725226115559982400.sql

    * Update rev_1725226115559982400.sql

    ---------

commit d227ed91c20f147686f9735bfab1455c5f8966fc
Author: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Date:   Sat Sep 21 23:30:58 2024 +0200

    fix(Scripts/Commands): Prevent crash if you use doublequotes in go cr… (#20012)

    fix(Scripts/Commands): Prevent crash if you use doublequotes in go creature name

    * closes https://github.com/azerothcore/azerothcore-wotlk/issues/20010

commit cfd7bf416207f78028ed1532db3d2bfd44dab406
Author: Walter Pagani <paganiwalter@gmail.com>
Date:   Sat Sep 21 17:25:22 2024 -0300

    chore(Core/AllMapScript) Update structure (#19979)

    * fix(Core/AllMapScript) Update structure to use CALL_ENABLED_HOOKS

    * fatal error: no template named 'vector' in namespace 'std'

    * fix build

    Co-authored-by: Anton Popovichenko <anton.popovichenko@mendix.com>

    ---------

    Co-authored-by: Anton Popovichenko <anton.popovichenko@mendix.com>

commit b364e00238c43cd326fa54aa3e5c4cd8a8c9d770
Author: Jelle Meeus <sogladev@gmail.com>
Date:   Sat Sep 21 21:57:26 2024 +0200

    fix(Core/Object): do not add Object to Transport when summoned by a Vehicle (#19920)

commit 386aea03ee2e1421f2c6b14c694db182ff15ee0f
Author: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Date:   Sat Sep 21 19:34:31 2024 +0200

    chore(Core/Misc): Some cleanup (#19970)

    * remove weird blanks

    * update if

    * ) ) to ))

    * missed some ) )

    * now switch

    * .

commit 0ba59c0053ce06da8d1a7d32c2d8b6b12c1461a5
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Sat Sep 21 16:48:59 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 188b864d79b7c3f9382ad5c668ca39d67e14723d

commit 188b864d79b7c3f9382ad5c668ca39d67e14723d
Author: Jelle Meeus <sogladev@gmail.com>
Date:   Sat Sep 21 18:48:04 2024 +0200

    fix(DB/ArgentTournament): Stabled Campaign Warhorse missing error message (#19926)

    * fix lance requirement error msg

    * ;

commit 36a8653c8383288b776c59aba432e95cf8db45a5
Author: Anton Popovichenko <walkline.ua@gmail.com>
Date:   Sat Sep 21 16:37:55 2024 +0200

    fix(CI/macOS): Fix macOS CI dependency installation by updating macOS version. (#19997)

    * fix(CI/MacOS): Fix MacOS CI dependency installation.

    * Try to use macos 14 version

    * Remove brew cleanup and z3 dependency

    * Adjust readline lib discovery

    * Update macos supported version in SECURITY.md

commit 2e17b3250897ec1fdf40840865245919410d1735
Author: sudlud <sudlud@users.noreply.github.com>
Date:   Fri Sep 20 23:20:33 2024 +0200

    fix(apps/installer): fix Debian 12 build with mysql (#20003)

commit eda0df70f16317af1f5c861c81d7ab1502394d7b
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Fri Sep 20 21:19:22 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 1d899cf3c91c926ef5cc257b402a4c008a7a42ea

commit 1d899cf3c91c926ef5cc257b402a4c008a7a42ea
Author: Mattia <mattia.wotlk@gmail.com>
Date:   Fri Sep 20 23:18:29 2024 +0200

    Fix(db/creature) black temple   illidari assassin riposte ability missing (#19957)

    * fix(DB/Creature) Black Temple - Illidari Assassin: Riposte ability missing

    * fix(DB/Creature): Black Temple - Illidari Assassin: Riposte ability missing

    * Update 2024_09_13_00.sql

    * bitwise method

commit a196f7f28aa263dc7f9c532e15839f3b409fb68f
Author: skelUA <v.tkachenko.it@gmail.com>
Date:   Thu Sep 19 16:11:31 2024 +0300

    fix(Core/Loot)  fix bug with loot (#19882)

    Try to fix bug with loot

commit a0057b9e90c8e659dadb107010f224ba9c80e44a
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Thu Sep 19 08:49:56 2024 -0400

    fix(Core/Spells): Resolve a case of triggered spells prolonging combat. (#19991)

    * Revert "fix(Core/Spells): Revert triggered spell logic change. (#19983)"

    This reverts commit 3bb5ec779d217e8beedf7e42f8f8146312d2c1db.

    * Add aura effect check.

    Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

    * Add comment, use target instead of owner.

    * Adjust comment terminology.

    ---------

    Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>

commit dbde182ecdcf3ebe392943c2b34adae1fdf00110
Author: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Date:   Thu Sep 19 05:24:11 2024 +0200

    refactor(Deps/MySQL): Drop MariaDB and MySQL 5.7/8.1 and add MySQL 8.… (#19451)

commit 5af3d2d650e4615aff39ccd1adf2a0c71962f084
Author: Grimdhex <176165533+Grimdhex@users.noreply.github.com>
Date:   Wed Sep 18 11:52:16 2024 +0200

    fix(Scripts/BlackTemple): Flames of Azzinoth - Fix the charge logic (#19968)

    fix(Scripts/BlackTemple): fix the charge mechanic of Flames of Azzinoth

    * remove also a old duplicate check in a spell script

commit a35f0c4ef61f20dd88fffff4ac5864830c4c0daf
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Mon Sep 16 15:13:36 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 07c54fe8c7c0eb32ba51d52e3f6bbc34005239ab

commit 07c54fe8c7c0eb32ba51d52e3f6bbc34005239ab
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Mon Sep 16 11:12:26 2024 -0400

    fix(DB/Command): Add help values for various commands. (#19984)

    Init.

commit 3bb5ec779d217e8beedf7e42f8f8146312d2c1db
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Mon Sep 16 10:15:50 2024 -0400

    fix(Core/Spells): Revert triggered spell logic change. (#19983)

    Revert "fix(Core/Spells): Resolve a case of triggered spells prolonging comba…"

    This reverts commit edd7e10dfc7651ed2657a09d5411771831c8ec1e.

commit 64c9e4a0a4d54ea24dce09d0ea5e762d92227fea
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Sun Sep 15 21:16:14 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): e2353a1c9f58a143581ed326e9b0600f90c24aeb

commit e2353a1c9f58a143581ed326e9b0600f90c24aeb
Author: sudlud <sudlud@users.noreply.github.com>
Date:   Sun Sep 15 23:15:21 2024 +0200

    fix(Core/PlayerQuest): Introduce flag QUEST_SPECIAL_FLAGS_NO_LOREMAST… (#19962)

    * fix(Core/PlayerQuest): Introduce flag QUEST_SPECIAL_FLAGS_NO_LOREMASTER_COUNT

    - this allows flagging quests so that they will not count towards Loremaster achievement
    - update Corrupted Flower Quests in Felwood accordingly as a first use case

    * load Specialflags as uint32 from DB

commit 1df989f7807d9d0e8cfb52a8fe1001dc62b19598
Author: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Date:   Sun Sep 15 21:11:24 2024 +0200

    chore(Core/Achievement): cleanup offline achievement (#19976)

commit ee6e74eb3c7c02425dd564e22bbec6318f8bfc6a
Author: Andrew <47818697+Nyeriah@users.noreply.github.com>
Date:   Sun Sep 15 15:55:45 2024 -0300

    fix(Scripts/Commands): Fix level up achievements not being granted (#19969)

commit 04c8e85434daab642996146a243245ae73a7e858
Author: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Date:   Sun Sep 15 14:39:04 2024 +0200

    fix(Scripts/BT): correct illidari council enrage timer (#19975)

    * fix(Scripts/BT): correct illidari council enrage timer

    * wrong conversion from https://github.com/azerothcore/azerothcore-wotlk/commit/5ae1473e3064beb4adf666e33a38b6072639069a

    * redundant

commit d13b6963ea9962f03dfc358c286ed6c0f89051c8
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Sun Sep 15 10:49:06 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 8b16f7d243d54a19e6e7d5bf79bf44427fa84bfe

commit 8b16f7d243d54a19e6e7d5bf79bf44427fa84bfe
Author: Andrew <47818697+Nyeriah@users.noreply.github.com>
Date:   Sun Sep 15 07:48:11 2024 -0300

    fix(Scripts/BlackTemple): Implement emotes when opening Najentus and … (#19946)

    * fix(Scripts/BlackTemple): Implement emotes when opening Najentus and Den of Mortal Delights

    * only check if state is done

commit 99b39e50452e5a5f0362765860fc7c8280f251c0
Author: Andrew <47818697+Nyeriah@users.noreply.github.com>
Date:   Sun Sep 15 07:46:55 2024 -0300

    fix(Scripts/BlackTemple): Parasitic Shadowfiends should not target pl… (#19944)

    * fix(Scripts/BlackTemple): Parasitic Shadowfiends should not target players affected with debuff

    * Update boss_illidan.cpp

    * Update src/server/scripts/Outland/BlackTemple/boss_illidan.cpp

    * make it simple

commit 4fc60bbbdfb6e40b4e174333065c8365f639dfef
Author: Grimdhex <176165533+Grimdhex@users.noreply.github.com>
Date:   Sat Sep 14 13:39:03 2024 +0200

    fix(Core/Spells): Shadow demon - Allow to move while casting Paralyze (#19948)

    * fix(Scripts/BlackTemple): fix stationary shadow demons

    * optimization: use else if to stop the execution when a condition is reach

    * revert last changes and fix the spell to allow move while casting

    * .

commit bd40fef081daaa3b160b4609083599b42435eb79
Author: Grimdhex <176165533+Grimdhex@users.noreply.github.com>
Date:   Sat Sep 14 13:22:02 2024 +0200

    fix(Scripts/BlackTemple): fix blaze and flame bast casting for Flame of Azzinoth (#19967)

    fix(Scripts/Core): fix blaze and flame bast casting for Flame of Azzinoth

commit 8030ef4ba0ed7ee20b3647c58fe421f91c1e1274
Author: Andrew <47818697+Nyeriah@users.noreply.github.com>
Date:   Fri Sep 13 16:26:42 2024 -0300

    fix(Scripts/BlackTemple): Fix variable not being set to true when Ak… (#19947)

    fix(Scripts/BlackTemple): Fix variable not being set to false when Akama dies

commit 92ec34753fb31e109e7a23678e26185271df7734
Author: Anton Popovichenko <anton.popovichenko@mendix.com>
Date:   Fri Sep 13 19:23:05 2024 +0000

    fix(Core/Creature): Add support for CREATURE_FLAG_EXTRA_NO_PARRY_HAST… (#19927)

commit 8d7463c67007e58f41366ed4fc1dbc1e1290f465
Author: Jelle Meeus <sogladev@gmail.com>
Date:   Fri Sep 13 21:15:25 2024 +0200

    fix(Core/PlayerStorage): Equip OH, 2H, Titan's Grip weapon swapping  (#19884)

    titan's grip, unequip with full bags

commit d5263b0aee18b825ff7f46fb861094ff1836693e
Author: Knindza <knindzagxg@gmail.com>
Date:   Fri Sep 13 02:43:34 2024 +0200

    fix(Battlegrounds/AlteracValley): Adding missing Tower Archers (#18746)

    Updating Alterac

commit 4254827b2cadd253c694244b00c458122c96e9d3
Author: Grimdhex <176165533+Grimdhex@users.noreply.github.com>
Date:   Thu Sep 12 13:05:12 2024 +0200

    Revert "chore(Debug/Scripting): improve debug errors during the unloading scripts (#19643)" (#19951)

    This reverts commit db7183a5737646773a2f240f01b5891c1e4a4fe8.

    *wrongly use to catch sigsegv
    *null check isn't necessary: https://en.cppreference.com/w/cpp/memory/new/operator_delete

commit 20b443e011af4b6df32907c6297989d3a75b434a
Author: Grimdhex <176165533+Grimdhex@users.noreply.github.com>
Date:   Thu Sep 12 12:58:18 2024 +0200

    refactor(Scripts/TempestKeep): remove an dev residual from Kael'Thas revamp (#19950)

    refactor(Scripts/TempestKeep): remove an dev rest from my last PR with Keal'Thas

commit 5ae1473e3064beb4adf666e33a38b6072639069a
Author: Grimdhex <176165533+Grimdhex@users.noreply.github.com>
Date:   Thu Sep 12 11:11:56 2024 +0200

    fix(Scripts/BlackTemple): Ajust Judgment timers and pass all the script to std::chrono (#19945)

    fix(Scripts/BT): ajust Judgment timers and pass all the script to std::chrono

commit 321ac4a8c23ba5e006239fceb89eb8409135bed4
Author: Saqra1 <161769195+Saqra1@users.noreply.github.com>
Date:   Wed Sep 11 10:37:56 2024 -0500

    fix(Core/Spell): Summoning Portal position (#19705)

    * fix(Core/Spell): Summoning Portal position

    Summoning Portal is created in front of the caster but it is still too
    close to them. Move it away a bit.

    * Cleanup unused SpellInfo correction

    Spell 61994 was stopped being used for summons in favor of 23598 on:
    https://github.com/azerothcore/azerothcore-wotlk/commit/67010623a0670b507cbfd2ffc7e9cea7bcfca1a2

commit 4734582e5853acbeeadeeed45f19337374f2b3f1
Author: Saqra1 <161769195+Saqra1@users.noreply.github.com>
Date:   Wed Sep 11 09:53:07 2024 -0500

    fix(Core/Spell): Refreshment Table position (#19704)

    Refreshment Table game object should be created at the same position its
    Refreshment Portal was created.

commit edd7e10dfc7651ed2657a09d5411771831c8ec1e
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Wed Sep 11 10:52:15 2024 -0400

    fix(Core/Spells): Resolve a case of triggered spells prolonging combat. (#19819)

    * Init.

    * Expand trigger info check.

    * Enclose evaluation in parentheses.

    Maybe workflow will be happy?

commit d17c179c0345f93dfcc6ced3d22d4a00b6d6b4ce
Author: Stefano Borzì <stefanoborzi32@gmail.com>
Date:   Wed Sep 11 16:50:59 2024 +0200

    chore: remove unused hooks (#19919)

commit a971f373a0d697225a16b0b69a2d4ec2fe441d9d
Author: Stefano Borzì <stefanoborzi32@gmail.com>
Date:   Wed Sep 11 16:50:45 2024 +0200

    fix: default bgarenas visibility distance default value (#19938)

    * fix: default bgarenas visibility distance default value

    * chore: update worldserver.conf.dist

commit 56d2cc7b4c975448680dfb79ecae91dadcbad22c
Author: Grimdhex <176165533+Grimdhex@users.noreply.github.com>
Date:   Wed Sep 11 16:50:24 2024 +0200

    refactor(Cote/Unit): cleanup - part2 (#19821)

    * fix(Core/AI): remove an unused variable

    * Move variables at the end of each sections

    * reorder several methods

    * remove few inline defintions

    * few codestyle fixes

commit 30e77ae8807a5be29d763482d9a01065f040e388
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Wed Sep 11 14:20:11 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 0ac7ab03bb02c984a0917aefd763cf7ceebd371f

commit 06cf2cdf425b3ad1c84486564866a0e651129730
Author: Grimdhex <176165533+Grimdhex@users.noreply.github.com>
Date:   Wed Sep 11 16:19:51 2024 +0200

    fix(DB/SAI): Missings spells for few creatures in Blade's Edge Mountains (#19617)

    *timer estimations done on retail

commit 0ac7ab03bb02c984a0917aefd763cf7ceebd371f
Author: Mershl <mweires@googlemail.com>
Date:   Wed Sep 11 16:19:14 2024 +0200

    fix(Scripts/UBRS): increase Drakkisath's conflagrate interval from 10s..13s to 18s..25s, avoiding near infinite CC chains (#19806)

    fix(Scripts/UBRS): increase Drakkisath's conflagrate interval from 10..13s to 18s..25s, avoids infinite CC chains (conflagrate is a 10s CC)

commit f6e9bd51fd2c316347b34ff1c8184d1bf6de2426
Author: Stefano Borzì <stefanoborzi32@gmail.com>
Date:   Wed Sep 11 16:18:36 2024 +0200

    feat(ScriptMgr): add OnArenaStart hook (#19922)

commit c42b3ee258e734c4e93808e13dac397f284a7569
Author: Saqra1 <161769195+Saqra1@users.noreply.github.com>
Date:   Wed Sep 11 09:18:13 2024 -0500

    fix(Core/Pet): Control Infernal without enslave (#19784)

    Check SummonProperties Category(Control) too to decide the type of
    controls a Guardian should have.

    Don't enslave Warlock's Infernal

commit c1296d0b14f043bb133d04e3ea142070c18a35c4
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Wed Sep 11 08:44:17 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): eb0cfb79cc4e77dcdbfe42fb0fe7ae5d38f11d33

commit eb0cfb79cc4e77dcdbfe42fb0fe7ae5d38f11d33
Author: Mattia <mattia.wotlk@gmail.com>
Date:   Wed Sep 11 10:43:19 2024 +0200

    fix(DB/Creature) Black Temple - Shadowmoon Blood Mages dont use Blood… (#19812)

    * fix(DB/Creature) Black Temple - Shadowmoon Blood Mages dont use Blood Siphon ability

    * SQL query refactored

    * fix: backticks added

commit 00e35a201e0430f5f856eb16ca9125e9e26e53e6
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Wed Sep 11 02:25:32 2024 -0400

    fix(Core/AI): Reduce movement leash extension interval. (#19923)

    * Init.

    * Use GetGameTime() instead of system call.

    Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

    * Update leash timer if rooted.

    * Remove unnecessary checks, add extension for fanning.

    More parity with VMaNGOS implementation.

    ---------

    Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>

commit cbd74ae66365923ecaf5b493c8f9011912a5a46c
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Mon Sep 9 10:46:15 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): 56e03c495d15b75f3c9d35c322bbf3b1cdb826de

commit 56e03c495d15b75f3c9d35c322bbf3b1cdb826de
Author: Andrew <47818697+Nyeriah@users.noreply.github.com>
Date:   Mon Sep 9 07:45:23 2024 -0300

    fix(Scripts/BlackTemple): Shade of Akama should despawn on evade and Akama despawns before dying (#19894)

    * fix(Scripts/BlackTemple): Shade of Akama should despawn on evade and Akama despawns before dying

    * Create rev_1725714358950337100.sql

    * Update boss_shade_of_akama.cpp

commit fafd351e44b4556b9ceda4bfaa72c6e5f22c3f78
Author: 天鹿 <18535853+PkllonG@users.noreply.github.com>
Date:   Mon Sep 9 18:07:11 2024 +0800

    fix(Core/AI): creature leashing behavior. (#19897)

    * Update Unit.cpp

    * Update TargetedMovementGenerator.cpp

    * Update Unit.cpp

    * Update Unit.cpp

commit b47b5d2c519ec4909f0b59fabfa2a4319117b94e
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Sun Sep 8 20:44:09 2024 -0400

    fix(Core/AI): Initialize movement leash timer to five seconds. (#19898)

    Init.

    https: //github.com/vmangos/core/commit/c8510cbbd4dccbdac9900cc507910ef3ae0e6c43

    Co-authored-by: ratkosrb <35845488+ratkosrb@users.noreply.github.com>

commit cdc00b42bd86f07e1beb0a1327238a9163650ae3
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Sun Sep 8 14:49:28 2024 -0400

    fix(Core/AI): Add back leash update. (#19916)

    Init.

commit 0dd5c6e3b4703e93cf5c4015caf0e5d2f68d650f
Author: Stefano Borzì <stefanoborzi32@gmail.com>
Date:   Sun Sep 8 20:05:58 2024 +0200

    feat(Battlegrounds): make it compatible with custom arena type (#18679)

    * feat(Battlegrounds): make it compatible with custom arena type

    * fix(BattlegroundQueue.cpp): ignore bg for arena condition

    * feat(Scripting): add OnQueueUpdateValidity hook

    * fix: codestyle

commit cf95c1dfbdb252cfd18e32f8bdfef0da8ff01092
Author: kissingers <33601959+kissingers@users.noreply.github.com>
Date:   Sat Sep 7 21:39:31 2024 +0800

    fix(Scripts/ZulAman): Nalorakk sometimes not move when player close (#19893)

    * Fix nalorakk sometimes not move when player close

    * init _phase

    * Revert "Fix nalorakk sometimes not move when player close"

    This reverts commit b42cd4634bb4ffd225eaa7480428c6ba6b4817c6.

commit 7eee1345d0a7be4132e8baa06189a2eafc26b0fb
Author: Andrew <47818697+Nyeriah@users.noreply.github.com>
Date:   Sat Sep 7 07:05:43 2024 -0300

    fix(Scripts/BlackTemple): Gurtogg Bloodboil shouldnt cast bloodboil o… (#19886)

    fix(Scripts/BlackTemple): Gurtogg Bloodboil shouldnt cast bloodboil on phase 2 and shouldnt chase immune targets

commit dc4c874206ccd8d7266d8f034faa00e0acda0732
Author: 天鹿 <18535853+PkllonG@users.noreply.github.com>
Date:   Sat Sep 7 18:05:18 2024 +0800

    fix(Scripts/BlackTemple): blade_of_azzinoth...and Possible crash (#19891)

    * Update boss_illidan.cpp

    * Update boss_illidan.cpp

commit e7448f29862e67b25bffbbd8a011c4f0d6b53cb0
Author: 天鹿 <18535853+PkllonG@users.noreply.github.com>
Date:   Sat Sep 7 12:03:41 2024 +0800

    fix(Scripts/Commands): .gps formatting transport offset (#19890)

    * Update cs_misc.cpp

    * Update PlayerUpdates.cpp

commit dd2167b00b138e97ff71cf04b54e2de147bb7089
Author: 天鹿 <18535853+PkllonG@users.noreply.github.com>
Date:   Sat Sep 7 12:03:19 2024 +0800

    fix(Core/AI): Creature SetInCombatState Leashing. (#19889)

    * Update Unit.cpp

    * Update pit_of_saron.cpp

    * Update Unit.cpp

commit 78d40e4078e131677327420c7151876ebdafff89
Author: Andrew <47818697+Nyeriah@users.noreply.github.com>
Date:   Fri Sep 6 20:41:36 2024 -0300

    fix(Scripts/BlackTemple): Remove Shear from Illidan following wrath p… (#19881)

    fix(Scripts/BlackTemple): Remove Shear from Illidan following wrath patch changes

commit 89b08dd5dc112be3defbfebd943369dd8ffb60b7
Author: Jelle Meeus <sogladev@gmail.com>
Date:   Sat Sep 7 00:43:12 2024 +0200

    fix(Scripts/Commands): .gps formatting transport offset (#19888)

    fix transport offset

commit 632d7f5f9ec1b44c3288168952a68533a6791686
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Fri Sep 6 16:02:53 2024 -0400

    fix(Core/Unit): Add leash extension with damage dealt. (#19880)

    Init.

commit 6e5cd04591f3e5ef9034a49bcb45562744dfbbaa
Author: Ben Carter <110695027+ben-of-codecraft@users.noreply.github.com>
Date:   Fri Sep 6 11:37:00 2024 -0400

    fix(docker): Modules SQL do not get updated or populated for docker set ups (#19870)

    * Added modules to dbimport so sql cab accessed by loader

    * updated dbimport tools config option to enable module sql to be updated and populated

    * Updated casting around GetOption and changed default to all

commit 9dae87595dc2f0f14d06ce7984250535630f54df
Author: 天鹿 <18535853+PkllonG@users.noreply.github.com>
Date:   Thu Sep 5 22:56:17 2024 +0800

    fix(Core/Creature): Creature Scale. (#19722)

    Update Creature.cpp

commit d1f77ae60caf93e9bf3180cad8c9a683169b1f70
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Thu Sep 5 13:17:25 2024 +0000

    chore(DB): import pending files

    Referenced commit(s): fa490c21e9262152c59c0ac81f9e8a500f047582

commit fa490c21e9262152c59c0ac81f9e8a500f047582
Author: Gultask <100873791+Gultask@users.noreply.github.com>
Date:   Thu Sep 5 10:16:26 2024 -0300

    fix(Scripts/BlackTemple): Rewrite Illidan Stormrage Fight (#19574)

    * Create rev_1722993051676997100.sql

    * akama done

    * Update boss_illidan.cpp

    * maiev

    * sssssssssllllll

    * blerg

    im sick irl

    * door handel

    * Update boss_illidan.cpp

    * minions

    * Update boss_illidan.cpp

    * unneeded

    * Update boss_illidan.cpp

    * Update boss_illidan.cpp

    * meow

    * Update boss_illidan.cpp

    * Update boss_illidan.cpp

    * Update boss_illidan.cpp

    * demon_phase

    missing:
    tear of azzinoth
    trap + frenzy
    flying phase wipe + animation

    * akama's ending not working still

    * Update boss_illidan.cpp

    * Update boss_illidan.cpp

    flying animation
    akama isn't returning to complete the ending

    * akama ending fixed

    * cleanup

    * Update boss_illidan.cpp

    * Update boss_illidan.cpp

commit 19264bea0bba49bdff4c8ec7e9918092fe656319
Author: 天鹿 <18535853+PkllonG@users.noreply.github.com>
Date:   Thu Sep 5 17:54:44 2024 +0800

    Fix(Core/Misc): Acore::StringFormat to fmt format (#19867)

    Update MMapMgr.cpp

commit e5e514bbbedd0bab114177fffc8b632e667dd751
Author: Stefano Borzì <stefanoborzi32@gmail.com>
Date:   Wed Sep 4 15:33:38 2024 +0200

    feat(Core/Scripting): add OnBeforeArenaCheckWinConditions hook for mod-arena-replay compatibility (#19856)

commit bf18b9bdfb26fd94cd4dfbd6a911ebae5db98569
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Tue Sep 3 15:08:56 2024 -0400

    fix(Core/AI): Improve creature leashing behavior. (#19751)

    * Init.

    https: //github.com/vmangos/core/commit/7d2f1e2923734ea1b983eeaa0208cfd158d4af02
    Co-Authored-By: ratkosrb <35845488+ratkosrb@users.noreply.github.com>

    * Hackfix for pets.

    * Whoops.

    * Correct evade uses.

    * Conflict.

    * Actually fix grace timer.

    * Add visibility distance check.

    Creatures should always fail combat checks in the open world if they're outside of visibility distance, might not be the case for worldbosses.

    ---------

    Co-authored-by: ratkosrb <35845488+ratkosrb@users.noreply.github.com>

commit 1edac37ac37dfbfdc5f4d1ba36140dc077f06236
Author: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Date:   Tue Sep 3 13:41:31 20…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CORE Related to the core DB related to the SQL database Documentation file-cpp Used to trigger the matrix build Ready to be Reviewed Requires WIKI Update Wiki sources will need to be updated after merging this PR. run-build Used to trigger the windows/mac/docker and matrix builds To Be Merged - Later This PR promotes delicate changes and has been flagged to be merged after the holiday seasons.
Projects
None yet
Development

Successfully merging this pull request may close these issues.