Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Devour Magic #98

Closed
wants to merge 2 commits into from
Closed

Fix Devour Magic #98

wants to merge 2 commits into from

Conversation

laashaa
Copy link
Contributor

@laashaa laashaa commented Aug 17, 2016

Issues addressed: Closes #67

Tests performed: compiled on ubuntu 14.04 without errors, Tested ingame.

@@ -130,6 +130,7 @@ enum SpellScriptHookType
SPELL_SCRIPT_HOOK_EFFECT_LAUNCH_TARGET,
SPELL_SCRIPT_HOOK_EFFECT_HIT,
SPELL_SCRIPT_HOOK_EFFECT_HIT_TARGET,
SPELL_SCRIPT_HOOK_EFFECT_SUCCESSFUL_DISPEL,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code indentation

@FrancescoBorzi
Copy link
Member

@justdothings thanks for this PR, can you fix all code indentation problems that I pointed? set tab = 4 spaces in your editor

thanks

@ghost
Copy link

ghost commented Aug 17, 2016

What is it? As if this is not the complete code. You just cut out the part about this and removed the spell work itself.

@laashaa
Copy link
Contributor Author

laashaa commented Aug 17, 2016

@DevRival no it works well im using on my server, 50+ online

@ghost
Copy link

ghost commented Aug 17, 2016

You see the code? What have you done? You have removed the spell work and made ​​only a new hook.

@laashaa
Copy link
Contributor Author

laashaa commented Aug 17, 2016

@DevRival come on my server and test it :) you can close pr if you don't like.

@laashaa laashaa closed this Aug 17, 2016
@mik1893
Copy link
Contributor

mik1893 commented Aug 19, 2016

this is nonsense as @DevRival said...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants