Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MySQL types (C++) from TC #191

Merged
merged 4 commits into from
Mar 5, 2020
Merged

Add MySQL types (C++) from TC #191

merged 4 commits into from
Mar 5, 2020

Conversation

Kitzunu
Copy link
Member

@Kitzunu Kitzunu commented Feb 27, 2020

closes #89

Rough import from TC if something needs changing just tell me.

@Kitzunu Kitzunu changed the title Yehonal <3 Add MySQL types (C++) from TC Feb 27, 2020
docs/MySQLtypesC++.md Outdated Show resolved Hide resolved
@BarbzYHOOL
Copy link
Member

thank you!!

1 similar comment
@BarbzYHOOL
Copy link
Member

thank you!!

Co-Authored-By: Barbz <BarbzYHOOL@users.noreply.github.com>
@Kitzunu Kitzunu requested a review from BarbzYHOOL March 3, 2020 15:41
@BarbzYHOOL
Copy link
Member

why call it "mysql types (c++)"

i don't get how mysql and c++ go along together?

@FrancescoBorzi
Copy link
Contributor

because there are examples on how the MySQL types map to C++, e.g.:

int32 val = fields[n].GetInt32();

@BarbzYHOOL
Copy link
Member

Ok so let's merge ? @Helias @FrancescoBorzi

@FrancescoBorzi
Copy link
Contributor

ok for me

@BarbzYHOOL BarbzYHOOL merged commit 548ed70 into azerothcore:master Mar 5, 2020
@BarbzYHOOL
Copy link
Member

ty kitzunu

@Kitzunu
Copy link
Member Author

Kitzunu commented Mar 5, 2020

I will look into the issue it made, didnt see it when I tested initially

@BarbzYHOOL
Copy link
Member

which issue?

@BarbzYHOOL
Copy link
Member

@Yehonal please, have a look maybe it's a bug in the wiki, and that's why we need a way to preview the changes in the wiki :'(

@BarbzYHOOL BarbzYHOOL mentioned this pull request Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing page for Datatype correlation
3 participants