-
Notifications
You must be signed in to change notification settings - Fork 0
fix: update ruff #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update ruff #108
Conversation
Summary of ChangesHello @b-long, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing code quality and adherence to modern Python practices by updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates ruff and applies several linting fixes, primarily related to using pathlib for file operations and marking unused variables. The changes are a good step towards modernizing the codebase and improving consistency. I've provided several suggestions to further simplify file I/O using pathlib's helper methods like read_text() and write_bytes(), which align with the direction of this PR. I also have a concern about removing sdk.close() from the README.md example, as it might encourage bad practices.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the ruff linter and applies its automated fixes across the codebase. The changes primarily involve using pathlib for file operations, removing unused imports, and marking unused variables, which improves code consistency and quality. I have one suggestion regarding the README.md file, where an important sdk.close() call was removed from an example. Restoring this call is crucial to demonstrate correct resource management.
Update ruff, require "PTH" (flake8-use-pathlib) and fix PTH violations. Also updated some README content.