-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add Python 3.14 support & fix pre-commit #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @b-long, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces compatibility for Python 3.14, allowing the project to officially support the latest stable Python release. Additionally, it addresses a minor configuration issue within the pre-commit hooks to ensure proper linting and commit message validation continue to operate smoothly. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Python 3.14 support to the project and fixes a pre-commit configuration issue. The changes enable testing and declare compatibility with Python 3.14, while correcting the argument format for the conventional-pre-commit hook.
- Added Python 3.14 to supported versions in project metadata and CI workflows
- Fixed pre-commit configuration by removing the
--scopes=flag and passing scope values directly as arguments
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Declares Python 3.14 classifier for package metadata |
| .pre-commit-config.yaml | Corrects conventional-pre-commit hook argument syntax |
| .github/workflows/test-suite.yaml | Adds Python 3.14 to the test matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for Python 3.14 and attempts to fix the pre-commit configuration. The addition of the Python 3.14 classifier in pyproject.toml is correct. However, the change in .pre-commit-config.yaml for the conventional-pre-commit hook is incorrect. It mistakenly configures allowed commit types instead of scopes. I have provided a critical review comment with a suggested fix to correctly configure the allowed scopes for your commit messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for Python 3.14 and attempts to fix the pre-commit configuration. While the addition of Python 3.14 support in pyproject.toml is correct, the change to .pre-commit-config.yaml for the conventional-pre-commit hook is not quite right. I've provided a suggestion to correctly configure the arguments for the hook to ensure it validates commit message types as intended.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces two key changes: adding support for Python 3.14 by updating the classifiers in pyproject.toml, and fixing the conventional-pre-commit hook configuration in .pre-commit-config.yaml. The argument format for scopes has been corrected to ensure it's parsed properly. Both changes are appropriate and well-implemented. The code looks good.
d9f4f77 to
f5cf3ca
Compare
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for Python 3.14 by updating the pyproject.toml classifiers and fixes an issue with the pre-commit configuration for conventional commits. The changes are generally good. I've added one suggestion to ensure that Python 3.14 is also added to the CI test matrix to validate compatibility, which is crucial for claiming support for a new Python version.
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", | ||
| "Programming Language :: Python :: 3.13", | ||
| "Programming Language :: Python :: 3.14", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding Python 3.14 to the classifiers correctly declares support for this new version. However, to guarantee compatibility, it's crucial to also add Python 3.14 to the CI test matrix. Without automated tests running on Python 3.14, we cannot be confident that the library functions as expected on this version.
feat: add Python 3.14 support & fix pre-commit