New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0] Remove stage 4 plugins from stage 3 preset #5126

Merged
merged 4 commits into from Jan 20, 2017

Conversation

Projects
None yet
7 participants
@varemenos
Contributor

varemenos commented Jan 15, 2017

Q A
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Deprecations?
Spec Compliancy?
Tests Added/Pass?
Fixed Tickets Fixes #5117
License MIT
Doc PR
Dependency Changes

This PR removes the trailing function commas, exponentiation operator and async function to es2015 generator transformations from babel's stage-3 preset plugin since all 3 of them are now stage 4/finished proposals.

varemenos added some commits Jan 15, 2017

remove trailing function commas from stage-3 preset (#5117)
trailing function commas is now a finished proposal and was moved to stage 4 (https://github.com/tc39/proposal-trailing-function-commas)
remove the exponentiation operator from stage-3 preset (#5117)
exponentiation-operator is now a finished proposal and was moved to stage 4 (https://github.com/rwaldron/exponentiation-operator)
remove async function to es2015 generator from stage-3 preset (#5117)
async functions is now a finished proposal and was moved to stage 4 (https://github.com/tc39/ecmascript-asyncawait)
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jan 15, 2017

@varemenos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo and @jacobrask to be potential reviewers.

@varemenos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo and @jacobrask to be potential reviewers.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jan 15, 2017

Current coverage is 89.20% (diff: 100%)

No coverage report found for 7.0 at b978996.

Powered by Codecov. Last update b978996...1282730

codecov-io commented Jan 15, 2017

Current coverage is 89.20% (diff: 100%)

No coverage report found for 7.0 at b978996.

Powered by Codecov. Last update b978996...1282730

@xtuc

xtuc approved these changes Jan 15, 2017

@danez danez added this to the Babel 7 milestone Jan 15, 2017

@loganfsmyth loganfsmyth changed the title from Remove stage 4 plugins from stage 3 preset to [7.0] Remove stage 4 plugins from stage 3 preset Jan 15, 2017

@loganfsmyth loganfsmyth changed the base branch from master to 7.0 Jan 15, 2017

@loganfsmyth

This comment has been minimized.

Show comment
Hide comment
@loganfsmyth

loganfsmyth Jan 15, 2017

Member

FYI I rebased your PR onto our 7.0 branch in the github UI since this is breaking.

Member

loganfsmyth commented Jan 15, 2017

FYI I rebased your PR onto our 7.0 branch in the github UI since this is breaking.

@hzoo hzoo merged commit 12886ea into babel:7.0 Jan 20, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Jan 20, 2017

Member

Thanks @varemenos!!

Member

hzoo commented Jan 20, 2017

Thanks @varemenos!!

@varemenos varemenos deleted the varemenos:remove-stage-4-plugins-from-stage-3-preset branch Jan 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment