Remove Stage presets #8293

hzoo · 2018-07-09T20:47:20Z

Sad times 😭, but for the best? Fun because I added them back in originally 😛

Deprecated use of these presets in the last release (beta.52), for an initial warning.
Throw error with the use in next beta, show the correct config to use otherwise. Optional: Add autofix with Change Stage X presets to the individual plugins? babel-upgrade#67
Update the readme to explain better.
copy old code to babel-archive: babel/babel-archive@c36fc7d
test the Stage options in the REPL works?
Check the readme and src/index.js of the Stages https://github.com/babel/babel/blob/b2f42e8cb4889e6fbff97e12d3db3dd0be0bfbd5/packages/babel-preset-stage-0/README.md
writing a post to explain the changes

We should prob make a better guide on making your own preset

babel-bot · 2018-07-09T20:51:37Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8672/

chicoxyzzy

Overall this LGTM. Not sure about readmes, where I think we can add list of plugins down to current preset instead of higher stage preset + list of plugins for current preset.

hzoo · 2018-07-11T12:55:22Z

I think we can add list of plugins down to current preset instead of higher stage preset + list of plugins for current preset.

Yeah I was thinking that too.

chicoxyzzy · 2018-07-11T17:21:14Z

packages/babel-preset-stage-0/README.md

+
+---
+
+If you want the same configuration as before, you can use this configuration, although keep in mind that Stage 0 contains Stage 1 which is also deprecated.


This lines in readmes should be reworded somehow (also probably same for deprecation messages) =)

nicolo-ribaudo · 2018-07-12T21:19:30Z

packages/babel-standalone/src/preset-stage-3.js

+
+  if (opts !== undefined) {
+    if (opts.loose !== undefined) loose = opts.loose;
+  }


Nit: We can just use { loose = false } = {} instead of the opts parameter to avoid lines 7-11.

nicolo-ribaudo · 2018-07-12T21:19:54Z

packages/babel-standalone/src/preset-stage-2.js

+  const { loose = false, useBuiltIns = false, decoratorsLegacy = false } = opts;
+
+  return {
+    presets: [[presetStage3, { loose, useBuiltIns }]],


useBuiltIns can be removed, since it was only used by object-rest-spread.
It can also be removed in the stage-0 and stage-1 presets.

existentialism · 2018-07-12T21:47:35Z

packages/babel-preset-stage-0/src/index.js

-        proposals.join(", "),
-    );
-  }
+We recommend that make your own presets to use across projects for


Nit:

We recommend that you make your own presets...

nicolo-ribaudo

Also, you can remove { "loose": false } everywhere since it is the default.

loganfsmyth · 2018-07-15T01:09:05Z

packages/babel-preset-stage-0/README.md

 ```

-or using yarn:
+We recommend that make your own presets to use across projects for


Is this something we want to recommend? I'm not sure how I feel about this being in here as a recommendation for good.

Hmm yeah, I guess it shouldn't have to be a recommendation but more that people tend to forget you can make your own

Yeah, I'm fine if we want to say that creating a custom preset is an option, I think the wording right now just makes it sound like what we're expecting everyone to do, which isn't good.

Maybe something like

If you're using the same configuration across many separate projects, keep in mind that you can also create your own custom presets with whichever plugins and presets you're looking to use.

loganfsmyth · 2018-07-15T01:11:01Z

packages/babel-standalone/src/preset-es2015.js

@@ -35,19 +34,6 @@ export default (_, opts) => {
    if (opts.spec !== undefined) spec = opts.spec;
  }

-  if (typeof loose !== "boolean") {


What happened with this?

Oh hmm I think I ended up removing this since it's for standalone and it would be a UI option in the repl, but we can add it back too.

Yeah I was just confused because this is only the validation logic, not the options themselves.

loganfsmyth · 2018-07-15T01:18:55Z

packages/babel-preset-stage-0/README.md

+module.exports = function() {
+  return {
+    plugins: [
+      // ...


If we want this example, we should probably also clarify that doing require() on these is recommended. If they just do "@babel/plugin-proposal-function-bind" as a string, the plugins will probably not be found properly. I'd actually thought about making core error when that happens, but I haven't yet. Maybe I should?

This Pull Request renovates the package group "babel monorepo". - [@babel/preset-typescript](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54` - [@babel/preset-env](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54` - [@babel/plugin-transform-react-jsx](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54` - [@babel/plugin-proposal-class-properties](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54` - [@babel/core](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54` # Release Notes <details> <summary>babel/babel</summary> ### [`v7.0.0-beta.54`](https://github.com/babel/babel/releases/v7.0.0-beta.54) [Compare Source](babel/babel@v7.0.0-beta.53...v7.0.0-beta.54) #### v7.0.0-beta.54 (2018-07-16) > Regarding `babel/babel#8184, we aren't using `micromatch` for paths, just basic `*/**` substitution now. For anything more complicated we will recommend using a regex/.js config. > There was a bug in the stage presets (`babel/babel#8307), so we just removed the requirements for setting options in the meantime for ease of use. We are removing the Stage presets next anyway. `babel/babel#8293 ##### 💥 Breaking Change * `babel-core`, `babel-register`, `babel-traverse` * [#8327](`babel/babel#8327) Treat string ignore/only/test/include/exclude values as paths with only basic pattern matching. ([@loganfsmyth]) ##### 🐛 Bug Fix * `babel-core`, `babel-register`, `babel-traverse` * [#8327](`babel/babel#8327) Treat string ignore/only/test/include/exclude values as paths with only basic pattern matching. ([@loganfsmyth]) * `babel-preset-stage-0`, `babel-preset-stage-1` * [#8317](`babel/babel#8317) Fix stage-0/1 import of pipeline proposals array. ([@mAAdhaTTah]) * `babel-helper-module-transforms`, `babel-plugin-transform-modules-commonjs` * [#8316](`babel/babel#8316) Ensure that the wildcard interop is used with re-export + default.. ([@loganfsmyth]) * `babel-core` * [#8315](`babel/babel#8315) Remove option-filtering options from the final options results.. ([@loganfsmyth]) ##### 📝 Documentation * [#8320](`babel/babel#8320) Add link to audio version of song. ([@rugk]) ##### Committers: 4 - Daniel Tschinder ([danez]) - James DiGioia ([mAAdhaTTah]) - Logan Smyth ([loganfsmyth]) - rugk ([rugk]) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).

…irely, fix fixtures

xtuc · 2018-07-23T05:47:24Z

packages/babel-preset-stage-0/README.md

+```json
+{
+  "plugins": [
+    // Stage 0


Comments in JSON are not valid, could we remove them? (because user will need to) or can we switch to js?

Following READMEs too

.babelrc uses Json5, so comments work.

xtuc · 2018-07-23T05:52:02Z

scripts/generators/readmes.js

@@ -66,6 +66,7 @@ yarn add ${name} --dev

 packages
  .filter(x => x !== "README.md") // ignore root readme
+  .filter(x => x.indexOf("babel-preset-stage-") === -1) // ignore stages


This seems obscure to me. I would prefer using a rejection list which explicitly exclude: ['babel-preset-stage-0', 'babel-preset-stage-1', 'babel-preset-stage-2']

That's fine but just FYI this is a temporary change because we are going to not publish any more of the package anyway so I would remove this code the next release after.

xtuc · 2018-07-23T05:53:35Z

Could we also remove the stage plugins from the REPL? I think that the possibility of loading plugins from npm would suffice? IRC parser flags were not pushed, we might need to fix that first.

hzoo · 2018-07-23T12:04:10Z

Removing from repl isn't part of this PR since I left it in babel-standalone so we are leaving it for now? Yeah would like to figure out how we want to go about doing that. Don't have a good solution and is simple to do atm. I think the use case for the repl is different since it's fine to just allow any syntax mostly and we can easily keep it up to date since it's just for testing

mAAdhaTTah · 2018-07-23T12:05:38Z

It might be confusing for people to find presets on the repl that don't exist / shouldn't be used anymore.

hzoo · 2018-07-23T12:15:15Z

I think that's fine, this is only for v7 while we are figuring out what to do there. We have the same problem with loose mode, plugin options.

Ref babel/babel#8293

hzoo requested review from existentialism and loganfsmyth July 9, 2018 20:47

hzoo added this to the Babel 7 RC milestone Jul 9, 2018

hzoo force-pushed the rm-stage-presets branch from 03c03ff to b2f42e8 Compare July 9, 2018 21:25

hzoo requested a review from nicolo-ribaudo July 9, 2018 21:26

mAAdhaTTah mentioned this pull request Jul 10, 2018

"The pipeline operator requires a proposal set error" during compile #8276

Closed

hzoo added the PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release label Jul 10, 2018

This was referenced Jul 10, 2018

Should we remove Stage 0 - 2 presets, leaving only stage 3? #7770

Closed

Add transformMode option to env preset #8296

Closed

hzoo requested review from xtuc and Andarist July 10, 2018 19:27

chicoxyzzy reviewed Jul 11, 2018

View reviewed changes

hzoo force-pushed the rm-stage-presets branch from b2f42e8 to a509803 Compare July 11, 2018 16:51

chicoxyzzy reviewed Jul 11, 2018

View reviewed changes

rtsao approved these changes Jul 11, 2018

View reviewed changes

chicoxyzzy approved these changes Jul 11, 2018

View reviewed changes

hzoo mentioned this pull request Jul 12, 2018

Cannot read property 'join' of undefined ( preset-stage-0 ) #8307

Closed

nicolo-ribaudo reviewed Jul 12, 2018

View reviewed changes

existentialism reviewed Jul 12, 2018

View reviewed changes

nicolo-ribaudo reviewed Jul 12, 2018

View reviewed changes

loganfsmyth reviewed Jul 15, 2018

View reviewed changes

loganfsmyth mentioned this pull request Jul 15, 2018

Fix stage-0/1 import of pipeline proposals array #8317

Merged

loganfsmyth reviewed Jul 15, 2018

View reviewed changes

hzoo force-pushed the rm-stage-presets branch from 479d0b5 to 64673ae Compare July 16, 2018 17:17

inline stage presets into standalone, remove yearly preset folder ent…

1ce6867

…irely, fix fixtures

hzoo added 7 commits July 21, 2018 08:45

Breaking: throw error with using Stage presets

31b1b97

update readme

cadf86c

[skip ci]

cf32b08

update readmes [skip ci]

d8e4236

remove the plugins already in preset-env

468185d

modify message [skip ci]

cf70358

fix messages

48fe688

hzoo force-pushed the rm-stage-presets branch from 64673ae to 48fe688 Compare July 21, 2018 12:45

hzoo added the Priority: High label Jul 21, 2018

xtuc reviewed Jul 23, 2018

View reviewed changes

hzoo mentioned this pull request Jul 23, 2018

[Babel 6] [preset-env]: Include stage 4 object rest spread by default #8370

Closed

hzoo merged commit c70a32a into master Jul 24, 2018

xtuc deleted the rm-stage-presets branch July 24, 2018 05:28

nicolo-ribaudo mentioned this pull request Jul 24, 2018

Remove stage presets babel/babel-upgrade#69

Merged

hzoo pushed a commit to babel/babel-upgrade that referenced this pull request Jul 25, 2018

Remove stage presets (#69)

38f5e86

Ref babel/babel#8293

lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove Stage presets #8293

Remove Stage presets #8293

hzoo commented Jul 9, 2018 •

edited

babel-bot commented Jul 9, 2018 •

edited

chicoxyzzy left a comment

hzoo commented Jul 11, 2018

chicoxyzzy Jul 11, 2018

nicolo-ribaudo Jul 12, 2018

nicolo-ribaudo Jul 12, 2018

existentialism Jul 12, 2018

nicolo-ribaudo left a comment

loganfsmyth Jul 15, 2018

hzoo Jul 15, 2018

loganfsmyth Jul 15, 2018

loganfsmyth Jul 15, 2018

hzoo Jul 15, 2018

loganfsmyth Jul 15, 2018

loganfsmyth Jul 15, 2018

xtuc Jul 23, 2018 •

edited

nicolo-ribaudo Jul 23, 2018

xtuc Jul 23, 2018

hzoo Jul 23, 2018

xtuc commented Jul 23, 2018

hzoo commented Jul 23, 2018

mAAdhaTTah commented Jul 23, 2018

hzoo commented Jul 23, 2018 •

edited


		---

		If you want the same configuration as before, you can use this configuration, although keep in mind that Stage 0 contains Stage 1 which is also deprecated.

Remove Stage presets #8293

Remove Stage presets #8293

Conversation

hzoo commented Jul 9, 2018 • edited

babel-bot commented Jul 9, 2018 • edited

chicoxyzzy left a comment

Choose a reason for hiding this comment

hzoo commented Jul 11, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xtuc Jul 23, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xtuc commented Jul 23, 2018

hzoo commented Jul 23, 2018

mAAdhaTTah commented Jul 23, 2018

hzoo commented Jul 23, 2018 • edited

hzoo commented Jul 9, 2018 •

edited

babel-bot commented Jul 9, 2018 •

edited

xtuc Jul 23, 2018 •

edited

hzoo commented Jul 23, 2018 •

edited