Fix max_length overflow on 32 bits integer platform.

nicolasdespres · nicolasdespres · commit 101f79647108 · 2025-03-23T21:06:16.000+01:00
JS has 32 bits integer. When multiplying by 8 it overflows
and the length becomes negative.
diff --git a/bitv.ml b/bitv.ml
@@ -36,7 +36,11 @@ let length v = v.length
 
 let[@inline] equal (v1: t) (v2: t) = v1 = v2
 
-let max_length = Sys.max_string_length * 8
+let max_length =
+  let n = Sys.max_string_length * 8 in
+  (* We use 64 bits because it can overflow on architecture
+     with 32 bits integer like JS for instance. *)
+  if n < 0 then max_int else n
 
 let exceeds_max_length n =
   let s = n / 8 in
