-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Billa Onlinestore #165
Conversation
This is work in progress, I would like first to check with @badlogic if direction makes sense. -> with this method I get 15811 products via the API. Open:
|
Ok, when I remove duplicates there are products in multiple categories: New Count is 11842 |
Looked into it last night. I think it's better to hardcode the category slugs (they don't change for the top level) instead of going through the letters of the alphabet. Then just fetch all products per category through the respective api and deduplicate. |
I added the category list I was able to find so far with slugs to |
Komme auf nur 11993 Produkte |
I adapted the product structure, but I have difficulties to standardise the quantity amounts. |
Ich hab das auch grad mit der einem Powershell-Script nachvollzogen, ich komme auch genau auf 11993 Produkte, die Anzahl in den Kategorien passt nicht zu der Anzahl die man in der tatsächlichen Kategorie rausbekommt. |
That's about as many as we have from the old data (which also contains
unavailable products since 2017). Some products are in multiple categories,
which is why they need to be deduplicated.
…On Tue, Oct 17, 2023, 8:23 PM Harald Reisinger ***@***.***> wrote:
Ich hab das auch grad mit der einem Powershell-Script nachvollzogen, ich
komme auch genau auf 11993 Produkte, die Anzahl in den Kategorien passt
nicht zu der Anzahl die man in der tatsächlichen Kategorie rausbekommt.
—
Reply to this email directly, view it on GitHub
<#165 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD5QBHN464FATWE4XZRTKDX73EIJAVCNFSM6AAAAAA6DNEDJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRWHEZTQMZRG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I will have a look at the quantities. |
I'm looking into ensuring the new data is consistent with the old one, so we don't destroy the historic pricing data. |
Made some progress (and a separate PR #166). Data is not consistent yet (and the prices seem to be wrong). I'm on it. |
@mhochsteger @flobauer I've rewritten this PR as it wasn't robust in light of product and category additions. My rewrite also cleanly maps categories. I'm lacking a @flobauer thanks for the initial work! I'm closing this out. |
All fixed, danke für die Hilfe! |
WORK IN PROGRESS!