Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Billa Onlinestore #165

Closed
wants to merge 12 commits into from

Conversation

flobauer
Copy link
Contributor

@flobauer flobauer commented Oct 17, 2023

WORK IN PROGRESS!

@flobauer
Copy link
Contributor Author

This is work in progress, I would like first to check with @badlogic if direction makes sense.

-> with this method I get 15811 products via the API.

Open:

  • how to map categories
  • do we need to worry about subcategories
  • do we map products
  • is data missing in the new API

@flobauer
Copy link
Contributor Author

Ok, when I remove duplicates there are products in multiple categories: New Count is 11842

@badlogic
Copy link
Owner

Looked into it last night. I think it's better to hardcode the category slugs (they don't change for the top level) instead of going through the letters of the alphabet.

Then just fetch all products per category through the respective api and deduplicate.

@flobauer
Copy link
Contributor Author

I added the category list I was able to find so far with slugs to stores/billa-categories.json

@flobauer
Copy link
Contributor Author

Komme auf nur 11993 Produkte

@flobauer
Copy link
Contributor Author

I adapted the product structure, but I have difficulties to standardise the quantity amounts.

@frocentus
Copy link

Ich hab das auch grad mit der einem Powershell-Script nachvollzogen, ich komme auch genau auf 11993 Produkte, die Anzahl in den Kategorien passt nicht zu der Anzahl die man in der tatsächlichen Kategorie rausbekommt.

@badlogic
Copy link
Owner

badlogic commented Oct 17, 2023 via email

@mhochsteger
Copy link
Contributor

I adapted the product structure, but I have difficulties to standardise the quantity amounts.

I will have a look at the quantities.

@badlogic
Copy link
Owner

I'm looking into ensuring the new data is consistent with the old one, so we don't destroy the historic pricing data.

@mhochsteger mhochsteger mentioned this pull request Oct 21, 2023
@mhochsteger
Copy link
Contributor

Made some progress (and a separate PR #166). Data is not consistent yet (and the prices seem to be wrong). I'm on it.

@badlogic
Copy link
Owner

@mhochsteger @flobauer I've rewritten this PR as it wasn't robust in light of product and category additions. My rewrite also cleanly maps categories. I'm lacking a getCanonical() implementation still.

@flobauer thanks for the initial work! I'm closing this out.
@mhochsteger I'll be incorporating your PRs work as well.

@badlogic badlogic closed this Oct 21, 2023
badlogic added a commit that referenced this pull request Oct 21, 2023
@badlogic
Copy link
Owner

All fixed, danke für die Hilfe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants