Failed content in compound messages #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiruzx
reviewed
Feb 16, 2021
| contentTransferStatus.value = .failed | ||
| XCTAssertEqual(viewModel.messageContentTransferStatus, .failed) | ||
| // to get rid of the warning about not used variable | ||
| XCTAssert(presenter === presenter) |
There was a problem hiding this comment.
I think we can do something like this to avoid extra assertion:
let (_, viewModel) = try self.makeRealPresenter(contentTransferStatus: contentTransferStatus)There was a problem hiding this comment.
Unfortunately, due to the fact that compound presenter propagates the action from the content presenter to the View Model, it should be retained until the test case finishes. I tried to wrap the code in the case in autorelease pool but the unused presenter still was deallocating right after the initialisation.
Maybe you can suggest some other way how to keep in memory until the end of the test?
There was a problem hiding this comment.
May be this would work (at the end of the test):
_ = presenterThere was a problem hiding this comment.
Good idea, will do
wiruzx
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an ability to show failed icon when content of some message wrapped in a compound message is failed to load.
When it happened and the message itself is delivered, a content presenter itself should handle the tap on the failed button.