Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added camera type to callback when a photo is taken #696

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

KaneCheshire
Copy link
Collaborator

This PR adds support for providing the camera device / type of camera that took a photo (i.e either front or rear facing camera).

An associated value is added to the PhotosInputViewPhotoSource.camera case, with a value of a newly added CameraType enum type (eitherr front or rear.

This shouldn't be a breaking change for consumers of the API because you can still do:

switch source {
case .gallery: break
case .camera: break
}

But now you can also do:

switch source {
case .gallery: break
case let .camera(cameraType): break
}

@KaneCheshire KaneCheshire changed the base branch from master to bumble-master February 18, 2021 10:30
@KaneCheshire KaneCheshire changed the base branch from bumble-master to master February 18, 2021 10:32
@wiruzx wiruzx merged commit febf21a into master Mar 1, 2021
@wiruzx wiruzx deleted the add-camera-device-support branch March 1, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants