add support for VK_EXT_texture_compression_astc_hdr #2944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR does not look complete, you've only added the extension to the whitelist but you've not implemented anything for it. Vulkan extensions all have feature structures and most have property structures that need to be handled in next chains and serialised, and this extension introduces new formats which will need to be handled (at least to the extent that RenderDoc handles ASTC at all). |
|
Ok! I'll need to take a look at what needs to be serialized for proper support, but it could take sometime for me to do it. I might end up finding someone else to do this. |
|
No problem. If you're not sure when you'll look at it I will close this PR for now then, but please feel free to open a new PR when you or someone has had time to look at it more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add supprot for VK_EXT_texture_compression_astc_hdr