Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undersized buffer for Vulkan pixel history with many fragments #3014

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Fix undersized buffer for Vulkan pixel history with many fragments #3014

merged 2 commits into from
Aug 9, 2023

Commits on Aug 8, 2023

  1. Fix undersized buffer for Vulkan pixel history with many fragments 

    Before, the buffer could be overrun, which could result in anything from
garbage data to the GPU device being lost to segfaults. Now, correct
data is gathered.

We can't know in advance how many primitives will hit the targetted
pixel, so it's not possible to create the buffer until after our first
pass for each events (fortunately we do know the number of events in
advance). It is possible that we don't need a larger buffer, though,
in which case the original one can be re-used.
    @w-pearson
    w-pearson committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    3f6bd6a View commit details
    Browse the repository at this point in the history

  2. Add demo/test for many primitives hitting the same pixel in one drawcall

    @w-pearson
    w-pearson committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    fe32013 View commit details
    Browse the repository at this point in the history