Android hardware buffer handling tweaks #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baldurk
requested changes
May 22, 2024
cmannett85-arm
force-pushed
the
external-format-tweaks
branch
from
28a69ec
to
199528a
Compare
baldurk
reviewed
May 22, 2024
* Calling vkGetImageMemoryRequirements on AHB-backed images before binding is out-of-spec, so that is now deferred until bind * Calling vkCreateImage with an undefined format will cause an error to be returned
cmannett85-arm
force-pushed
the
external-format-tweaks
branch
from
199528a
to
5a0621a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vkGetImageMemoryRequirementson AHB-backed images before binding is out-of-spec, so that is now deferred until bindvkCreateImagewith an undefined format will cause an error to be returned