Snowflake dialect #259
Snowflake dialect #259
Conversation
|
Added a pull request for snowflake dialect . |
Pull Request Test Coverage Report for Build 204251590
💛 - Coveralls |
nickolay
left a comment
nickolay
left a comment
There was a problem hiding this comment.
Note to self: this is the result of splitting #244 into separate PRs at my request. We needed a new dialect to make the parsing quirk dealing with FROM ((table_name)) alias Snowflake-specific.
Please don't forget to add the new dialect to cli.rs and to all_dialects(): https://github.com/ballista-compute/sqlparser-rs/search?q=MsSqlDialect&unscoped_q=MsSqlDialect
tests/sqlparser_snowflake.rs
Outdated
|
|
||
| fn snowflake_and_generic() -> TestedDialects { | ||
| TestedDialects { | ||
| // we don't have a separate SQLite dialect, so test only the generic dialect for now |
There was a problem hiding this comment.
This comment doesn't belong here.
eyalleshem
force-pushed
the
snowflake_dialect
branch
2 times, most recently
from
9055ebf to
f16b90a
Compare
nickolay
left a comment
nickolay
left a comment
There was a problem hiding this comment.
I don't believe you addressed my request to add the new dialect to all_dialects() as well?
eyalleshem
force-pushed
the
snowflake_dialect
branch
from
f16b90a to
db4bad0
Compare
|
Sorry , missed that. |
5 participants
No description provided.