Use output display or region geometry to record #1920
Merged
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamobservable
force-pushed
the
iamobservable/bug/screen-recording-no-longer-works-after-updating
branch
3 times, most recently
from
fdd9de8 to
f6109c7
Compare
|
Thank you! Hope this gets merged asap |
You are welcome and glad to help! |
ryanrhughes
requested changes
Sep 26, 2025
Absolutely. I saw a few other comments already within the file and was not sure of the comment/documentation necessary, so I weighed on adding them. |
The previous code did not identify the output display correctly, leading to wf-recorder asking the user to select the region when the user requested the display output to be selected. With this change the bash script will use slurp with the -o flag to identify the display output. This has not been tested with wl-screenrec as no change has been made to its call signature in omarchy-cmd-screenrecord and the wl-screenrec binary is not included in the default omarchy installation.
iamobservable
force-pushed
the
iamobservable/bug/screen-recording-no-longer-works-after-updating
branch
from
f6109c7 to
d4b0ba5
Compare
Updated! |
ryanrhughes
approved these changes
Sep 26, 2025
iamobservable
deleted the
iamobservable/bug/screen-recording-no-longer-works-after-updating
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this PR as a fix for #1858
The identified issue is when using the hyprctl bindings from default/hypr/bindings/utilities.conf
The call to omarchy-cmd-screenrecord differentiates output versus region as the first parameter used. A conditional is used to identify if the bash script caller is expecting a region or a display output for screen recording. The region handled this as a geometry, first calling slurp, and passing it to wf-recorder or wf-screenrec. The display was calling wf-recorder or wf-screenrec without any geometry flags which had an unexpected response, always attempting to capture the region of the screen allowing no way to capture solely the display.
Details for reference
wf-recorder usage
slurp usage reference