RiakTs CreateTable command #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| private static final TableDefinition tableDefinition = new TableDefinition("TestTable", Arrays.asList( | ||
| new FullColumnDescription("field1", ColumnDescription.ColumnType.TIMESTAMP, false, 1), | ||
| new FullColumnDescription("field2", ColumnDescription.ColumnType.SINT64, false, null, 1), |
There was a problem hiding this comment.
Do you think this case should result in an error when creating the TableDefinition? (Having 2 columns with the same key ordinal #). The null ordinal # is confusing too...
There was a problem hiding this comment.
Hm.. my bad.. I forgot about the necessity of having the whole PK as a head of a local key :(
|
+1. Works as advertised. I'll have to see if we need to add any extra validation to ensure that one key type is null while the other is defined (your second column), but that can wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.