Skip to content

Conversation

seancribbs
Copy link

  • bucket and client-level quorum accessors (see riak.util.deprecatedQuorumAccessors)
  • RiakBucket.get_binary, RiakBucket.new_binary, RiakBucket.new_binary_from_file
  • RiakClient.get_client_id and RiakClient.set_client_id
  • RiakClient.solr

@seancribbs seancribbs added this to the Client 2.1 (Riak 2.0) milestone May 12, 2014
@seancribbs seancribbs modified the milestones: 2.0, 2.0-RC Jun 2, 2014
@seancribbs seancribbs assigned seancribbs and unassigned seancribbs Jul 28, 2014
seancribbs referenced this pull request Jul 28, 2014
I originally set out to investigate the deletedvclock issue in #332,
but discovered that these quorum parameters were missing.
@hazen hazen self-assigned this Jul 29, 2014
@hazen
Copy link

hazen commented Jul 29, 2014

👍 0f42b67

@seancribbs
Copy link
Author

Rebased!

@hazen
Copy link

hazen commented Jul 29, 2014

Ooops. Seeing some failures:

======================================================================
ERROR: test_resolution (riak.tests.test_all.RiakHttpTransportTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/hazen/dev/clients/python/sean.328/riak/tests/test_kv.py", line 362, in test_resolution
    vals = self.generate_siblings(obj, count=5, delay=1.01)
  File "/Users/hazen/dev/clients/python/sean.328/riak/tests/test_kv.py", line 512, in generate_siblings
    other_obj.store()
  File "/Users/hazen/dev/clients/python/sean.328/riak/riak_object.py", line 273, in store
    timeout=timeout)
  File "/Users/hazen/dev/clients/python/sean.328/riak/client/transport.py", line 184, in wrapper
    return self._with_retries(pool, thunk)
  File "/Users/hazen/dev/clients/python/sean.328/riak/client/transport.py", line 126, in _with_retries
    return fn(transport)
  File "/Users/hazen/dev/clients/python/sean.328/riak/client/transport.py", line 182, in thunk
    return fn(self, transport, *args, **kwargs)
  File "/Users/hazen/dev/clients/python/sean.328/riak/client/operations.py", line 363, in put
    timeout=timeout)
  File "/Users/hazen/dev/clients/python/sean.328/riak/transports/http/transport.py", line 162, in put
    return self._parse_body(robj, response, [200, 201, 204, 300])
  File "/Users/hazen/dev/clients/python/sean.328/riak/transports/http/codec.py", line 91, in _parse_body
    if robj.resolver is not None:
  File "/Users/hazen/dev/clients/python/sean.328/riak/riak_object.py", line 224, in _get_resolver
    return self.bucket.resolver
  File "/Users/hazen/dev/clients/python/sean.328/riak/bucket.py", line 222, in _get_resolver
    return self._client.resolver
AttributeError: 'RiakClient' object has no attribute 'resolver'

@seancribbs
Copy link
Author

I must have botched the rebase.

@seancribbs
Copy link
Author

Yep, I'll retry.

borshop added a commit that referenced this pull request Jul 29, 2014
…atures

Remove deprecated features

Reviewed-by: javajolt
@seancribbs
Copy link
Author

@borshop merge

@borshop borshop merged commit c0bd392 into master Jul 29, 2014
@seancribbs seancribbs deleted the feature/gh328-remove-deprecated-features branch July 29, 2014 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants