Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSL host name #436

Merged
merged 7 commits into from
Feb 19, 2016
Merged

Fix SSL host name #436

merged 7 commits into from
Feb 19, 2016

Conversation

lukebakken
Copy link
Contributor

Fixes #433 (CLIENTS-753) and #434 (CLIENTS-765)

Depends on basho/riak-client-tools#4

@@ -91,7 +90,6 @@ def test_security_password_without_cacert(self):
@unittest.skipUnless(RUN_SECURITY, 'RUN_SECURITY is 0')
def test_security_cert_authentication(self):
creds = SecurityCreds(username=SECURITY_CERT_USER,
password=SECURITY_CERT_PASSWD,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: password is not required for cert-based auth.

@@ -1,6 +1,6 @@
include docs/*
include riak/erl_src/*
include README.rst
include README.md
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to be consistent. It's all MarkDown these days

@hazen
Copy link

hazen commented Feb 19, 2016

Now that I tweaked my environment, life it good

@hazen
Copy link

hazen commented Feb 19, 2016

👍 550a2d1

borshop added a commit that referenced this pull request Feb 19, 2016
@lukebakken
Copy link
Contributor Author

@borshop merge

@borshop borshop merged commit 550a2d1 into master Feb 19, 2016
@hazen hazen deleted the features/lrb/gh-434-riak-client-tools branch February 19, 2016 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants