Skip to content

Conversation

bashtage
Copy link
Owner

@bashtage bashtage commented Jun 4, 2019

Extend generators to RDRAND

@bashtage bashtage force-pushed the rdrand branch 3 times, most recently from 223c6a2 to a3f2556 Compare June 4, 2019 12:10
@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #140 into master will decrease coverage by 0.15%.
The diff coverage is 81.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   93.41%   93.25%   -0.16%     
==========================================
  Files          30       31       +1     
  Lines        8433     8545     +112     
  Branches      126      127       +1     
==========================================
+ Hits         7878     7969      +91     
- Misses        534      555      +21     
  Partials       21       21
Impacted Files Coverage Δ
randomgen/tests/test_smoke.py 98.21% <ø> (ø) ⬆️
randomgen/tests/test_generator_mt19937.py 99.31% <ø> (ø) ⬆️
randomgen/_pickle.py 85.36% <100%> (+0.36%) ⬆️
randomgen/xoshiro512starstar.py 100% <100%> (ø) ⬆️
randomgen/rdrand.pyx 72.05% <72.05%> (ø)
randomgen/tests/test_direct.py 98.19% <95.34%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56861b5...dc7b451. Read the comment docs.

@bashtage
Copy link
Owner Author

bashtage commented Jun 4, 2019

This pull request introduces 1 alert when merging 853c30d into 56861b5 - view on LGTM.com

new alerts:

  • 1 for Missing header guard

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@bashtage bashtage force-pushed the rdrand branch 2 times, most recently from 173d9c0 to dfde083 Compare June 4, 2019 12:41
@bashtage
Copy link
Owner Author

bashtage commented Jun 4, 2019

This pull request introduces 1 alert when merging dfde083 into 56861b5 - view on LGTM.com

new alerts:

  • 1 for Missing header guard

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@bashtage
Copy link
Owner Author

bashtage commented Jun 4, 2019

This pull request introduces 1 alert when merging 4f09155 into 56861b5 - view on LGTM.com

new alerts:

  • 1 for Missing header guard

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@bashtage bashtage force-pushed the rdrand branch 4 times, most recently from 18ad98c to 56f1527 Compare June 4, 2019 14:27
Extend generators to RDRAND
@bashtage
Copy link
Owner Author

bashtage commented Jun 4, 2019

This pull request introduces 2 alerts when merging dc7b451 into 56861b5 - view on LGTM.com

new alerts:

  • 2 for Duplicate include guard

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@bashtage bashtage merged commit db8c605 into master Jun 4, 2019
@bashtage bashtage deleted the rdrand branch June 4, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant